Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Liang, Kan" <kan.liang@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
CC:     "peterz@infradead.org" <peterz@infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "acme@kernel.org" <acme@kernel.org>,
        "eranian@google.com" <eranian@google.com>,
        "ak@linux.intel.com" <ak@linux.intel.com>
Subject: RE: [PATCH V3 1/5] perf/x86/intel/uncore: customized pmu event read
 for client IMC uncore
Thread-Topic: [PATCH V3 1/5] perf/x86/intel/uncore: customized pmu event
 read for client IMC uncore
Thread-Index: AQHTTPn8N2Thg1PlBU23gMJh7UBtUqMAoguAgACGaBA=
Date:   Thu, 2 Nov 2017 13:51:58 +0000
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077537DCA04@SHSMSX103.ccr.corp.intel.com>
References: <1508843124-4081-1-git-send-email-kan.liang@intel.com>
 <alpine.DEB.2.20.1711021446030.2090@nanos>
In-Reply-To: <alpine.DEB.2.20.1711021446030.2090@nanos>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> On Tue, 24 Oct 2017, kan.liang@intel.com wrote:
> > -	if (event->hw.idx >= UNCORE_PMC_IDX_FIXED)
> > +	if (event->hw.idx == UNCORE_PMC_IDX_FIXED)
> >  		shift = 64 - uncore_fixed_ctr_bits(box);
> >  	else
> >  		shift = 64 - uncore_perf_ctr_bits(box); diff --git
> > a/arch/x86/events/intel/uncore_snb.c
> > b/arch/x86/events/intel/uncore_snb.c
> > index db1127c..9d5cd3f 100644
> > --- a/arch/x86/events/intel/uncore_snb.c
> > +++ b/arch/x86/events/intel/uncore_snb.c
> > @@ -498,6 +498,30 @@ static void snb_uncore_imc_event_del(struct
> perf_event *event, int flags)
> >  	snb_uncore_imc_event_stop(event, PERF_EF_UPDATE);  }
> >
> > +static void snb_uncore_imc_event_read(struct perf_event *event) {
> > +	struct intel_uncore_box *box = uncore_event_to_box(event);
> > +	u64 prev_count, new_count, delta;
> > +	int shift;
> > +
> > +	if (event->hw.idx >= UNCORE_PMC_IDX_FIXED)
> 
> And this needs to be >= because?

Patch 5/5 will clean up the client IMC uncore.
Before that, we still need it to make client IMC uncore work.

This patch isolates the >= case for client IMC uncore.

Thanks,
Kan


From 1582962309734866726@xxx Thu Nov 02 13:48:18 +0000 2017
X-GM-THRID: 1582166476632080836
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread