Received: by 10.223.164.221 with SMTP id h29csp2274835wrb; Thu, 2 Nov 2017 08:25:46 -0700 (PDT) X-Google-Smtp-Source: ABhQp+T5c6+2z+kZYfmheTpXU5qwcN+vY69ulbq2MLHy4e05RSs2B7M+2DKR857Z8znrrPCCTZ7B X-Received: by 10.98.150.19 with SMTP id c19mr4125623pfe.239.1509636346757; Thu, 02 Nov 2017 08:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509636346; cv=none; d=google.com; s=arc-20160816; b=w6DcIlDVWsCkWSjJ580Inz1qQv2HdSG/7U0DtWPOEsP4HfgcSzPiWL9dz0ZcRLtwVk lZWpjSQEVTF4AeAYtjEUubb0YFQtLtd+38qoUCNFzV0lNirVKZwJrgOqSL0lq6UVwya9 IZBszGsQ6Gto5WItyyWNhvc2raCeZvX0zktVYcghzTgLvhiDBQpTcI6UOz1PjuKHfTkp IcVsZusj1sOPQw5bynz2ld7QVVkoEjoDrwhy+hK4C8cf2dH9dxAk2pjfKXhIYJ+cwtoI luHyRt+eqYcEmIYPs8p0ll8z9LzKYaCXkyfGJPYFB/Nu59hGj+xqfdz9ZtVFeBEsdouZ R4kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Gcxe4mAVaRfV7lN9tb+vH7nDPNuhWr+xkZiF9ouHp2c=; b=cUONJXO6+ImDNQzLILkgs36hkc9lFnGN+odgASTOXT81t3f2CnvE9U0UfU0UdoD9MO Z4b8c+sSFoSDZl1tZCvScSsIxfeX3mD+pCzX2uQU/mY4j+m4zvqzqLpYSULl028IHLht VUDwwX2Cx8zYJxyPj232NNaaoZC5owQnIlk4xIk9MfBGcDM8IF39Fgsle9eNJNsc6da0 fdpJjTZP73nXwWo8dMrdpZAUTv0PcmscZ6P5TuXwDZQNOZ+XaF/cUrHtWAY8TsdPKcUR voaWPRqtkBTfoPhnkbgNIhakDUIb8LqaikBlSC9nbBjCrap5DAnBLfbclE0vTC1wDjWd EkGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@qca.qualcomm.com header.s=qcdkim header.b=l96kSvyw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=qca.qualcomm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v8si2596613plk.128.2017.11.02.08.25.33; Thu, 02 Nov 2017 08:25:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@qca.qualcomm.com header.s=qcdkim header.b=l96kSvyw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=qca.qualcomm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933746AbdKBPXr (ORCPT + 97 others); Thu, 2 Nov 2017 11:23:47 -0400 Received: from sabertooth01.qualcomm.com ([65.197.215.72]:46704 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933418AbdKBPXp (ORCPT ); Thu, 2 Nov 2017 11:23:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1509636225; x=1541172225; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Gcxe4mAVaRfV7lN9tb+vH7nDPNuhWr+xkZiF9ouHp2c=; b=l96kSvywnkNJg9TF/khgdrMG3DiGmHLd36k5sMp2eWTlnJu93soTflA1 jEX2oj2GMuOKu8RQmHBbZASsRIjFS9aPidMkJy+1xOhqWqiDle4q+EgzB f4B6WtlzAtTQC4ylLGRZsB9a73A9B41X9kL4sKWwT//HFflUM04YkqaL/ o=; X-IronPort-AV: E=Sophos;i="5.44,334,1505804400"; d="scan'208";a="116387911" Received: from unknown (HELO Ironmsg04-R.qualcomm.com) ([10.53.140.108]) by sabertooth01.qualcomm.com with ESMTP; 02 Nov 2017 08:23:44 -0700 X-IronPort-AV: E=McAfee;i="5900,7806,8702"; a="1525717657" X-MGA-submission: =?us-ascii?q?MDHK7kvN9UmRQwqP/85uUvQb5iPG+fnfd0pebr?= =?us-ascii?q?NgKxWfNp1SFuVM2ZK4Sa+ZYQSIseYfIJT55VTlnswMIriTKPedAu7lDn?= =?us-ascii?q?7lQhZuaoyhF2Ean/wGbOh34oSwFjh5bdJLgXAa8gk5PRfgsMvGV65DP7?= =?us-ascii?q?oD?= Received: from nasanexm01b.na.qualcomm.com ([10.85.0.82]) by Ironmsg04-R.qualcomm.com with ESMTP/TLS/AES256-SHA; 02 Nov 2017 08:23:43 -0700 Received: from eusanexr01a.eu.qualcomm.com (10.85.0.97) by NASANEXM01B.na.qualcomm.com (10.85.0.82) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Thu, 2 Nov 2017 08:23:42 -0700 Received: from eusanexr01a.eu.qualcomm.com ([10.85.0.97]) by eusanexr01a.eu.qualcomm.com ([10.85.0.97]) with mapi id 15.00.1293.002; Thu, 2 Nov 2017 08:23:43 -0700 From: Kalle Valo To: Arnd Bergmann CC: Ryan Hsu , Govind Singh , Srinivas Kandagatla , Ashok Raj Nagarajan , Ben Greear , "Brian Norris" , Colin Ian King , "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ath10k: move pci suspend/resume functions Thread-Topic: [PATCH] ath10k: move pci suspend/resume functions Thread-Index: AQHTU8sIUwjYYm0/ZUGKqAY2G2HYKA== Date: Thu, 2 Nov 2017 15:23:42 +0000 Message-ID: <87mv44ln5v.fsf@qca.qualcomm.com> References: <20171102110903.2886660-1-arnd@arndb.de> In-Reply-To: <20171102110903.2886660-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 2 Nov 2017 12:08:53 +0100") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > The combination of two patches has led to a build failure: > > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend= ': > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration= of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-= Werror=3Dimplicit-function-declaration] > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume'= : > drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration= of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-We= rror=3Dimplicit-function-declaration] > > This moves the functions outside of the now incorrect #ifdef. > > Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is support= ed but disabled") > Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused") > Signed-off-by: Arnd Bergmann Brian has already fixed this, please check that: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=3Da= th-next&id=3D20665a9076d48e9abd9a2db13d307f58f7ef6647 But apparently I forgot to merge ath-next to wireless-drivers-next, will do that soon. --=20 Kalle Valo= From 1582952437193381296@xxx Thu Nov 02 11:11:23 +0000 2017 X-GM-THRID: 1582952437193381296 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread