Received: by 10.223.164.221 with SMTP id h29csp2574683wrb; Thu, 2 Nov 2017 13:21:32 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Rbwo259M/FzDbpInveo3uNnzQD0racdGSZp2UH5AQswi6sd4H/7B6xwPmCysA7kBb8hpkN X-Received: by 10.98.74.206 with SMTP id c75mr5221848pfj.100.1509654092345; Thu, 02 Nov 2017 13:21:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509654092; cv=none; d=google.com; s=arc-20160816; b=KpUvp0aRY2QHG2+8qQdu8FkGHg6e+k56HkO8OmAbai12LKY+fKqMPLvtKHLlM49Ymq L6jl4NZixHKubCdWXwm715xqbuJSQS/+unNOBfCfZ1R9EUzMoT06MX3CdUHB6GD09COA thIlIqp0flPlqK64Jm5nGWjAl9zos405PsVQkbB5HiuIxWpMOJyMCR4twJPeK5XVME68 8AxD1p8YNhi3FcMF2QAR0FyEjAgLC4X9Q0uBZGgpAwkffJzM8f9pf+pO73loFTeBqcs3 tkPCUUIEm7LwSA8wwezx5CsgxmCJLvesoudgRLH5CJZXmcfY/XJen2WZv0McJFBYfA1O 4jug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=LFR6JnPyQdchU+4ONYtYYWggJL9sOCbFQsepVjOtreM=; b=Sj5SG73JpwgcnK45nRHUEkDWMDVlFDJsUzPtSWspN3OX8rFAXkN9QdgvCoMxjr8Yq6 6Yzlx1EQjgTktl4OxKjYVfFKpozJHLb3iyXvF5s53OYt2NoWBdb1dxfuL2rI0PfHtLdK p7lmCkLXhawYXJDpYebHKSDsb5kUo/vg+mzjihnq9MSsiobENotI13Ya0v7ObnOEQ2jN QYFv6PGJ3LKCfF1yr1YaSkNldxSb1FBF8bV4Na4Cke0irhBSqbU/dk2988bixQpsUQKP X84FTvLSOVWAZe+eFaRBDUPfgxfKQFjE7BrIB08Ue/0Xc4OrGKAbTXCWJPaHAyNwEEN6 RV1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u187si4083189pgb.536.2017.11.02.13.21.13; Thu, 02 Nov 2017 13:21:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964845AbdKBUUf (ORCPT + 99 others); Thu, 2 Nov 2017 16:20:35 -0400 Received: from gateway34.websitewelcome.com ([192.185.150.114]:45079 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbdKBUUe (ORCPT ); Thu, 2 Nov 2017 16:20:34 -0400 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 75131300B39 for ; Thu, 2 Nov 2017 15:20:34 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id ALycekHdZRtUXALycewCHl; Thu, 02 Nov 2017 15:20:34 -0500 Received: from [189.145.38.148] (port=41374 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.87) (envelope-from ) id 1eALyc-001iRx-1s; Thu, 02 Nov 2017 15:20:34 -0500 Date: Thu, 2 Nov 2017 15:20:33 -0500 From: "Gustavo A. R. Silva" To: Ben Skeggs , David Airlie Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] drm/nouveau/bios/timing: mark expected switch fall-throughs Message-ID: <20171102202033.GA10647@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.145.38.148 X-Source-L: No X-Exim-ID: 1eALyc-001iRx-1s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.145.38.148]:41374 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 10 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1260018 Addresses-Coverity-ID: 1260019 Addresses-Coverity-ID: 1260022 Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c index 7e83c39..20ff517 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/timing.c @@ -115,16 +115,21 @@ nvbios_timingEp(struct nvkm_bios *bios, int idx, switch (min_t(u8, *hdr, 25)) { case 25: p->timing_10_24 = nvbios_rd08(bios, data + 0x18); + /* fall through */ case 24: case 23: case 22: p->timing_10_21 = nvbios_rd08(bios, data + 0x15); + /* fall through */ case 21: p->timing_10_20 = nvbios_rd08(bios, data + 0x14); + /* fall through */ case 20: p->timing_10_CWL = nvbios_rd08(bios, data + 0x13); + /* fall through */ case 19: p->timing_10_18 = nvbios_rd08(bios, data + 0x12); + /* fall through */ case 18: case 17: p->timing_10_16 = nvbios_rd08(bios, data + 0x10); -- 2.7.4 From 1582982384157784204@xxx Thu Nov 02 19:07:23 +0000 2017 X-GM-THRID: 1582914567444058267 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread