Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm/swap: Use page flags to determine LRU list in
 __activate_page()
To:     Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@kernel.org>,
        Anshuman Khandual <khandual@linux.vnet.ibm.com>
References: <20171019145657.11199-1-khandual@linux.vnet.ibm.com>
 <20171019153322.c4uqalws7l7fdzcx@dhcp22.suse.cz>
 <23110557-b2db-9f4a-d072-ad58fd0c1931@suse.cz>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, shli@kernel.org
From:   Anshuman Khandual <khandual@linux.vnet.ibm.com>
Date:   Thu, 2 Nov 2017 17:14:40 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <23110557-b2db-9f4a-d072-ad58fd0c1931@suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Message-Id: <40de21c5-9f6e-d34a-6db5-445c43a1266b@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/31/2017 06:15 PM, Vlastimil Babka wrote:
> On 10/19/2017 05:33 PM, Michal Hocko wrote:
>> On Thu 19-10-17 20:26:57, Anshuman Khandual wrote:
>>> Its already assumed that the PageActive flag is clear on the input
>>> page, hence page_lru(page) will pick the base LRU for the page. In
>>> the same way page_lru(page) will pick active base LRU, once the
>>> flag PageActive is set on the page. This change of LRU list should
>>> happen implicitly through the page flags instead of being hard
>>> coded.
>>
>> The patch description tells what but it doesn't explain _why_? Does the
>> resulting code is better, more optimized or is this a pure readability
>> thing?
>>
>> All I can see is that page_lru is more complex and a large part of it
>> can be optimized away which has been done manually here. I suspect the
>> compiler can deduce the same thing.
> 
> We shouldn't overestimate the compiler (or the objective conditions it
> has) for optimizing stuff away:
> 
> After applying the patch:
> 
> ./scripts/bloat-o-meter swap_before.o mm/swap.o
> add/remove: 0/0 grow/shrink: 1/0 up/down: 160/0 (160)
> function                                     old     new   delta
> __activate_page                              708     868    +160
> Total: Before=13538, After=13698, chg +1.18%
> 
> I don't think we want that, it's not exactly a cold code...

Yeah, makes sense.


From 1582777300570682569@xxx Tue Oct 31 12:47:40 +0000 2017
X-GM-THRID: 1581706618333065037
X-Gmail-Labels: Inbox,Category Forums