Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 31 Oct 2017 11:18:42 +0100
From:   Boris Brezillon <boris.brezillon@free-electrons.com>
To:     motobud@gmail.com
Cc:     Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: nand: Fix writing mtdoops to nand flash.
Message-ID: <20171031111842.6b42ed23@bbrezillon>
In-Reply-To: <20171031033246.8576-1-motobud@gmail.com>
References: <20171030042343.24551-1-motobud@gmail.com>
        <20171031033246.8576-1-motobud@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 30 Oct 2017 22:32:45 -0500
motobud@gmail.com wrote:

> From: Brent Taylor <motobud@gmail.com>
> 
> When mtdoops calls mtd_panic_write, it eventually calls
> panic_nand_write in nand_base.c.  In order to properly
> wait for the nand chip to be ready in panic_nand_wait,
> the chip must first be selected.
> 
> When using the atmel nand flash controller, a panic
> would occur due to a NULL pointer exception.
> 
> Signed-off-by: Brent Taylor <motobud@gmail.com>

I'll add

Fixes: 2af7c6539931 ("mtd: Add panic_write for NAND flashes")
Cc: <stable@vger.kernel.org>

when applying the patch.

Thanks,

Boris

> ---
> Changes in v2:
>   - drop deselecting the chip
>   - move select_chip and panic_nand_wait after panic_nand_get_device
> 
>  drivers/mtd/nand/nand_base.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 12edaae17d81..2093667e2bcb 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -2802,12 +2802,16 @@ static int panic_nand_write(struct mtd_info *mtd, loff_t to, size_t len,
>  	struct mtd_oob_ops ops;
>  	int ret;
>  
> -	/* Wait for the device to get ready */
> -	panic_nand_wait(mtd, chip, 400);
> +	int chipnr = (int)(to >> chip->chip_shift);
>  
>  	/* Grab the device */
>  	panic_nand_get_device(chip, mtd, FL_WRITING);
>  
> +	chip->select_chip(mtd, chipnr);
> +
> +	/* Wait for the device to get ready */
> +	panic_nand_wait(mtd, chip, 400);
> +
>  	memset(&ops, 0, sizeof(ops));
>  	ops.len = len;
>  	ops.datbuf = (uint8_t *)buf;


From 1582742523774112681@xxx Tue Oct 31 03:34:54 +0000 2017
X-GM-THRID: 1582742523774112681
X-Gmail-Labels: Inbox,Category Forums