Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: mptsas driver cannot detect hotplugging disk with the LSI SCSI
 SAS1068 controller in Ubuntu guest on VMware
To:     Gavin Guo <gavin.guo@canonical.com>
Cc:     linux-scsi@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <CA+eFSM1aJRYs__pwtz+8E0TFOeKuKpHoiOkX6Wmm_2HMT1ut5A@mail.gmail.com>
 <1ad520f6-a1d8-5ce7-ee74-83edfdbfd39b@suse.de>
 <CA+eFSM24pwY0ViCiUqvzNDJa-Q0h0+XnEFF-gesKfBcEVKyLgQ@mail.gmail.com>
 <CA+eFSM3z=LdO78seoZtpAc7U7ec=Gzrm5ej76TafoM6Ea1Ektw@mail.gmail.com>
 <486fc58e-ac8f-cb48-4757-0b9a8e1c2121@suse.de>
 <CA+eFSM2hCmVTdAuvX0MeRzKLhCJJo1DePCo2jhjUXstguYNtgg@mail.gmail.com>
 <CA+eFSM3-ON+HhnepyXTtzAGSmA-Yvp6Eq9pmhcAXNrofpiBAVw@mail.gmail.com>
From:   Hannes Reinecke <hare@suse.de>
Message-ID: <f6b38a1b-09d4-5aea-a8d6-c7568680823a@suse.de>
Date:   Fri, 3 Nov 2017 11:59:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CA+eFSM3-ON+HhnepyXTtzAGSmA-Yvp6Eq9pmhcAXNrofpiBAVw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/03/2017 04:38 AM, Gavin Guo wrote:
> On Sat, Oct 28, 2017 at 11:35 AM, Gavin Guo <gavin.guo@canonical.com> wrote:
>> On Fri, Oct 27, 2017 at 10:53 PM, Hannes Reinecke <hare@suse.de> wrote:
>>> On 10/27/2017 04:02 PM, Gavin Guo wrote:
>>>> Hi Hannes,
>>>>
>>>> Thank you for looking into the issue. If there is anything I can help
>>>> to test the patch? I appreciate your help. Thank you.
>>>>
>>> If you had checked linux-scsi you would have found this patch:
>>> '[PATCH] mptsas: Fixup device hotplug for VMWare ESXi', which I guess is
>>> already scheduled for inclusion in 4.14.
>>> Anything else I could help you with?
>>>
>>> Cheers,
>>>
>>> Hannes
>>> --
>>> Dr. Hannes Reinecke                Teamlead Storage & Networking
>>> hare@suse.de                                   +49 911 74053 688
>>> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
>>> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
>>> HRB 21284 (AG Nürnberg)
>>
>> Really appreciate your help. I will proceed the testing and keep you posted.
> 
> Hello Hannes,
> 
> I've tested the MPT SAS device controller, the patch works perfectly.
> However, the MPT SPI still cannot work with the hotplugging. The lspci
> of the LSI SPI device is listed:
> 
> 00:10.0 SCSI storage controller [0100]: LSI Logic / Symbios Logic
> 53c1030 PCI-X Fusion-MPT Dual Ultra320 SCSI [1000:0030] (rev 01)
>         Subsystem: VMware LSI Logic Parallel SCSI Controller [15ad:1976]
>         Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B- DisINTx-
>         Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium
>> TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Latency: 64 (1500ns min, 63750ns max)
>         Interrupt: pin A routed to IRQ 17
>         Region 0: I/O ports at 1400 [size=256]
>         Region 1: Memory at feba0000 (64-bit, non-prefetchable) [size=128K]
>         Region 3: Memory at febc0000 (64-bit, non-prefetchable) [size=128K]
>         [virtual] Expansion ROM at 40008000 [disabled] [size=16K]
>         Kernel driver in use: mptspi
> 
> The vendor id/device id[1000:0030] can also be found in the
> mptspi_pci_table(drivers/message/fusion/mptspi.c).
> 
> PCI_VENDOR_ID_LSI_LOGIC, MPI_MANUFACTPAGE_DEVID_53C1030
> 
> If there is anything I missed in the testing? I appreciate your help.
> 
Don't. Ever. Try.

SCSI Parallel hotplugging is so loosely defined that essentially every
vendor can (and did!) implement their own thing, and _still_ be spec
compliant.
Plus there is no guarantee that we even see events when a hot-add
occurs. So any thingie we put in here has a really high chance of
breaking other installations.
I wouldn't even bother to attempt this; it's virtualized anyway so you
can as well switch to the SAS emulation here.
Or use a different SCSI parallel emulation like the Symbios/LSI 53c800 one.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

From 1583014624689987804@xxx Fri Nov 03 03:39:50 +0000 2017
X-GM-THRID: 1579677274363332634
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread