Received: by 10.223.164.221 with SMTP id h29csp2726042wrb; Tue, 3 Oct 2017 09:50:11 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBM4NvMwQ+UlBAVTINKNz5Lddl+AhmwK/e6yZn+Ezn1xubdxI8Ys3qzpz9feJbSTvC57sCg X-Received: by 10.84.132.111 with SMTP id 102mr17427159ple.348.1507049411450; Tue, 03 Oct 2017 09:50:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507049411; cv=none; d=google.com; s=arc-20160816; b=Jl0C0EsgbnV0yBE5ondwZDM/S6TUabFOTbwL+g5ErcEuLcLMAHlu1B4JP5p+47pV4j hxN2lWkJhxOrroTcGhMvPvTx84HQ7kWaxNcRfsJ0LcYccXTfEK+WHL+S93ZzOhGOXnXr XiL8W3f2b0WRkkPhdep8m2rmvW3HqrSJJLvrMNasP0YBuhhIAVNb0VKUBzRxZT4YkF9b JsuMP14kwEt3yREBIO5fBr3YkQja2i2tFKAxtKvPH2NmY0OWRm3bPh3sMcq312XAyMPh +5vhIbocqgYxBG57B7065UiqNnTqSHf0wZOnm/JITW0TvkbVDPwFKj69sSkWN/3TCJn/ KbMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ticGVYVV7KjoBMJ50YQU6+95odR8C3GEXHLa2kkzPDo=; b=AYYpWym7bP9ftaFI+DTc+6UQaKZYs3+pyqbZMA9WzizmqSluUmCfttRWT8nLS7D5U/ ZEXgvyt3A4SxaQi7xCi2lEH87bXp7xgoGtBKOcbr5lEdxzzzcBgIOfFKHshCm0Rw8ZzM eyDozfdIKRqDLGK1V23ZWKfWuaLKAwztvnDKwEUXAz1sB/hEkGWo4gxbQlMrJ6yqziFU Vty+r1soF+joNpQZqNepwGeZMDVZunF30CuYg0nl0TlaVeOwb48deTr6RWReNv2zzHQf 2qaG/1MjrQoIMVriRhAZhUh8SBvz7y/9ZD2+55ClF8ws1cKao1QGd/LaQIgNL4j7Bwz3 4TOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=RPSFkguz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c79si115426pfd.234.2017.10.03.09.49.56; Tue, 03 Oct 2017 09:50:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=RPSFkguz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577AbdJCQtC (ORCPT + 99 others); Tue, 3 Oct 2017 12:49:02 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:55544 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752132AbdJCQtA (ORCPT ); Tue, 3 Oct 2017 12:49:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ticGVYVV7KjoBMJ50YQU6+95odR8C3GEXHLa2kkzPDo=; b=RPSFkguzuGXa++R0mAxSw6/iZ PcoOwfMBuErUA6X8WiakTXgtxQgaFHvM703MFm+sFYFG+uYycnVqEu0U6RY4izE1cNHZkzslTSfge giG0LHcNrXgN6PSXVeq3b9ZUcJfo359aFRegh0z2NerqQ5k3WRvehXlP5rFWudOjA71PE=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1dzQNG-0005HA-GI; Tue, 03 Oct 2017 16:48:50 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 53788440053; Tue, 3 Oct 2017 17:48:49 +0100 (BST) Date: Tue, 3 Oct 2017 09:48:49 -0700 From: Mark Brown To: Laura Abbott Cc: Benjamin Gaignard , sumit.semwal@linaro.org, gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com, dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-api@vger.kernel.org Subject: Re: [PATCH v5 2/2] staging: ion: create one device entry per heap Message-ID: <20171003164849.rcdgez6lbpmq5llt@sirena.org.uk> References: <1506518409-16887-1-git-send-email-benjamin.gaignard@linaro.org> <1506518409-16887-3-git-send-email-benjamin.gaignard@linaro.org> <2e15edc2-a17f-3930-7d5b-4b5b7d2e0a4d@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fcwkpm357ypn6nz7" Content-Disposition: inline In-Reply-To: <2e15edc2-a17f-3930-7d5b-4b5b7d2e0a4d@redhat.com> X-Cookie: MIT: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fcwkpm357ypn6nz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 02, 2017 at 11:07:48AM -0700, Laura Abbott wrote: > Thinking about this a bit more, I'm not 100% sure if this > will allow the security rules we want. Heap ids are assigned > dynamically and therefore so will the /dev/ionX designation. > From my understanding, security rules like selinux need to > be fully specified at boot time so I'm not sure how you would > be able to write rules to differentiate between /dev/ionX and > /dev/ionY without knowing the values at boottime. Isn't this something that should be managable via udev rules that ensure stable names in the same way as for things like disks or ethernet controllers (even if it just ends up doing something like /dev/ion-gpu or whatever)? If we're not giving it enough information to assign stable names where needed we probably need to fix that anyway. --fcwkpm357ypn6nz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlnTv24ACgkQJNaLcl1U h9DuvQf9GkTZ3z5XJ8MEuc2dMn+kBEvgOny2P69T+H2ioFQgZJymKQbyR4bP86Li n2LWCF54U7+pnPenVa1KNprFaBfv3n05nNscbjiqYcyaDzL/fntRvM2aaHE0iFBU NLNL37BLl9egvsPwFPqoHsMp9BJVwmPEGdk1jrproeSZ4vd5G8Q53c0vtsVzBcTw wXLPOhWERHLeOTiwIor4pVNiIazFDnMWOtau/KUV3LvZDX9cR8xWQg0TqqodIH3c v/D0RRS+CquKpGocUs1K7TWpca+U6VzEL2w9PYUElMhfdEhmjL5aYilV8R/05SjF u7zgiSCiXYxRryK3sx3QG8uSsqraFg== =awwB -----END PGP SIGNATURE----- --fcwkpm357ypn6nz7-- From 1580170180185027449@xxx Mon Oct 02 18:08:36 +0000 2017 X-GM-THRID: 1579699119100728687 X-Gmail-Labels: Inbox,Category Forums