Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sumit Saxena <sumit.saxena@broadcom.com>
References: <1508925428-51660-1-git-send-email-xieyisheng1@huawei.com>
In-Reply-To: <1508925428-51660-1-git-send-email-xieyisheng1@huawei.com>
MIME-Version: 1.0
Thread-Index: AQHIDvQyF6gY9bI2hKyfpWtJaINO4qMUvzPA
Date:   Tue, 31 Oct 2017 23:06:18 +0530
Message-ID: <5501933ac4d2773c529357265e4b2c73@mail.gmail.com>
Subject: RE: [PATCH 1/2] scsi: megaraid: Remove redundant code in megasas_alloc_cmds
To:     Yisheng Xie <xieyisheng1@huawei.com>,
        Kashyap Desai <kashyap.desai@broadcom.com>,
        Shivasharan Srikanteshwara 
        <shivasharan.srikanteshwara@broadcom.com>, jejb@linux.vnet.ibm.com,
        martin.petersen@oracle.com
Cc:     "PDL,MEGARAIDLINUX" <megaraidlinux.pdl@broadcom.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

-----Original Message-----
From: Yisheng Xie [mailto:xieyisheng1@huawei.com]
Sent: Wednesday, October 25, 2017 3:27 PM
To: kashyap.desai@broadcom.com; sumit.saxena@broadcom.com;
shivasharan.srikanteshwara@broadcom.com; jejb@linux.vnet.ibm.com;
martin.petersen@oracle.com
Cc: megaraidlinux.pdl@broadcom.com; linux-scsi@vger.kernel.org;
linux-kernel@vger.kernel.org; Yisheng Xie
Subject: [PATCH 1/2] scsi: megaraid: Remove redundant code in
megasas_alloc_cmds

megasas_alloc_cmds is to alloc cmd_list of instance instead of fusion, and
fusion is useless in this function. Just remove it.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.c
index e518dad..0640168 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4033,9 +4033,7 @@ int megasas_alloc_cmds(struct megasas_instance
*instance)
 	int j;
 	u16 max_cmd;
 	struct megasas_cmd *cmd;
-	struct fusion_context *fusion;

-	fusion = instance->ctrl_context;
 	max_cmd = instance->max_mfi_cmds;

 	/*
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>

--
1.7.12.4

From 1582223621104278841@xxx Wed Oct 25 10:07:10 +0000 2017
X-GM-THRID: 1582223621104278841
X-Gmail-Labels: Inbox,Category Forums