Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: android: ion: remove redundant variable table
To:     Colin King <colin.king@canonical.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>,
        devel@driverdev.osuosl.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20171031140249.25280-1-colin.king@canonical.com>
From:   Laura Abbott <labbott@redhat.com>
Message-ID: <4bff9c1f-8354-9e4e-4bdd-80a90450eb7b@redhat.com>
Date:   Wed, 1 Nov 2017 16:08:44 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20171031140249.25280-1-colin.king@canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 10/31/2017 07:02 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable table is being set but is never read, it is therefore
> redundant and can be removed. Cleans up clang warning:
> 
> drivers/staging/android/ion/ion.c:112:2: warning: Value stored to 'table' is never read
> 

Acked-by: Laura Abbott <labbott@redhat.com>

> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/staging/android/ion/ion.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 93e2c90fa77d..a7d9b0e98572 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -81,7 +81,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
>  					    unsigned long flags)
>  {
>  	struct ion_buffer *buffer;
> -	struct sg_table *table;
>  	int ret;
>  
>  	buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
> @@ -109,7 +108,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
>  		goto err1;
>  	}
>  
> -	table = buffer->sg_table;
>  	buffer->dev = dev;
>  	buffer->size = len;
>  
> 


From 1582782091066053669@xxx Tue Oct 31 14:03:48 +0000 2017
X-GM-THRID: 1582782091066053669
X-Gmail-Labels: Inbox,Category Forums