Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 14 Nov 2017 14:35:24 +0100
From:   Ralf Baechle <ralf@linux-mips.org>
To:     jiaxun.yang@flygoat.com
Cc:     linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] MIPS: Loongson64: Yeeloong add platform driver
 Yeeloong is a laptop with a MIPS Loongson 2F processor, AMD CS5536 chipset,
 and KB3310B controller.
Message-ID: <20171114133524.GE13046@linux-mips.org>
References: <20171112063617.26546-1-jiaxun.yang@flygoat.com>
 <20171112063617.26546-3-jiaxun.yang@flygoat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171112063617.26546-3-jiaxun.yang@flygoat.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Nov 12, 2017 at 02:36:16PM +0800, jiaxun.yang@flygoat.com wrote:

> +     asm(".set noreorder\n");
> +     /*  input enable */
> +     outl(0x00000800, (gpio_base | 0xA0));
> +     /*  revert the input */
> +     outl(0x00000800, (gpio_base | 0xA4));
> +     /*  event-int enable */
> +     outl(0x00000800, (gpio_base | 0xB8));
> +     asm(".set reorder\n");

I forgot to comment on this .set noreorder thing.  GCC expects gas to be
in reorder mode at the end of every bit of inline assembler, so above
code is at the mercy of GCC.

Not sure what the intent was here, was it to avoid GCC from reordering
the outl() calls?  These are already marked volatlile and should not be
reordered by GCC.  .set (no)reorder on the other hand is a directive
to GAS and GCC won't be influenced at all by it.

Cheers,

  Ralf


From 1584047906521841736@xxx Tue Nov 14 13:23:24 +0000 2017
X-GM-THRID: 1583841670985932847
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread