Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <59F9A6ED.7060301@bfs.de>
Date:   Wed, 01 Nov 2017 11:50:21 +0100
From:   walter harms <wharms@bfs.de>
Reply-To: wharms@bfs.de
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11
MIME-Version: 1.0
To:     Colin King <colin.king@canonical.com>
CC:     Krzysztof Halasa <khc@pm.waw.pl>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wan: wanxl: remove redundant assignment to stat
References: <20171101084945.14653-1-colin.king@canonical.com>
In-Reply-To: <20171101084945.14653-1-colin.king@canonical.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Am 01.11.2017 09:49, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> stat set to zero and the value is never read, instead stat is
> set again in the do-loop. Hence the setting to zero is redundant
> and can be removed. Cleans up clang warning:
> 
> drivers/net/wan/wanxl.c:737:2: warning: Value stored to 'stat'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/wan/wanxl.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
> index 0c7317520ed3..d573a57bc301 100644
> --- a/drivers/net/wan/wanxl.c
> +++ b/drivers/net/wan/wanxl.c
> @@ -734,7 +734,6 @@ static int wanxl_pci_init_one(struct pci_dev *pdev,
>  		return -ENODEV;
>  	}
>  
> -	stat = 0;
>  	timeout = jiffies + 5 * HZ;
>  	do {
>  		if ((stat = readl(card->plx + PLX_MAILBOX_5)) != 0)

it is std. practice to have the pattern:
 a=b;
 if (a == c) ...
maybe that can be done also here.
 stat = readl(card->plx + PLX_MAILBOX_5);
 if ( stat != 0)

just a hint.

 re,
  wh


From 1582852998779431802@xxx Wed Nov 01 08:50:51 +0000 2017
X-GM-THRID: 1582852998779431802
X-Gmail-Labels: Inbox,Category Forums