Date: Wed, 16 Jan 2008 17:10:32 +0000
From: Christoph Hellwig <hch@infradead.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       miklos@szeredi.hu, hch@infradead.org, Bryn Reeves <breeves@redhat.com>,
       Alasdair G Kergon <agk@redhat.com>
Subject: Re: [PATCH 04/27] kill filp_open()
Message-ID: <20080116171032.GA24300@infradead.org>
References: <20071101230826.9A4F6E00@kernel> <20071101230831.904FDE9A@kernel> <20080116005200.0165dc67.akpm@linux-foundation.org> <1200503096.22674.171.camel@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1200503096.22674.171.camel@localhost>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 969
Lines: 24

On Wed, Jan 16, 2008 at 09:04:56AM -0800, Dave Hansen wrote:
> > is using filp_open() and hence doesn't work very well.
> > 
> > A shall revert dm-loop.patch and run away.
> 
> This one's pretty easy, thank goodness.  Just replace filp_open() with
> open_namei():
> 
> 	/filp_open(/open_namei(AT_FDCWD, /

But ultimatively I think we should remove this silly renaming from
the patch.  It doesn't help the goal and just created churn, so please
rename open_namei back to do_filp_open for now and put filp_open back.

> BTW, why do we need this on top of the existing loopback driver?  Can
> they really share no code?

Yeah, given how much pain loop drivers in general are I don't think it's
a good idea to add a second one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/