Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Commit fcd8843c40 breaks old compilers
To:     Trond Myklebust <trondmy@primarydata.com>,
        "Anna.Schumaker@Netapp.com" <Anna.Schumaker@Netapp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
References: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com>
 <1511026783.10238.2.camel@primarydata.com>
 <49fec52f-229a-4657-a80d-d1a40a9d38e4@oracle.com>
 <1511028750.14386.1.camel@primarydata.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <cce6f1be-0481-4ecc-85e2-a626cf381ce3@oracle.com>
Date:   Sat, 18 Nov 2017 13:32:09 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1511028750.14386.1.camel@primarydata.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/18/2017 01:12 PM, Trond Myklebust wrote:

> 
> Sigh.... OK, how about something like the following then:
> 
> { .data = { 0xff, 0xff, 0xff, 0xff, 0 }, }
> 


Yes, this does build.


diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 54fd56d..daa6085 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -71,8 +71,7 @@
  };
  const nfs4_stateid invalid_stateid = {
         {
-               .seqid = cpu_to_be32(0xffffffffU),
-               .other = { 0 },
+               .data = { 0xff, 0xff, 0xff, 0xff, 0 },
         },
         .type = NFS4_INVALID_STATEID_TYPE,
  };


-boris

From 1584466552241743672@xxx Sun Nov 19 04:17:36 +0000 2017
X-GM-THRID: 1584466461486741253
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread