Received: by 10.223.164.202 with SMTP id h10csp2361975wrb; Sat, 18 Nov 2017 20:16:09 -0800 (PST) X-Google-Smtp-Source: AGs4zMYEHr8UYElMG3E8IWbhlzcg0TNlDAxFFxVPk3HsGSfSkDzZ+V1TQnFaHR/9uViZOwu1elur X-Received: by 10.98.15.22 with SMTP id x22mr7029644pfi.13.1511064969590; Sat, 18 Nov 2017 20:16:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511064969; cv=none; d=google.com; s=arc-20160816; b=NRcAILPLeGUdpdC4c6hbfZ7XAjM4l3c0/D999HuHtu6qcu19f2y/NajMJKJFIw+h8Q p0HmNXxTSjnNOW7Qv5bLwQZIF0xI1cYN8HunOCEq7tVVcl7pCGxCtIA+ukxZ8hz/oFLF cjCQoGncwjoMw+9u/EA/9OYiu0rUkOEUTgcmSAGvMvJrHvOarHB9DVYBUGrkl5Zx3hu7 /qsHxbl4vw7q5nquokzWXl5UcbIl9X+kP2jj3jrLWPjlFYPKNhxbb+nInB/wRsjirhiG SKdYYumMVZQjFoVtWNazxoPB9h7RM4wb5qD+7pKn7YAKQh9T21169AYVYRDn4wydPoIT k5mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:date:message-id:subject:cc:to:from :arc-authentication-results; bh=kIrJO+3GEUTPquHlsh76H6vOy66GpT0QMDEV+smoKgw=; b=kqJ2YS8+rJh7qy/hfCbL4zANhbGhdKqOJBxtKckivZa8kxxbA+vHwB3ulr0whrvUTR fLyn70vGd+qc19Gi+isox3EPlJynMqREAdhmuGPueGJilYVaga7ea1HkytC56m0u6aUA PS6ZCtmvAC8K/cDYT3CkU92q97VbXe4Y/lzOf8QhllkMZPehPUKgak4T7aJAm/j5/dt6 tVSNkMc/Ob9/CrP+HPMJOKSOBZZtXzaChY3Y3KL0dw/1nqq2vAw4iJGOYnoiD1MhT6mA F1eC9hbPdqkrmNBj4xdHEf0+3MdcCsHoETcK4ZjofJlpPCzdQNY7KP8BjZIdTVmHWvg3 6hmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e13si5602461pgn.481.2017.11.18.20.15.56; Sat, 18 Nov 2017 20:16:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967397AbdKRRT5 (ORCPT + 93 others); Sat, 18 Nov 2017 12:19:57 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:26671 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967024AbdKRRTy (ORCPT ); Sat, 18 Nov 2017 12:19:54 -0500 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id vAIHJlVc019431 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Nov 2017 17:19:47 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id vAIHJkhb022319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 18 Nov 2017 17:19:46 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id vAIHJjLB016123; Sat, 18 Nov 2017 17:19:46 GMT Received: from bostrovs-us.us.oracle.com (/10.152.32.65) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 18 Nov 2017 09:19:45 -0800 From: Boris Ostrovsky To: Anna.Schumaker@Netapp.com, trond.myklebust@primarydata.com Cc: "linux-nfs@vger.kernel.org" , Linux Kernel Mailing List Subject: Commit fcd8843c40 breaks old compilers Message-ID: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com> Date: Sat, 18 Nov 2017 12:19:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older compilers which cannot process initializers for anonymous structures: +const nfs4_stateid invalid_stateid = { + { + .seqid = cpu_to_be32(0xffffffffU), + .other = { 0 }, + }, + .type = NFS4_INVALID_STATEID_TYPE, +}; /home/build/linux-linus/fs/nfs/nfs4state.c:74: error: unknown field ‘seqid’ specified in initializer /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: missing braces around initializer /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: (near initialization for ‘invalid_stateid..data’) /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: overflow in implicit constant conversion /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: unknown field ‘other’ specified in initializer /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: extra brace group at end of initializer /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: (near initialization for ‘invalid_stateid.’) /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: excess elements in union initializer /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: (near initialization for ‘invalid_stateid.’) make[4]: *** [fs/nfs/nfs4state.o] Error 1 make[3]: *** [fs/nfs] Error 2 FC-64 gcc --version gcc (GCC) 4.4.4 20100503 (Red Hat 4.4.4-2) A similar bug was fixed by e0714ec4f9efe7b86828b0dcc077fd8f5d8e5e91 but I don't think the same approach can work here. -boris From 1585316263728758008@xxx Tue Nov 28 13:23:24 +0000 2017 X-GM-THRID: 1585316263728758008 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread