Received: by 10.223.164.221 with SMTP id h29csp2234413wrb; Thu, 2 Nov 2017 07:51:46 -0700 (PDT) X-Google-Smtp-Source: ABhQp+QHEBim/D3pe0rev7M1yFZ2432omzx42qFu+HYchNeCsmyPEDcjKqeBIpRZ5Tzc1suqyhuJ X-Received: by 10.99.134.200 with SMTP id x191mr3789667pgd.86.1509634306609; Thu, 02 Nov 2017 07:51:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509634306; cv=none; d=google.com; s=arc-20160816; b=doKfmTOLXFxGFdK/3iRbo/q9QBmdl48wo0KlCFs31cJjEEiRuazVJvBhZUc/jCTZDg PGxqOEP4fzuNxCYLuAxLDBb9qUqcIvlfLG1R+sS35ZcqMVKUK9FDIfMJkibcPZhoYwYN Q9YSTVMVphU462clzNgUkwHiYuV5pZgSt1/BmMeTUWYlxAnq68Womms+62G6yfxcZOR7 e0TCYI0p8yYAGBYW1OhBVrcNa0t+LsNeWBQTNUACO8rN8bx2rYF+EpW2qct68S2VgfGU vyWVBfmVzRO/DzYXvlcBvb1GThliYmP3z8JL7WVT7GNRf6QfYthag/nfzXtQ6+f5Uvps i0ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=PqKgKzFm0uyqfHRt/PUq46mJV4zHQC2GYmC9IaJUkT4=; b=dlEpytHV+WqCF9YOdWckCQ8/Wew6EhBxMeW+whBzNC9C3ctrgR92J7YvrksZeWBS0m Gq60uqGqfIv7NgIPv2Ws8143mNoR0ULy7fjUYUxnpV0ou0zp68daZPvrRjM6OhS1yET2 cPIcL+1zQKuA0S15XCbBBUoA55bKQ0rLKmEDzpFzk1zo/5mSIa+QxbH3GVEkubRjvzbe F+w4bQX7iCndQr1WQ/iR1b3K04qyY0Yy08wzS1ncYtBEL/j5YDNIYTeJ85POWG4e90gl WG82BRLthfmCegNNGc2hQQqKEL+HVXJQP+zYJRU84Wh+JQJhAa3RoaXuC7HDQ2r368O0 rNvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4si2487841pll.684.2017.11.02.07.51.32; Thu, 02 Nov 2017 07:51:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933710AbdKBOu2 (ORCPT + 97 others); Thu, 2 Nov 2017 10:50:28 -0400 Received: from osg.samsung.com ([64.30.133.232]:54688 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933034AbdKBOu0 (ORCPT ); Thu, 2 Nov 2017 10:50:26 -0400 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 74BA915A52; Thu, 2 Nov 2017 07:50:25 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SZ18FcOodl4n; Thu, 2 Nov 2017 07:50:24 -0700 (PDT) Received: from [192.168.1.87] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) by osg.samsung.com (Postfix) with ESMTPSA id D934515A48; Thu, 2 Nov 2017 07:50:23 -0700 (PDT) Subject: Re: [lkp-robot] [android/ion] 5fb70554d6: kernel_selftests.android.make_fail To: Greg Kroah-Hartman , Pintu Kumar , Laura Abbott Cc: shuah@kernel.org, kernel test robot , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, dvhart@infradead.org, Bamvor Zhang Jian , Pintu Kumar , lkp@01.org, Shuah Khan References: <8e7d8bbb-ec51-b693-aa35-1af73c163299@redhat.com> <19d76d06-1aba-351c-9b7f-2c861828501c@redhat.com> <13c66c9d-485f-7615-7a85-47bad9af30d1@osg.samsung.com> <20171102085357.GA14531@kroah.com> From: Shuah Khan Message-ID: Date: Thu, 2 Nov 2017 08:50:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171102085357.GA14531@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2017 02:53 AM, Greg Kroah-Hartman wrote: > On Wed, Nov 01, 2017 at 04:38:02PM -0600, Shuah Khan wrote: >>> For me also, if I have to test my code outside kernel tree, I usually >>> copy ion.h header file locally and test it. >>> >>> But, still I have one question about staging tree kernel headers. >>> How the kernel headers are created in case of Android where it uses >>> the ion and other headers heavily? >>> >> >> So this is a question for Greg KH? How do we handle staging headers? > > We don't :) > > Don't work too hard, or at all, for staging headers, someone should be > working to get the code out of staging. No need to provide "full > functionality" for all of the different kselftest options for staging > code, as that's just going to be a pain. > >> We have couple of options here: >> >> - add a staging header install as part of kselftest > > No Great. > >> - add a kselftest source tar-ball utility that covers the staging header >> dependencies. > > No. > > Just don't install them, as they are not part of the normal process, > don't do anything special here please. Great. > >> I am reluctant to add a local ion.h. I would rather solve the bigger issue. >> I think this might not be the only time we will run into this type of dependency > > For any other kernel code, stuff should go into uapi headers, but > staging is "special" here, so don't worry about it. Use relative paths > and all should be fine for the limited amount of testing possible. > > I really do not like to see any staging dependancies out of > drivers/staging/ at all, as staging code should be self-contained and > could be deleted tomorrow with no other side effects at all. So maybe > there should not be any kselftests allowed for staging code... > Thanks for engaging in this discussion. My intent was to explore all the options and rule them out for staging headers and kselftest. This is the first test that tests a staging driver and has dependency on staging headers. Here is what I would propose. I am going to take this test as an individual test: - without adding it to the kselftest run. - with a local ion.h This way it is available for people that want to run it. When ion driver moves out of staging it can be added to kselftest run with proper uapi header. Pintu! I will review v5 and send you comments. I think you will need to make one change to not add ion test to selftests/Makefile. thanks, -- Shuah From 1582943929067233994@xxx Thu Nov 02 08:56:09 +0000 2017 X-GM-THRID: 1582662213253057274 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread