Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 Nov 2017 12:56:27 +0100
From:   Boris Brezillon <boris.brezillon@free-electrons.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Cihangir Akturk <cakturk@gmail.com>,
        Dave Airlie <airlied@redhat.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: use %z format string for size_t
Message-ID: <20171102125627.45a19fd7@bbrezillon>
In-Reply-To: <20171102112107.4058917-1-arnd@arndb.de>
References: <20171102112107.4058917-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Arnd,

On Thu,  2 Nov 2017 12:20:43 +0100
Arnd Bergmann <arnd@arndb.de> wrote:

> Printing a size_t variable needs to use the %z format string modifier
> rather than %l, otherwise we get this warning on 64-bit architectures:
> 
> drivers/gpu/drm/vc4/vc4_bo.c: In function 'vc4_bo_stats_debugfs':
> drivers/gpu/drm/vc4/vc4_bo.c:91:26: error: format '%d' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Werror=format=]
> 

I already sent (and applied) a fix for this bug [1].

Regards,

Boris

[1]https://patchwork.kernel.org/patch/10036075/

> Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/vc4/vc4_bo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
> index 3c3d11236910..4ae45d7dac42 100644
> --- a/drivers/gpu/drm/vc4/vc4_bo.c
> +++ b/drivers/gpu/drm/vc4/vc4_bo.c
> @@ -88,11 +88,11 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *unused)
>  
>  	mutex_lock(&vc4->purgeable.lock);
>  	if (vc4->purgeable.num)
> -		seq_printf(m, "%30s: %6dkb BOs (%d)\n", "userspace BO cache",
> +		seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "userspace BO cache",
>  			   vc4->purgeable.size / 1024, vc4->purgeable.num);
>  
>  	if (vc4->purgeable.purged_num)
> -		seq_printf(m, "%30s: %6dkb BOs (%d)\n", "total purged BO",
> +		seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "total purged BO",
>  			   vc4->purgeable.purged_size / 1024,
>  			   vc4->purgeable.purged_num);
>  	mutex_unlock(&vc4->purgeable.lock);


From 1582953191534627641@xxx Thu Nov 02 11:23:22 +0000 2017
X-GM-THRID: 1582953191534627641
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread