Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 3 Nov 2017 11:34:34 -0500
From:   "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To:     Sudeep Dutt <sudeep.dutt@intel.com>,
        Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc:     linux-kernel@vger.kernel.org,
        "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH] misc: mic: scif_nodeqp: use swap macro in scif_node_connect
Message-ID: <20171103163434.GA12906@embeddedor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Make use of the swap macro and remove unnecessary variable tmppayload.
This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/misc/mic/scif/scif_nodeqp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_nodeqp.c b/drivers/misc/mic/scif/scif_nodeqp.c
index c66ca1a..e8ce4ba 100644
--- a/drivers/misc/mic/scif/scif_nodeqp.c
+++ b/drivers/misc/mic/scif/scif_nodeqp.c
@@ -467,7 +467,6 @@ static void scif_node_connect(struct scif_dev *scifdev, int dst)
 	struct list_head *pos, *tmp;
 	struct scifmsg msg;
 	int err;
-	u64 tmppayload;
 
 	if (dst < 1 || dst > scif_info.maxid)
 		return;
@@ -524,9 +523,7 @@ static void scif_node_connect(struct scif_dev *scifdev, int dst)
 	msg.src.node = dev_i->node;
 	msg.dst.node = dev_j->node;
 
-	tmppayload = msg.payload[0];
-	msg.payload[0] = msg.payload[2];
-	msg.payload[2] = tmppayload;
+	swap(msg.payload[0], msg.payload[2]);
 	msg.payload[1] = p2p_ji->ppi_da[SCIF_PPI_MMIO];
 	msg.payload[3] = p2p_ji->ppi_len[SCIF_PPI_APER] << PAGE_SHIFT;
 
-- 
2.7.4


From 1582963461720011016@xxx Thu Nov 02 14:06:37 +0000 2017
X-GM-THRID: 1582946126030678464
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread