Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171123152227.GG8789@kernel.org>
References: <20171122182541.d25599a3eb1ada3480d142fa@arm.com> <20171123152227.GG8789@kernel.org>
From:   Stephane Eranian <eranian@google.com>
Date:   Wed, 29 Nov 2017 05:02:15 -0800
Message-ID: <CABPqkBS3CDfEvp9NK7GuvXfrU1a0BqVVVxmBaCzfXT=gNOpQcw@mail.gmail.com>
Subject: Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information
 for inlined code
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Ben Gainey <ben.gainey@arm.com>,
        Kim Phillips <kim.phillips@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Darren Hart <dvhart@infradead.org>,
        Colin Ian King <colin.king@canonical.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu:
> > From: Ben Gainey <ben.gainey@arm.com>
> > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
> >               return -1;
> >       }
> >
> > -     flen = strlen(file) + 1;
> > +     for (i = 0; i < nr_lines; ++i) {
> > +         flen += strlen(file_names[i]) + 1;
> > +     }
>
>
> Please follow the coding standard used in this file and in tools/perf,
> which is the kernel one.
>
> Thanks for providing instructions on how to reproduce the problem!
>
> Stephane, can you please Ack this?
>
Trying to test this but do not see the source code from example, yet.

>
> - Arnaldo

From 1585278490703007384@xxx Tue Nov 28 03:23:00 +0000 2017
X-GM-THRID: 1584814413904944193
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread