Received: by 10.223.164.221 with SMTP id h29csp1748691wrb; Wed, 1 Nov 2017 23:46:52 -0700 (PDT) X-Google-Smtp-Source: ABhQp+QyQACUwL5lp6Eb9un05OxLihze1iwVZFnOVYP5ALLhdtFgX7s5PFuEGdXZoJeDMS9i1aSp X-Received: by 10.99.95.139 with SMTP id t133mr2476940pgb.448.1509605211920; Wed, 01 Nov 2017 23:46:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509605211; cv=none; d=google.com; s=arc-20160816; b=Jw0XUvNFseoTrTUOh5q78j3lVvrEbv2WKb8pyStxKIbQ8paRcl6m+5Ajk1XeKEcGeO 6ol11l7YbpfRnHU8WNCaPyFg98FtFKY14RMFB3viKY9ZUkfbTM1V/RxNqLeEbTHmwXXm TdpZCVep+DDSuCP+J6/+YN/mPatJD4asWf6N2m285cMAC+eK8fYqv+T8SKLOpRDdyc6V eZXGdeD4YH5GUrPod58wxGNM0+suguo+Tf0WWgnJtQ3tHRaTDkQmeD7WcqWs7AaEzJj1 dBbTggFw77Z/tVehLJtzeZfdvv4waHXDncUY6II5p7Qjr4VcOE4NuNHQLN/zgAReaG8n 0edw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=cUz5ScC1ZrtkZTfX6Aom/56eTd3c/aB1/fTy+Dj5lKc=; b=yUouj0TSC1fh8fAxbssi4e1Ob2B1WEJWEeCWZhnvQrPLG2rEYFxdhNtWK+avrLEPQ7 vaVXgS0YhsaE/PwUxG635bQaTAVg100LTLTO8FzWs2WaL9MmizGxsUdInH5ejmtPWzIM peDZm/BYsobzH3StQB57gi7LPbn/nmijlfGz5ZaY28vb2EdcO0+R3DtLtfIEO3X5c7AQ zNIv4c4bbbIC2dy0wYw7bKOWID3QucT3CtYQs1irJrb6VppeUGSw9X9rug2e4Ns8IKkT jt6usjVlGhhIlYcOgryWo+uQkLfFx6C/s91LLHvaPLfo3Fm5Con7NnnroZAVFMEgJFnL 5eig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=FQhZHLBi; dkim=pass header.i=@codeaurora.org header.s=default header.b=evOE2rUO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x7si1390755plw.685.2017.11.01.23.46.38; Wed, 01 Nov 2017 23:46:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=FQhZHLBi; dkim=pass header.i=@codeaurora.org header.s=default header.b=evOE2rUO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbdKBGqF (ORCPT + 99 others); Thu, 2 Nov 2017 02:46:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60202 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbdKBGqC (ORCPT ); Thu, 2 Nov 2017 02:46:02 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4E1F660725; Thu, 2 Nov 2017 06:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1509605162; bh=lSGnrVJ60WCztC06DEQrHQhwMuen9+84MHqGDdnyJso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FQhZHLBi6SbZ1Sb858Vg74Da/HuHkAaIQnw3TNAI8NFSnsY4JrUAZ+9EKM75kC7j4 mpG5+SF+glX3OViuCHx70VptIse5G7zF5SYbmoHQzzCYvsoPHU/K5EBEwmFK8oW3No pou5w+yNbTHaGfIMrmQnqfQUtfuit9pgaJ0neWcs= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id AE42360725; Thu, 2 Nov 2017 06:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1509605161; bh=lSGnrVJ60WCztC06DEQrHQhwMuen9+84MHqGDdnyJso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=evOE2rUOPcIK7bKykQucPeB9uBh/mkFnAVlE2nQ4PuUpyOeFACVVUxsO2TMdanrxV ouVVF3G5XWrGg/rsHbbLAaxI9QH+LmYqFKZqQGaZMvN0OXLGq27CSddZspb7Wyu4NF w17uY52B43TD6u83jOrW1HRAbFNTsD9yG761AyMo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AE42360725 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 1 Nov 2017 23:46:01 -0700 From: Stephen Boyd To: Amit Nischal Cc: Michael Turquette , Andy Gross , David Brown , Rajendra Nayak , Odelu Kukatla , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] clk: qcom: Modify RCG shared ops to support freq_tbl without XO entry Message-ID: <20171102064601.GE30645@codeaurora.org> References: <1509434380-24372-1-git-send-email-anischal@codeaurora.org> <1509434380-24372-3-git-send-email-anischal@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509434380-24372-3-git-send-email-anischal@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31, Amit Nischal wrote: > There could be some clock sources where there is no entry corresponding > XO in their frequency table, for such sources rcg2_shared_ops would > wrongly configure the RCG registers during enable/disable, which leads > to mismatch between the hardware and software rate so modify the shared > ops to handle such cases. > > Signed-off-by: Amit Nischal The shared rcg ops were orphaned and then deleted recently. Please bring this topic back up again when you have code that uses these ops. We can bring the code back in the proper way then. Also, don't hard-code 19.2MHz into the code as the CXO frequency. We've experienced that change in the past, so hard-coding those things just doesn't work. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From 1582756787234266382@xxx Tue Oct 31 07:21:37 +0000 2017 X-GM-THRID: 1582756787234266382 X-Gmail-Labels: Inbox,Category Forums