From: Johannes Weiner <hannes@saeurebad.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: thinkpad_acpi: define _sta only when needed
References: <1200488504-6789-1-git-send-email-hannes@saeurebad.de>
	<20080116191317.GA29449@khazad-dum.debian.net>
Date: Wed, 16 Jan 2008 22:10:27 +0100
In-Reply-To: <20080116191317.GA29449@khazad-dum.debian.net> (Henrique de
	Moraes Holschuh's message of "Wed, 16 Jan 2008 17:13:17 -0200")
Message-ID: <87sl0xcw8s.fsf@saeurebad.de>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 939
Lines: 24

Hi Henrique,

Henrique de Moraes Holschuh <hmh@hmh.eng.br> writes:

> On Wed, 16 Jan 2008, Johannes Weiner wrote:
>> Define _sta() helper conditionally; also remove its prototype from
>> the internal header and also some other unneeded ones.
>> 
>> This function is only needed when the bay or the dock subdriver is
>> enabled.  Otherwise, gcc complains about an unused static function.
>
> Johannes, thanks for the patches, but NAK.  A similar group of patches that
> clean up the _sta and heander file (kills it, actually) has already been
> sent to Len Brown to be merged for 2.6.25.

Sorry, I missed to check his tree in advance.  And if the work is
already done - even better! :)

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/