Received: by 10.223.164.202 with SMTP id h10csp688844wrb; Tue, 14 Nov 2017 08:05:21 -0800 (PST) X-Google-Smtp-Source: AGs4zMbKEc654vuDZYZv49C9ZdRgCO3gu/zC47PsaYDRCY9pG/5VgYazcvIURXPmNvxazbhMl0qH X-Received: by 10.99.111.65 with SMTP id k62mr12271638pgc.56.1510675521470; Tue, 14 Nov 2017 08:05:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510675521; cv=none; d=google.com; s=arc-20160816; b=QQX/dyQrv+XJaZ6FbDokS5WKFHH/RV3ZxNVxSnCyLNuOccOjaG8Umy3mw4KHwgDTBL Rol57dROP5j3yFU89WQC1iCLY9FbEgC1Ih674kPPWBtaqs68hmEtWQy9QXZ8JLUNpc3x N2CQE6qcF+zk4lB5YJBut+GHOldCMWhulDUdxCh/Dfr47lH3JqnH/USzTB9aK0xaXH62 pe92MkoLv7pIGxWTtnxwuTLnaM7wqFZ/RMMOB8GacTseIsmzodmYna646pavinGJh1Dn 7VjVwEpxMjteToqyfrY6LY4G2MQr3+Lxmmuw8k21L/8Y4gL2r8M8jticg6GC2dzEj7WW mwHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:arc-authentication-results; bh=B24VxUtHeZNJOXr163WlN2VqIOn1p2nJV9m+hNCtsAo=; b=XKTcz7N6tDF5wULxTfECMgjDaSiwn1RJcaRu+koDIeZI0fOmE0/85Nm4eo9rbhdgwb tmHkggbbET7ysTjZ/fkiNtZH6jAmoYVdjE254hkp0elyQgsU+oUyVsK9X/VnvwdGL4W2 3f/1b/zulWqwa8ngFt5diE/CDbqMAidIn9Si1OvPEiU2wTujryVdW+bOlXJDW+wf4XBG 1srdvgPxULBYcEX3KE8pH512efHmN7HwjyOMntNFPHw7YyTL9AsZ75p1/LZhv7n5Ajrx mo1AIMsC6NCYX5NMPqAUPnxI5nGAnrRfz3fw740omNWPlZB+0T+N6Guthqalcuy8hvWE Am2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j17si15972958pgv.452.2017.11.14.08.05.09; Tue, 14 Nov 2017 08:05:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755820AbdKNP4W (ORCPT + 88 others); Tue, 14 Nov 2017 10:56:22 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:6181 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754278AbdKNP4Q (ORCPT ); Tue, 14 Nov 2017 10:56:16 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com id ; Tue, 14 Nov 2017 07:56:10 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 14 Nov 2017 07:56:16 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 14 Nov 2017 07:56:16 -0800 Received: from UKMAIL101.nvidia.com (10.26.138.13) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Tue, 14 Nov 2017 15:56:15 +0000 Received: from [10.21.132.144] (10.21.132.144) by UKMAIL101.nvidia.com (10.26.138.13) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Tue, 14 Nov 2017 15:56:11 +0000 Subject: Re: [PATCH v3] platform/chrome: Use proper protocol transfer function From: Jon Hunter To: Shawn N CC: Olof Johansson , Benson Leung , "Lee Jones" , , Doug Anderson , Brian Norris , "Brian Norris" , Gwendal Grignou , Enric Balletbo , Tomeu Vizoso , "linux-tegra@vger.kernel.org" References: <20170908205011.77986-1-briannorris@chromium.org> <02aa65e7-e967-055b-2af3-2e9b6ef77935@nvidia.com>

<20170919171401.GA10968@google.com> <20170920061317.GB13616@google.com>

Message-ID: <4cf2fa5b-f909-1ab1-f743-e1cb9a66c604@nvidia.com> Date: Tue, 14 Nov 2017 15:56:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.21.132.144] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 26/09/17 16:40, Jon Hunter wrote: > On 26/09/17 00:15, Shawn N wrote: ... >> From: Shawn Nematbakhsh >> Date: Mon, 25 Sep 2017 14:32:38 -0700 >> Subject: [PATCH] mfd: cros ec: spi: Fix "in progress" error signaling >> >> For host commands that take a long time to process, cros ec can return >> early by signaling a EC_RES_IN_PROGRESS result. The host must then poll >> status with EC_CMD_GET_COMMS_STATUS until completion of the command. >> >> None of the above applies when data link errors are encountered. When >> errors such as EC_SPI_PAST_END are encountered during command >> transmission, it usually means the command was not received by the EC. >> Treating such errors as if they were 'EC_RES_IN_PROGRESS' results is >> almost always the wrong decision, and can result in host commands >> silently being lost. >> >> Signed-off-by: Shawn Nematbakhsh >> --- >> drivers/mfd/cros_ec_spi.c | 26 ++++++++++++-------------- >> 1 file changed, 12 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c >> index c9714072e224..d33e3847e11e 100644 >> --- a/drivers/mfd/cros_ec_spi.c >> +++ b/drivers/mfd/cros_ec_spi.c >> @@ -377,6 +377,7 @@ static int cros_ec_pkt_xfer_spi(struct >> cros_ec_device *ec_dev, >> u8 *ptr; >> u8 *rx_buf; >> u8 sum; >> + u8 rx_byte; >> int ret = 0, final_ret; >> >> len = cros_ec_prepare_tx(ec_dev, ec_msg); >> @@ -421,25 +422,22 @@ static int cros_ec_pkt_xfer_spi(struct >> cros_ec_device *ec_dev, >> if (!ret) { >> /* Verify that EC can process command */ >> for (i = 0; i < len; i++) { >> - switch (rx_buf[i]) { >> - case EC_SPI_PAST_END: >> - case EC_SPI_RX_BAD_DATA: >> - case EC_SPI_NOT_READY: >> - ret = -EAGAIN; >> - ec_msg->result = EC_RES_IN_PROGRESS; >> - default: >> + rx_byte = rx_buf[i]; >> + if (rx_byte == EC_SPI_PAST_END || >> + rx_byte == EC_SPI_RX_BAD_DATA || >> + rx_byte == EC_SPI_NOT_READY) { >> + ret = -EREMOTEIO; >> break; >> } >> - if (ret) >> - break; >> } >> - if (!ret) >> - ret = cros_ec_spi_receive_packet(ec_dev, >> - ec_msg->insize + sizeof(*response)); >> - } else { >> - dev_err(ec_dev->dev, "spi transfer failed: %d\n", ret); >> } >> >> + if (!ret) >> + ret = cros_ec_spi_receive_packet(ec_dev, >> + ec_msg->insize + sizeof(*response)); >> + else >> + dev_err(ec_dev->dev, "spi transfer failed: %d\n", ret); >> + >> final_ret = terminate_request(ec_dev); >> >> spi_bus_unlock(ec_spi->spi->master); >> > > Thanks! Works for me ... > > Tested-by: Jon Hunter I can't find the formal patch you sent out for the above, but I have not seen it picked up yet. I am guess that Lee did not pick it up because there was still an open question. Anyhow we may want to circle back with Lee on this so that this does get picked up. Cheers Jon -- nvpublic From 1583517095927260753@xxx Wed Nov 08 16:46:23 +0000 2017 X-GM-THRID: 1578006392712496529 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread