Received: by 10.223.164.202 with SMTP id h10csp2352757wrb; Mon, 27 Nov 2017 16:01:57 -0800 (PST) X-Google-Smtp-Source: AGs4zMZ8ahFeMUOChCKEqrJdr/tvZgPy8oOnT2fqvwL+X8fAAyL3auHkslx1Y/M+GlBFGk97xCV8 X-Received: by 10.99.62.10 with SMTP id l10mr38104348pga.376.1511827317409; Mon, 27 Nov 2017 16:01:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511827317; cv=none; d=google.com; s=arc-20160816; b=NptusP9BGfP2VcENXFXr3sguAKcLfnXJU4+bFxiFFxEBY94S0/9kSxd/3hGD036vaZ jvnYzAwjxUs0xpHbZ50Lh0UylWNFtofcr+p7auZlpN13wPPzme0mDixrPe4WrQVuTGA1 FQi002GN8mFuJkBnDYC6H44ldnOUpNTUOiZSRhq2/9kBt+d9LCNMtxxStKWx8WqEZydz crqhhAq5x8Kprz1k7JquPKmC75W8OWaVkITOn9pynaahYkmjb8vWcCRojTE883ypBVOi 3M+iCF++zBR80CgBU34oqa4GAzNA2I89wJZEyS7sNqBywh+M87JhE+pA50bpEhYst7vx XF6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date :arc-authentication-results; bh=wPtd7mTwe7TxyYZ6dIytL+6IQK+MZObewSEwxLWpdpk=; b=FRYA4j9W5LoMub11jPOuNMeBH8dmeKhR9rl2riWMt9jFBQeXzlFisNSI0oPX+lKhhs g35KtyoO8WY7nJhBVN0TEyQ5xm5jTHhUMStszHVzb145ziUpCqLzSfMVeLSTojUW9iqM YRZmgP6ePUUA0boqVDm2/bcnMzJZDQnrSYW+6Us6yspCwRD4jC/5jox0lSFzWaScsF3B Cu5HknAEXowqAln2/sUoJTxBuiOn/10zGgBDeVTvVtCnSCUqetnQ7EERewR9OfWYap71 WknUQBTd1pX15BHWvQBZThIiKZfJ41Ce4ofdiLnn0np2QvvlxBPhiX8TuUXOVFXMDX5o hquQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7si25933979pfl.148.2017.11.27.16.01.45; Mon, 27 Nov 2017 16:01:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752734AbdK1ABL (ORCPT + 78 others); Mon, 27 Nov 2017 19:01:11 -0500 Received: from gateway34.websitewelcome.com ([192.185.149.13]:41590 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752259AbdK1ABK (ORCPT ); Mon, 27 Nov 2017 19:01:10 -0500 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway34.websitewelcome.com (Postfix) with ESMTP id DF31159ECD7 for ; Mon, 27 Nov 2017 18:01:09 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id JTKneB6lv5b6TJTKneLZKm; Mon, 27 Nov 2017 18:01:09 -0600 Received: from [189.175.122.225] (port=46518 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.89) (envelope-from ) id 1eJTKn-003mRa-GE; Mon, 27 Nov 2017 18:01:09 -0600 Date: Mon, 27 Nov 2017 18:00:59 -0600 From: "Gustavo A. R. Silva" To: Nick Terrell , Chris Mason Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Kees Cook Subject: [PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs Message-ID: <20171128000059.GA22017@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.122.225 X-Source-L: No X-Exim-ID: 1eJTKn-003mRa-GE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.175.122.225]:46518 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 3 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- lib/zstd/bitstream.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/zstd/bitstream.h b/lib/zstd/bitstream.h index a826b99..18d8200 100644 --- a/lib/zstd/bitstream.h +++ b/lib/zstd/bitstream.h @@ -259,11 +259,17 @@ ZSTD_STATIC size_t BIT_initDStream(BIT_DStream_t *bitD, const void *srcBuffer, s bitD->bitContainer = *(const BYTE *)(bitD->start); switch (srcSize) { case 7: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[6]) << (sizeof(bitD->bitContainer) * 8 - 16); + /* fall through */ case 6: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[5]) << (sizeof(bitD->bitContainer) * 8 - 24); + /* fall through */ case 5: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[4]) << (sizeof(bitD->bitContainer) * 8 - 32); + /* fall through */ case 4: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[3]) << 24; + /* fall through */ case 3: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[2]) << 16; + /* fall through */ case 2: bitD->bitContainer += (size_t)(((const BYTE *)(srcBuffer))[1]) << 8; + /* fall through */ default:; } { -- 2.7.4 From 1586595803463423286@xxx Tue Dec 12 16:21:08 +0000 2017 X-GM-THRID: 1586287052706005155 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread