Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Subject: Re: [PATCH] perf annotate: Remove precision for mnemonics
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, treeze.taeung@gmail.com,
        linux-kernel@vger.kernel.org, dstence@us.ibm.com,
        ravi.bangoria@linux.vnet.ibm.com
References: <20171114032540.4564-1-ravi.bangoria@linux.vnet.ibm.com>
 <20171114130427.GK8836@kernel.org>
Date:   Wed, 15 Nov 2017 13:41:12 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171114130427.GK8836@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Message-Id: <f807f61c-da67-14f2-a16c-d8ce6855703f@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/14/2017 06:34 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 14, 2017 at 08:55:40AM +0530, Ravi Bangoria escreveu:
>> There are many instructions, esp on powerpc, whose mnemonics are
>> longer than 6 characters. Using precision limit causes truncation
>> of such mnemonics.
>>
>> Fix this by removing precision limit. Note that, 'width' is still
>> 6, so alignment won't get affected for length <= 6.
>>
>> Before:
>>
>>     li     r11,-1
>>     xscvdp vs1,vs1
>>     add.   r10,r10,r11
>>
>> After:
>>
>>    li     r11,-1
>>    xscvdpsxds vs1,vs1
>>    add.   r10,r10,r11
> Ok, this improves the situation, as we stop truncating info, but I think
> that we should look for the longest instruction name and then use that
> to align the operands, will add that to my todo list if nobody does it
> first :-)

Hmm.. I could see longest one of 15 characters (f.e. AESKEYGENASSIST)
by a quick glance over list of instructions for x86 and powerpc. Need
to check for other archs.

> Thanks, applied.

Thanks,
Ravi


From 1584046892501930697@xxx Tue Nov 14 13:07:17 +0000 2017
X-GM-THRID: 1584010368775005113
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread