Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF28521939
MIME-Version: 1.0
In-Reply-To: <20171105124949.ct4ity6htxqgvvfp@ninjato>
References: <20171101002330.24981-1-joel@jms.id.au> <20171105124949.ct4ity6htxqgvvfp@ninjato>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 6 Nov 2017 08:19:58 -0600
Message-ID: <CAL_Jsq++8gpeJch-tTTvfKu9sFbNi1fjG5+Uxg27TPcb0Zd2Kw@mail.gmail.com>
Subject: Re: [PATCH v4] i2c: aspeed: Deassert reset in probe
To:     Wolfram Sang <wsa@the-dreams.de>
Cc:     Joel Stanley <joel@jms.id.au>,
        Brendan Higgins <brendanhiggins@google.com>,
        Philipp Zabel <philipp.zabel@gmail.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Andrew Jeffery <andrew@aj.id.au>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Nov 5, 2017 at 6:49 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> On Wed, Nov 01, 2017 at 10:53:30AM +1030, Joel Stanley wrote:
>> In order to use i2c from a cold boot, the i2c peripheral must be taken
>> out of reset. We request a shared reset controller each time a bus
>> driver is loaded, as the reset is shared between the 14 i2c buses.
>>
>> On remove the reset is asserted, which only touches the hardware once
>> the last i2c bus is removed.
>>
>> The reset is required as the I2C buses will not work without releasing
>> the reset. Previously the driver only worked with out of tree hacks
>> that released this reset before the driver was loaded. Update the
>> device tree bindings to reflect this.
>>
>> Signed-off-by: Joel Stanley <joel@jms.id.au>
>> ---
>> v4:
>>   - Make reset required and update device tree bindings
>
> For that change, I'd like to have an ack from Rob first. Won't that
> cause problems when you update only the kernel and keep the "old"
> devicetree?

Given it didn't really work as explained above, I'm okay with the change.

Acked-by: Rob Herring <robh@kernel.org>

From 1583278972683561009@xxx Mon Nov 06 01:41:31 +0000 2017
X-GM-THRID: 1582821193795495794
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread