Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171101074154.GT2283@lahna.fi.intel.com>
References: <20171031224546.46ac6eab@shemminger-XPS-13-9360> <20171101074154.GT2283@lahna.fi.intel.com>
From:   Andreas Noever <andreas.noever@gmail.com>
Date:   Mon, 6 Nov 2017 20:27:04 +0100
Message-ID: <CAMxnaaWatLR3oo4nqod2Pa7ZFH7AZHMVRLA1S0skeVfDinNUeQ@mail.gmail.com>
Subject: Re: Excessive logging in thunderbolt driver
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     Stephen Hemminger <stephen@networkplumber.org>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 1, 2017 at 8:41 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Tue, Oct 31, 2017 at 10:45:46PM +0100, Stephen Hemminger wrote:
>> The thunderbolt driver needs to stop logging.
>> All these debug messages and the laptop is on battery with no devices connected.
>> (I did use a USB key, but that is not a thunderbolt device).
>>
>> IMHO a production driver should log nothing in normal operation.
>> If you insist, the one message when device is found on discovery/probe
>> is allowed at INFO level.
>>
>> All the rest should just go away, or be turned into pr_debug().
>
> I agree and it is on my todo list for this driver.

Logging all the details was quite useful in the beginning to make the
driver work on hardware that was not available to me. But now that
thinks are mostly working I agree that we should turn the logging way
down.

From 1582848811837518358@xxx Wed Nov 01 07:44:18 +0000 2017
X-GM-THRID: 1582811248246964042
X-Gmail-Labels: Inbox,Category Forums