Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: memfd_test.c: fix compilation warning.
To:     Lei Yang <Lei.Yang@windriver.com>
References: <1509879400-26061-1-git-send-email-Lei.Yang@windriver.com>
Cc:     linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <shuahkh@osg.samsung.com>,
        Shuah Khan <shuah@kernel.org>
From:   Shuah Khan <shuahkh@osg.samsung.com>
Message-ID: <6a76f65a-a484-ba72-6cc5-85010666359c@osg.samsung.com>
Date:   Mon, 6 Nov 2017 16:46:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1509879400-26061-1-git-send-email-Lei.Yang@windriver.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/05/2017 03:56 AM, Lei Yang wrote:
> Replace '%d' by '%zu' to fix the following compilation warning.
> 
> memfd_test.c:517:3: warning: format ‘%d’ expects argument of
> type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
>    printf("malloc(%d) failed: %m\n", mfd_def_size * 8);
>    ^
> memfd_test.c: In function ‘mfd_fail_grow_write’:
> memfd_test.c:537:3: warning: format ‘%d’ expects argument
> of type ‘int’,but argument 2 has type ‘size_t’ [-Wformat=]
>    printf("malloc(%d) failed: %m\n", mfd_def_size * 8);
> 
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
>  tools/testing/selftests/memfd/memfd_test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index f94c6d1..95df9e6 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -514,7 +514,7 @@ static void mfd_assert_grow_write(int fd)
>  
>  	buf = malloc(mfd_def_size * 8);
>  	if (!buf) {
> -		printf("malloc(%d) failed: %m\n", mfd_def_size * 8);
> +		printf("malloc(%zu) failed: %m\n", mfd_def_size * 8);
>  		abort();
>  	}
>  
> @@ -534,7 +534,7 @@ static void mfd_fail_grow_write(int fd)
>  
>  	buf = malloc(mfd_def_size * 8);
>  	if (!buf) {
> -		printf("malloc(%d) failed: %m\n", mfd_def_size * 8);
> +		printf("malloc(%zu) failed: %m\n", mfd_def_size * 8);
>  		abort();
>  	}
>  
> 

Relates to gcc version perhaps. What's your gcc version?

thanks,
-- Shuah

From 1583223412588596189@xxx Sun Nov 05 10:58:25 +0000 2017
X-GM-THRID: 1583223412588596189
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread