Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next] net: dsa: lan9303: Drop port range check
To:     andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
        f.fainelli@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20171106141949.19806-1-privat@egil-hjelmeland.no>
From:   Egil Hjelmeland <privat@egil-hjelmeland.no>
Message-ID: <4d340c8e-8155-1251-3ab1-76f4948d9f1b@egil-hjelmeland.no>
Date:   Mon, 6 Nov 2017 15:39:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171106141949.19806-1-privat@egil-hjelmeland.no>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06. nov. 2017 15:19, Egil Hjelmeland wrote:
> Now that ds->num_ports is 3, there is no need to check range of "port"
> parameter.
> 
> +	lan9303_disable_processing_port(chip, port);
> +	lan9303_phy_write(ds, chip->phy_addr_sel_strap + port,
> +			  MII_BMCR, BMCR_PDOWN);
>   }

I see now that line breaking could be adjusted here. But I am going to 
touch that line in a upcomming patch about phy_addr_sel_strap. I
promise fix it then, making it to a one-liner.

>   
>   static int lan9303_port_bridge_join(struct dsa_switch *ds, int port,
> 

Egil

From 1584806846272338147@xxx Wed Nov 22 22:26:25 +0000 2017
X-GM-THRID: 1584806846272338147
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread