Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <87zi7o8x1y.fsf@anholt.net>
References: <1510275907-993-1-git-send-email-stschake@gmail.com>
 <1510275907-993-3-git-send-email-stschake@gmail.com> <87y3n9af2e.fsf@anholt.net>
 <CAOZHkRxf_puuVOoUUnbQ_mM92=pA5Mzoi4_LtJ8BKRnmau-HYg@mail.gmail.com> <87zi7o8x1y.fsf@anholt.net>
From:   Stefan Schake <stschake@gmail.com>
Date:   Wed, 15 Nov 2017 00:18:52 +0100
Message-ID: <CAOZHkRy7gJz+kuaQm35V-0Z3A5d4JoTv0r-_5Umkb5Oo4iLgag@mail.gmail.com>
Subject: Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled
To:     Eric Anholt <eric@anholt.net>
Cc:     dri-devel@lists.freedesktop.org,
        linux-rpi-kernel@lists.infradead.org,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Nov 14, 2017 at 8:44 PM, Eric Anholt <eric@anholt.net> wrote:
> Stefan Schake <stschake@gmail.com> writes:
>
>> On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt <eric@anholt.net> wrote:
>>> Stefan Schake <stschake@gmail.com> writes:
>>>
>>>> The overflow mem work callback vc4_overflow_mem_work reenables its
>>>> associated interrupt upon completion. To ensure all interrupts are disabled
>>>> when we return from vc4_irq_uninstall, we need to disable it again if
>>>> cancel_work_sync indicated pending work.
>>>
>>> Is there a reason we need the interrupts disabled at the V3D level while
>>> we have the IRQ disabled at the irqchip level?  Once we re-enable at the
>>> irqchip, we immediately V3D_WRITE(V3D_INTENA, V3D_DRIVER_IRQS) anyway.
>>
>> irqchip will mask it in the ARM interrupt controller, so we will certainly never
>> see an interrupt. I'm not sure on the exact guarantees V3D_INTENA and
>> V3D_INTCTL make - does the state in INTENA affect if V3D will signal an
>> interrupt in INTCTL? We're not currently clearing the latter in postinstall.
>
> INTENA/INTDIS writes update the state of the single register that
> controls which bits of INTCTL get ORed together to raise the interrupt
> outside the V3D block.

Then I certainly agree - this patch doesn't do anything and should be
dropped. Good call!

Thanks,
Stefan

From 1584072137623770266@xxx Tue Nov 14 19:48:32 +0000 2017
X-GM-THRID: 1583639187493170445
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread