Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 11 Nov 2017 09:14:55 +0100
From:   Ingo Molnar <mingo@kernel.org>
To:     Josef Bacik <josef@toxicpanda.com>
Cc:     rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        ast@kernel.org, kernel-team@fb.com, daniel@iogearbox.net,
        Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH 1/2] bpf: add a bpf_override_function helper
Message-ID: <20171111081455.qx4rodxldofbzypb@gmail.com>
References: <1510086523-8859-1-git-send-email-josef@toxicpanda.com>
 <1510086523-8859-2-git-send-email-josef@toxicpanda.com>
 <20171110093459.w2pvo3ntkwbmgnha@gmail.com>
 <20171110171428.hrw5cpxy4sgzf7mn@destiny>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171110171428.hrw5cpxy4sgzf7mn@destiny>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


* Josef Bacik <josef@toxicpanda.com> wrote:

> On Fri, Nov 10, 2017 at 10:34:59AM +0100, Ingo Molnar wrote:
> > 
> > * Josef Bacik <josef@toxicpanda.com> wrote:
> > 
> > > @@ -551,6 +578,10 @@ static const struct bpf_func_proto *kprobe_prog_func_proto(enum bpf_func_id func
> > >  		return &bpf_get_stackid_proto;
> > >  	case BPF_FUNC_perf_event_read_value:
> > >  		return &bpf_perf_event_read_value_proto;
> > > +	case BPF_FUNC_override_return:
> > > +		pr_warn_ratelimited("%s[%d] is installing a program with bpf_override_return helper that may cause unexpected behavior!",
> > > +				    current->comm, task_pid_nr(current));
> > > +		return &bpf_override_return_proto;
> > 
> > So if this new functionality is used we'll always print this into the syslog?
> > 
> > The warning is also a bit passive aggressive about informing the user: what 
> > unexpected behavior can happen, what is the worst case?
> > 
> 
> It's modeled after the other warnings bpf will spit out, but with this feature
> you are skipping a function and instead returning some arbitrary value, so
> anything could go wrong if you mess something up.  For instance I screwed up my
> initial test case and made every IO submitted return an error instead of just on
> the one file system I was attempting to test, so all sorts of hilarity ensued.

Ok, then for the x86 bits:

  NAK-ed-by: Ingo Molnar <mingo@kernel.org>

One of the major advantages of having an in-kernel BPF sandbox is to never crash 
the kernel - and allowing BPF programs to just randomly modify the return value of 
kernel functions sounds immensely broken to me.

(And yes, I realize that kprobes are used here as a vehicle, but the point 
remains.)

Thanks,

	Ingo

From 1583700118443169300@xxx Fri Nov 10 17:15:27 +0000 2017
X-GM-THRID: 1583463755336960738
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread