Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ARM: dma-mapping: Use vma_pages helper
To:     Vasyl Gomonovych <gomonovych@gmail.com>, linux@armlinux.org.uk,
        jroedel@suse.de, linux-arm-kernel@lists.infradead.org,
        sricharan@codeaurora.org
Cc:     linux-kernel@vger.kernel.org
References: <1511364050-912-1-git-send-email-gomonovych@gmail.com>
From:   Vladimir Murzin <vladimir.murzin@arm.com>
Message-ID: <705681db-b38d-95bd-7986-0c4bfdaf02de@arm.com>
Date:   Wed, 22 Nov 2017 15:26:40 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1511364050-912-1-git-send-email-gomonovych@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 22/11/17 15:20, Vasyl Gomonovych wrote:
> Use vma_pages function on vma object instead of explicit computation.
> arch/arm/mm/dma-mapping.c:849:36-42: WARNING: Consider using vma_pages helper on vma
> Generated by: scripts/coccinelle/api/vma_pages.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> ---
>  arch/arm/mm/dma-mapping.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index fcf1473d6fed..855427620b01 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -846,7 +846,7 @@ static int __arm_dma_mmap(struct device *dev, struct vm_area_struct *vma,
>  		 unsigned long attrs)
>  {
>  	int ret;
> -	unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> +	unsigned long nr_vma_pages = vma_pages(vma);
>  	unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT;
>  	unsigned long pfn = dma_to_pfn(dev, dma_addr);
>  	unsigned long off = vma->vm_pgoff;
> 

Colin already submitted similar patch a couple days ago [1].

[1] https://lkml.org/lkml/2017/11/19/322

Vladimir

From 1584780128559606455@xxx Wed Nov 22 15:21:45 +0000 2017
X-GM-THRID: 1584780128559606455
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread