Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2472898lqp; Sun, 24 Mar 2024 22:16:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWW9s5vKwi/7QoXllCClnhpTM2+PZPal5V3TBCaPg0ig9nqHufEA6T6qQkOMWfVEGT3PI0f+nimI+NIVccaJiNhHXO8ih4Uj59Q8je3bg== X-Google-Smtp-Source: AGHT+IEk/tToWumSBzToU01vO/L9IzonESUrOiNe+PQuq5D8n9Qv91zvevrJhPcBOOvK2k74uaA1 X-Received: by 2002:ac8:7fcc:0:b0:431:4f84:f1db with SMTP id b12-20020ac87fcc000000b004314f84f1dbmr3380808qtk.68.1711343778660; Sun, 24 Mar 2024 22:16:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711343778; cv=pass; d=google.com; s=arc-20160816; b=tdLqYjDrtBpyV3KQqfL6h0uYub1AGpSsvlEQ0IEsPYiJP/HrVyrwaumGpviA+nopGe xkK9wuqq2X4Ky2ZRRh0iln0nS8+51PbAhGj780R4j7YFHHXp7f9hYCEbd74XC+G9fbpx 9QuYy7ToFgEbP3B4ScniVLXx2hvNHfMxvG/nZWQgBByaYgmXt+Jl/9Ab70Xx/2HI0j3P c60CLek+fv+0Cu1t6rhHzwgukIXJYzgTiHoqd2/mPo1q8p6zqB3iTg8nz0QhJlwVRx+W aLq8Z1A9KXnxZt/IjHb57XfR/LRjBuyfBQALWsP5+iwwMcfnDyY5gZc7Axfe8swXWR64 liRA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=twKHJgk7rcgc6NwaSeHjQyk1OdY8yJ2L6J1Hi9cHJ1Y=; fh=KN2BaqQWDB6jIy6WiPyZrS3vumZG8uTi023BkZRKAoo=; b=v0On0C5RNB+0Qjqs1MXcEa1UxNNXJ3jB41Lo8uSFur1Q3sIEYugyFGrDTj12wDCyz2 P2EBPFrnalIElaBcGqMU1amD3I+4Sfb4HZvK1ivxvj09rdyHb+XNu9jT6Lb65IPKE2+m edF8j1+puSauUP3l99qDeIM7WWSQs/BQqsegdENwbRndRbub+BSM8DwM/wSIOYLFRJ/W yEAQP+cJb5HqqgaLmNuVvGPA19h8RX1q89I40I08dsDKoGUpt2z85ZPad6KtBZ3zwnJI tqryd/6Gem254awSuzwCUpmn+r27b+5Leo/8YlD7/Q8GAXHpGAjEI6yxnLauCg55Se1r 8gjA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hhROVB0J; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v5-20020a05622a130500b004313e08d136si4579291qtk.105.2024.03.24.22.16.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 22:16:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-113660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hhROVB0J; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113660-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113660-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 501C81C2AFAE for ; Mon, 25 Mar 2024 05:16:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 95E571D6869; Sun, 24 Mar 2024 22:52:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hhROVB0J" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FE6D1D6955; Sun, 24 Mar 2024 22:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320578; cv=none; b=o7dKFlcAKP//BeHAE9UjcO/10EFjf+JUnCxvlVIJ0dIFKeQNNkjswn3RF0mDsK5HQgbk8Awm4QtAxIwQOt1pBdgUwSd3WmGW/8ZGodIfzLs5ysKB9JI1xmzVqHE7b1KZfXxvmD+DkTJTu41qDUjOxQQex4+pLiX7a4f4LqNW6ig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320578; c=relaxed/simple; bh=HRsI8JAt342So7xUBYg8KsqVHOOsA3e9WgoFFAH9MKM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ImuuNJ5OFyWq3z5lQGY8q01jU2/yO7xkgJGJgKQwMHWdLn16qjVeCMbWZyucn9veokV0KVp3KjERhmsMlw+cbdMkupNviDSFq2VDL6+6uZOv0WvcORstmh6r5OLx+btLkdaIJq8Ixv0Dr4+aLIhnxmNO2Eg9+sCUvIEc+qkTTzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hhROVB0J; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A39E2C433C7; Sun, 24 Mar 2024 22:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320577; bh=HRsI8JAt342So7xUBYg8KsqVHOOsA3e9WgoFFAH9MKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hhROVB0J1QZqoEZvxQNuFQwfw3gyv49rXsXqhLwyNO/QAK7cmbk5zZhJHX2teaoJN vpzj0UFL8OK2Tp9jgbEkcsjgrQI3DQ21IcChlhG7esEe1W7LpVL+KLEBld1B7qcyhm fS24bRcPeAmC7ZmCasgz2FGlP1s8LFctgtbUc7eNJIk3AXsBpRrbroaFhA2S2wWU/y 9BAxEz4h+D6bclu17FfVjkvTchvJwpDTPj0sjc+QsdGaASkLGQeig7tLWfiZsFix0U 0R8za0M+Nq9nYhBcRtKxavZDvFoWGoxvOmAeP0Iy1mmz/MiQWs8g+zmYeUnYH9HnIf r91uIbXf5hDJA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Martin Kaistra , Ping-Ke Shih , Kalle Valo , Sasha Levin Subject: [PATCH 6.7 138/713] wifi: rtl8xxxu: add cancel_work_sync() for c2hcmd_work Date: Sun, 24 Mar 2024 18:37:44 -0400 Message-ID: <20240324224720.1345309-139-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Martin Kaistra [ Upstream commit 1213acb478a7181cd73eeaf00db430f1e45b1361 ] The workqueue might still be running, when the driver is stopped. To avoid a use-after-free, call cancel_work_sync() in rtl8xxxu_stop(). Fixes: e542e66b7c2e ("rtl8xxxu: add bluetooth co-existence support for single antenna") Signed-off-by: Martin Kaistra Reviewed-by: Ping-Ke Shih Signed-off-by: Kalle Valo Link: https://msgid.link/20240111163628.320697-2-martin.kaistra@linutronix.de Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 180907319e8cd..04df0f54aa667 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -7304,6 +7304,7 @@ static void rtl8xxxu_stop(struct ieee80211_hw *hw) if (priv->usb_interrupts) rtl8xxxu_write32(priv, REG_USB_HIMR, 0); + cancel_work_sync(&priv->c2hcmd_work); cancel_delayed_work_sync(&priv->ra_watchdog); rtl8xxxu_free_rx_resources(priv); -- 2.43.0