Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2474276lqp; Sun, 24 Mar 2024 22:21:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVCxzlDyzKYg7yqmR0MuELz0DcbRM+n2JDx9ErlkIFKGNoXsC7SpIOrPUYpe/V97PVylDE1w+xnOVWG0mmTX81Lgr5qnT5ZVD2l8813dw== X-Google-Smtp-Source: AGHT+IGVa9J0VYJRnEF9wYsGEaBS5AAsGC5oqP6jHlsBXuuZLtGgeAVyHikKMfY/G5ylkW21erIr X-Received: by 2002:a05:6214:1d02:b0:696:52f7:d856 with SMTP id e2-20020a0562141d0200b0069652f7d856mr7642595qvd.23.1711344117829; Sun, 24 Mar 2024 22:21:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711344117; cv=pass; d=google.com; s=arc-20160816; b=N3l7aJp8zIJbESO64DOkokZyEw/ePEfFlRNCQ+YRo3js2kCm2GBr2NMRAJtXpIXBSC UUtH9jc8sRs+FMRL2Uf4mULlLVB+a3d2XOlTvg5Aq1WxpHz/p+CEx+vVDoTwEZAJG0a6 eWIm9n+y1xWY4BNAYTzga5LW+EOHEPkHz6Jja5ta+S//8BwOGH6esWXGmMRPFSLOQheR L6o1ruo3loQVu28BDQodTnCuN+pv63eMG237r5WQ8VfQzKmNlqHBt3gy6zXba03a19lI Sy2ynn5/io/lEndyvCZpgC0DeyipTBrodFU1fmQ2muKDBnbQL3AnKfMPtRtroHcvRZ+X SBYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=VJB3pSs6ihxSjX9BcLjJScVgxfGIp888bs0/U07xQLY=; fh=DASOo9xo6NeFeQYErQVypAP4rmn+HrVeR3NPn4gxaIg=; b=BYOenPIq4nmwtn8UTJ3b5kmCOoGkVHTihP1+FKX7Dx2+8dIBtXjT+10amqgMd2d4Nr B1ZQLuxHue4gS2xbRZdWmRcvfWpUTW5SQYveGIPpyhSGbmlFkYSDcH4Jeh7GtTTE8e0U WehXSkFOuH3bEtEQn/NLaHKze+1srpDV3Koxi8lVT4+nfQD+bvFsJCaDPobd6XM85ERH 9TgWiNtQUXgzWs7eP3RFJK2pWIo/6usFsEtJQZAoy186CFJJoORiNN3cEp7sokNQsGAi o8yT6Y1hydLR4apwgrb2fcoDMv5QWBZfi3qBfRSuQYyFZZsA7XBZplvjjU4/0+ljgYLJ 12sA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nVvsha7b; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113786-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id e9-20020a0562141d0900b00690c9c22e47si7059578qvd.574.2024.03.24.22.21.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 22:21:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-113786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nVvsha7b; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113786-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113786-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 59CF01C2A129 for ; Mon, 25 Mar 2024 05:21:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 68CF814D2AB; Sun, 24 Mar 2024 23:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nVvsha7b" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 422161E4A11; Sun, 24 Mar 2024 22:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320809; cv=none; b=PGlyahLKUQY/XFYorYCbhV6+BeFjvL9guyNoqZ6HiHdGk9nN2q/XEGR9WoaHUJ9isJZCDfjnvNpUzpmjiLegzeTPEFYUeHFKB9GT0bSY3/fvsD/lGMSEcOhRVBDBLSEraTQPYGHJG4VBQagB8k/9dUc95u8futzW20bONJm1b2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320809; c=relaxed/simple; bh=cfO/pSwv8DvtXWRMznN57ZBsrXBoyZbOV1j5gmASnTI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hJNCVT0GmdSLecb+alNflvDdff+oIuRcSLCd+HpSsFA76RMJYCE6AbJWNh2ds6GxsGYAhAHmXiAeQzSL8I0/zW0g2ejXfPfOomazQr9Dw8tx5zaYe6vxtv8K+V+zrJLEI5N295z+bHSQi4ZI5SjT8gTJVmXB9H84e8KiHn7hMuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nVvsha7b; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 331EEC43143; Sun, 24 Mar 2024 22:53:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320807; bh=cfO/pSwv8DvtXWRMznN57ZBsrXBoyZbOV1j5gmASnTI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nVvsha7b+54JT/u/tHZdx0Eo2FwiSnsPMQx7ppIA9XhO56FW0WT/rYz4GwXJs2XaK Sm1KMZA8eaR8RSpbtMNZTY2SZQHjrFoSi7xNeL6+pAagEYTpyiWvQDD0/HvZvxEzUA mmSwhuvDJPH1ZWNy+4cmL1Kli5to/O+MCPPLB/qg6fwkoUsIuWdQYaEHZgNBR8vvoM g0MBiNDlaHSpVjZVgyeCFou3tpVYWZaaAID2LQ3v76pS53Yi8oBpWr+tEIePVf2HO0 BD1QBHCZQskRu+gqM8Yc6pQEBi6u5tUssgGPjq7+KStcXjOorpKNtI/1nz8vbrCWh2 o2Dm435WyEpHg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jie Wang , Jijie Shao , "David S . Miller" , Sasha Levin Subject: [PATCH 6.7 372/713] net: hns3: fix port duplex configure error in IMP reset Date: Sun, 24 Mar 2024 18:41:38 -0400 Message-ID: <20240324224720.1345309-373-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jie Wang [ Upstream commit 11d80f79dd9f871a52feba4bf24b5ac39f448eb7 ] Currently, the mac port is fixed to configured as full dplex mode in hclge_mac_init() when driver initialization or reset restore. Users may change the mode to half duplex with ethtool, so it may cause the user configuration dropped after reset. To fix it, don't change the duplex mode when resetting. Fixes: 2d03eacc0b7e ("net: hns3: Only update mac configuation when necessary") Signed-off-by: Jie Wang Signed-off-by: Jijie Shao Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index 5ea9e59569eff..609d3799d7738 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -2890,7 +2890,10 @@ static int hclge_mac_init(struct hclge_dev *hdev) int ret; hdev->support_sfp_query = true; - hdev->hw.mac.duplex = HCLGE_MAC_FULL; + + if (!test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state)) + hdev->hw.mac.duplex = HCLGE_MAC_FULL; + ret = hclge_cfg_mac_speed_dup_hw(hdev, hdev->hw.mac.speed, hdev->hw.mac.duplex, hdev->hw.mac.lane_num); if (ret) -- 2.43.0