Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2505279lqp; Mon, 25 Mar 2024 00:08:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX42jWfg606yxj9jf12y0vSjB/NEpaVUQoOi9TX4jpTobiVWuuDX58ASFaiy8EHluv2UoOdDhWe0qGw2FWchsgczDFF34AS5O7Wty0nmA== X-Google-Smtp-Source: AGHT+IEh0wgffUKIU+ZuQdpZdhaHSgEcoI/mD8R5+ECbVJa4/aIr+RlTThn47q8DHKhsoAdyjCwC X-Received: by 2002:a05:6820:3096:b0:5a5:23fb:4477 with SMTP id eu22-20020a056820309600b005a523fb4477mr6057451oob.2.1711350504049; Mon, 25 Mar 2024 00:08:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711350504; cv=pass; d=google.com; s=arc-20160816; b=F+j2MwOtY3cEr2viBxHmILHxxXDeThZA0Ba5pWBpLKhw2U3xzJNBEG2Jqbl4WE5dSS K4D9r0fbEBwb84gM54u/cH5u4LRI1R78lWp8j4WdtjyF/Fdxfz8cOTiSh5ijp5endyit D72GuojyGhbTKDyFoWUrb9OiOqtDYT6gyUeDYRl1bTpNmNUwWtxiYNkZkB+8F0JOdemy uvHrh943Ga43Ev4yBiEHSDgJrfM2mMTg8DA/ijqUYDFbolzte0481MvB5PE0MZo6VQ1l LSR98fOaI8nTZAFx1/lPqm4Ie/LTNb9/mMnaW8whKCIRlX6cDP81Nh+VOSBlsU7SiTvD y/pA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=IqruuFoxLH7WiBt72PjXkJAVMeEz7Y4q9vfW2gH+9rI=; fh=6+9f8U16DeY2SD9AQ5owd8paFMl9NCtcHFp7+/0usyI=; b=IFMcNybM7/8y/jCd353JWVayLynBg7473RPHojJ9zPp1gM3Ncsa7eATc9XRrOe6uJm xQdAnr8DlU6c+M3Va3EREX2Ua6OmIYxvhPL00piMKgYBvt102/u3gubalbWPXahkUTYt 7eoBJWPyM4S+zYEVcyjmGg78p/EQhMULPXWHdOSt4jgH4562zq9twvKgYf8n45jEk3TS 65VtfEjBAzLuZcKxc6zgVue/xNlEIUglGbU+P2Qmu0vkzeH5nOK3zwAjAXzcvZge+rmH zTm4rOvxyUsj8sZqgMUQZGiN5w07udjHIUL3ZuSSeQaOrnSf/IvWw4pb5qmXPldY4Q3I C1Aw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hABzEwcd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-114889-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-114889-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id cm11-20020a05622a250b00b004313c93978dsi4973229qtb.797.2024.03.25.00.08.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 00:08:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-114889-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hABzEwcd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-114889-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-114889-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9769E1C2DE49 for ; Mon, 25 Mar 2024 07:08:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C24E81BCFC3; Mon, 25 Mar 2024 00:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hABzEwcd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F1321788AB; Sun, 24 Mar 2024 23:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323559; cv=none; b=PhKt97dOVfig1OLvzlZEvm1pz+BbTnGJKEMqzjz+uz3itZlc6eQ7u7Ie3FoLLXQlIeHXQ3RqiK65ZVWhioTVt9qnCOQKfnBQVLU3VJ3U+jlpAW8nF1sQwU4Gn0e/wypFGgs39SwJ09chGjM89W9RWs0oeH/nSuJzH1qHwoj92s0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323559; c=relaxed/simple; bh=n/DivqH/I9rjaV+4WoG2fZKBc8VxgNOqomA49mhUcIY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qf+DAMKrzbAIFlQx6nDYD+uVebljDz3IHIEK7TWrBvxolxCBvH7BZ3T9W1kO6gny041ZGvurGrR6wmORTkxBt1g25n6/xBAcDTTEHdqRrgjMAY7Knsyf3VXpxnqw+XI0AIzaF0CG2rHbYmtv/wlJ+KsfzSTQVjEuFQ3H+hLhOTI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hABzEwcd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74EB7C433A6; Sun, 24 Mar 2024 23:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323558; bh=n/DivqH/I9rjaV+4WoG2fZKBc8VxgNOqomA49mhUcIY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hABzEwcdZRDKoFCT7+2btDOnZMg4I9B++qAUjad/M1W5bhW1skCC+pID4r4l7CU3p q9RAoMULOeK4Tzs0C8JcgAxzHB67FAp6dpce+jhoyeMl9nOAe5my3sRduBrtG5MtkF wAfSnekSpVEsHxkO0f2IG1ubUPdl5VR+EegEXW9A6VdAjRgWBF1xOFy2x0kDVn4ZLc fOHFagdrYsxMf1upwzJSGar6NG5aLDVczsMJxjgxbtdOQFQhoqk1ES6cSzyKqdPpd2 Y5ZOlP7CkU3L+9P2UDv2jDnjt86Ez+jzOrbvUtXEUJBc/pdHm2nB33PJ02rstb8lJf iAiX/vBS355IQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexey Kodanev , Jack Wang , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.15 265/317] RDMA/rtrs-clt: Check strnlen return len in sysfs mpath_policy_store() Date: Sun, 24 Mar 2024 19:34:05 -0400 Message-ID: <20240324233458.1352854-266-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324233458.1352854-1-sashal@kernel.org> References: <20240324233458.1352854-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Alexey Kodanev [ Upstream commit 7a7b7f575a25aa68ee934ee8107294487efcb3fe ] strnlen() may return 0 (e.g. for "\0\n" string), it's better to check the result of strnlen() before using 'len - 1' expression for the 'buf' array index. Detected using the static analysis tool - Svace. Fixes: dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy") Signed-off-by: Alexey Kodanev Link: https://lore.kernel.org/r/20240221113204.147478-1-aleksei.kodanev@bell-sw.com Acked-by: Jack Wang Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c index dbf9a778c3bd7..583c38eb04326 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c @@ -131,7 +131,7 @@ static ssize_t mpath_policy_store(struct device *dev, /* distinguish "mi" and "min-latency" with length */ len = strnlen(buf, NAME_MAX); - if (buf[len - 1] == '\n') + if (len && buf[len - 1] == '\n') len--; if (!strncasecmp(buf, "round-robin", 11) || -- 2.43.0