Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2506480lqp; Mon, 25 Mar 2024 00:11:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV/NEJYfzI0rp2CHXW1c6NRfyFg/zGtzWC5XIzS1y3AGc68qdGmp4oszQQtcQrDJyS9Q6n4Dw+UN3s7XrPJrqynsse/tQN/qyQKElWpnw== X-Google-Smtp-Source: AGHT+IG16lH2clr2dvA03l1VVvU3nfxkH/3y8eHxMv7DXEfEputzb42Md9RGXX+2wWpu+XKORLRE X-Received: by 2002:a05:6a20:1994:b0:1a1:8899:a2b0 with SMTP id bz20-20020a056a20199400b001a18899a2b0mr4729500pzb.52.1711350711364; Mon, 25 Mar 2024 00:11:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711350711; cv=pass; d=google.com; s=arc-20160816; b=DXXQfocttzuAcwA6sPkBt+IUMGovWDtpGiRWCA4hcGOC/+V7Hs3QLwx3o5XJAuBMfL /PvLE0Fo0TGK4HkLZPas016IAeTcM0bWyx9/AAd39nwag2H96tjOLiA66o7OAH2B+rS2 ewaCxDwQ6XBoH9+4VGPxz19BSW5mj948elPxA1dnxgR/EP0AfIHl7xGe/J9EZH4jooPV sVZU33Q6eggJChmf+SYH+9VCXB4462if1Cqh+YYqIdz1SnrBt4GIPbdlj8WkklnWVCvk O2ZiskU6OLonEfLH5NeOW/PefG/qWkim83j2cYoxUWgNJMKlA1hTpYMUk/c5ztb+NZyy LF9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ripXzeXFzxxoUdb6NVxByF7e3HcCoRx2qepN4hatYGo=; fh=Y0ThenHruESlNj7UiAnHQoxJrEVKS7eQ2jgVrS9yPfQ=; b=rM1LxCqYl40BZRWKW7KE75x4w+Bj7aWPQs3isHMLdTvGVI08fq08LHLKMRt/DcgvK5 //KRrZeuHxcKdv7dMZoTZnULYt7vp6ZARkocVoXuFQfUDSqJ7q5vfe+jjiaLWJKUMxAi Q6cDMDcMJj6fGExOwL10gfPwHEvCGEAXf2AyPtvCLuzxomXYdyyXfJYewPUgSJ3gKrrs YQFSlXBFpRg6H2CfSTzGNAVmYVNdtKyLsC/4V0CzEk63m6bSgEg4CJ8PN05P1cEQrg2k C9YTUkW/WMhA/nEJzbI0eijuhOO7DNgOXtB37Z3Hk+GB10EX1JGI5LXCXLQSVlskNv17 FOVw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f5ferkp1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-114418-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-114418-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id g1-20020aa79dc1000000b006e733588b4bsi4678917pfq.59.2024.03.25.00.11.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 00:11:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-114418-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f5ferkp1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-114418-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-114418-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9B62FB28054 for ; Mon, 25 Mar 2024 06:05:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 386A5279865; Sun, 24 Mar 2024 23:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f5ferkp1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB38915574D; Sun, 24 Mar 2024 23:10:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321833; cv=none; b=uguN1UBGcIsrghxe8/ks/cgJOmFHoSczlDRfEyYEDgTLmhD1DanN8sIMLeGoQLKqjO5ciNcKRG9As3JyEbw/v3wjnMJ+nFJmiH/01NEgB5FiQ5yKy4UiGo3GDNh0y6PBE4/j0udenDbv5jJ3l4AiVpGr9B8ht68jxH3kI73/cSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321833; c=relaxed/simple; bh=f2WAONAyaGu/mywiSi78/xx1tKvqBV4wdKArYHGhmSU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=St0ow7ZvxUXzDKjmC12/o3XPqUIe0VxuIIyDAuNzXAHEmTpgrzA7XDAcDMIpu2QZSJdC4aOI3HBYT3PA8mGpEPblJxyW6U2T0MCxBLOmvw84bUnThRcI5F4YSqPSRRnMn0wqadwYTebKxINYbudt604HN4HaphhIcmi7slAKjtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f5ferkp1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EECE1C433F1; Sun, 24 Mar 2024 23:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321832; bh=f2WAONAyaGu/mywiSi78/xx1tKvqBV4wdKArYHGhmSU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f5ferkp1P3o6f72XU/g1ZXH5d/H3I3AkDU7B9cBSfvwswxRWGNhJlZMX9JVU6+2Fd //s7VQBcIUjYb+d58nEOva0OTKRZvCDmejVYSikhYYORDmKqnH3Gq3u/2UH3xy/+bV bOePidO1ZvFPyVYaGN+72cIOgzgFhmEmdIQHmSMGo4LCT/UGpVzl0MSubdYgU62JTg YVlANU5WlXv3EcU+Z5U9Pw34xEzzA5gIP3Qmec48aMwePGNsLUcnmYHQAcj2Ptn6KC 2JwGakDzmFsYvIgRcev/ftK5UmFB151Ur9ehQO0rBV1SwPI21xCoOzp95f9fF5A6h9 +Ph+G/rcp315A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tudor Ambarus , Sam Protsenko , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 6.6 561/638] tty: serial: samsung: fix tx_empty() to return TIOCSER_TEMT Date: Sun, 24 Mar 2024 18:59:58 -0400 Message-ID: <20240324230116.1348576-562-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Tudor Ambarus [ Upstream commit 314c2b399288f0058a8c5b6683292cbde5f1531b ] The core expects for tx_empty() either TIOCSER_TEMT when the tx is empty or 0 otherwise. s3c24xx_serial_txempty_nofifo() might return 0x4, and at least uart_get_lsr_info() tries to clear exactly TIOCSER_TEMT (BIT(1)). Fix tx_empty() to return TIOCSER_TEMT. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko Link: https://lore.kernel.org/r/20240119104526.1221243-2-tudor.ambarus@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/samsung_tty.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 07fb8a9dac633..5a4d88e134715 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -990,11 +990,10 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) if ((ufstat & info->tx_fifomask) != 0 || (ufstat & info->tx_fifofull)) return 0; - - return 1; + return TIOCSER_TEMT; } - return s3c24xx_serial_txempty_nofifo(port); + return s3c24xx_serial_txempty_nofifo(port) ? TIOCSER_TEMT : 0; } /* no modem control lines */ -- 2.43.0