Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2518720lqp; Mon, 25 Mar 2024 00:50:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXniajdk1J2vSCsYu7cVPfjTZKJcI4m4kL4ZGEjn0ZnTXaYp/JtaWnEore78wibdkpq8Bu4jWFVD7AMe+xuwNjgtugd9N1Ov6zocyrUOw== X-Google-Smtp-Source: AGHT+IE0XwDyAwqS1o2OMwALhOw7qC/gWr2keWeS3rYBWswmaiqvGruPehlyP8nK1YOgOCKg1Usl X-Received: by 2002:a17:90a:4383:b0:2a0:3c2b:7f22 with SMTP id r3-20020a17090a438300b002a03c2b7f22mr4109077pjg.29.1711353002454; Mon, 25 Mar 2024 00:50:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711353002; cv=pass; d=google.com; s=arc-20160816; b=pRq6NcdmateEySeLRmX+W4dCo5pk66UHrtW5YYxwSn1fur1gXjE040oxi7Fhj+zqXz wDV1zP0gM7AGMFMbHg60ylaUFugqT5yY2W48Mn8kxASX/udVzyOSTan6vG7u2AQgI+Xy qe6emfemQX8gKoWgGjOhxhso+TqCMNdBhcbOXbMChGIzkwzS7MKl3Y576CKIiBTNkf4V 792O47Sf+Hh5mjYltTEndcKnE+hwHgpiRczL7VyKpJUoCHO9Pk8chGHKo29N/03k1zki eMiXc7djIYXyCrTUBilPfygZvy8KVXnbjYnoMlohahVmGYHGVaN3+p+13/xQRWHGFHjT 8/SA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=lUTbZFO130R9z+xDLV6c4JAICW8HPV+1TNMvp9rdznc=; fh=LnwZRgQeaUxrkw01P1WUzagoTrs/7781l6iBpdLSGMs=; b=L3rMP+sK51L4giaV3OGWwju+e3p2FC6yCEcfzHeVqQjjNAgy4ByFXIqaAGpyBzeGqH lQs4Qagndm+2pchJZG9g4RxqUIEytWnIWPmoxobNdrJ8+K2U54KqQJwHFW+uF2Pjqf25 pDvKKY9uxZBplylcln6jeEU/p+7nDyYuKB5lzxGVeqqm9vUqHcOyUSu8rPaQSYmzF+Mc X7s/hGbfg81/WbVhhF7HsHvOZ71j17twf++OGNTHwi7ro29QPGX9K4PBCet8vH/KJKRx LxQrJHUPmhM70xYONI+HXeTJ/WsdXCD5nv983wk3jLifeDQqBIqA/dJXZDnWngGPlEnH AFkQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SEKXJkz6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115556-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e11-20020a17090a9a8b00b0029e0e07d580si10973417pjp.126.2024.03.25.00.50.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 00:50:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-115556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SEKXJkz6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115556-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115556-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3CD76296D02 for ; Mon, 25 Mar 2024 07:47:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 831ED137902; Mon, 25 Mar 2024 02:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SEKXJkz6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F97314B09B; Sun, 24 Mar 2024 22:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321066; cv=none; b=aWOSkUGoxU+o7qmPfiHEkmokY1Dr3vSG5d8n8pA/YL57Xyrzh84BeBU+kjcylSBXib4fiu7yPf76xeptDg8pCShJ6ft3WtyzU5u1YaDjurEtgBgR8HKtCsmc5TvQrEGnEFrTMZe4PYINSHPka/QJwy3TtCATp30sCxwm/I9F9Pk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321066; c=relaxed/simple; bh=pRFSzQtLhCFk2XS/KpLm33y704/cqDGYsr0aJwn7PQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nj85jMsoi8s0Uer94mYV6yvHeEZDHmLakcjZJn4gdic+7Vx/YkuWHRa8CNxC49TaWy3RLmXYRY560qD0wkvS6WwhiknveVc2uEJoO2sEkmf2OifLYo8aWRq8Hy5kiDclCuyRHif1HvwqH45dFQ8WpXsACHO7psanhUf0sXgHfDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SEKXJkz6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60266C43390; Sun, 24 Mar 2024 22:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321066; bh=pRFSzQtLhCFk2XS/KpLm33y704/cqDGYsr0aJwn7PQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SEKXJkz6pUmHiX3nrW5HBp3QXuEBvw6NOYu7AV5ea/K/HIOhGbOYekjmO3in0imTt 4+LeTRypHCASI43RH4oe3BtZCrWbvWCHbAgnFRW3iY2bFkzvfmpr+S8SCuGFhMhEJK fLzNuYBM805lD+TUMti+IhV/GwQdGibW70oeoqemHvTVscWzQnNu/BFTr+c+EDyn8y W2ABM9A1AI7sOLMMGHt0nhdMg4XMqy5bVagxZ9YIKPd1dMokHtBL1U6lz0jR8CoTVr 1nN3mRauKGH2TMcBVurwtf7s69HksBVQICgkU2o8Zy2JbOkm2V1qb37O1jeik2vJ2T 5t/47gLW9IkFg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Matti Vaittinen , Subhajit Ghosh , Jonathan Cameron , Sasha Levin Subject: [PATCH 6.7 630/713] iio: gts-helper: Fix division loop Date: Sun, 24 Mar 2024 18:45:56 -0400 Message-ID: <20240324224720.1345309-631-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Matti Vaittinen [ Upstream commit bb76cc45dcdfcd962a5994b8fe19ab74fc6c3c3a ] The loop based 64bit division may run for a long time when dividend is a lot bigger than the divider. Replace the division loop by the div64_u64() which implementation may be significantly faster. Tested-by: Subhajit Ghosh Signed-off-by: Matti Vaittinen Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers") Link: https://lore.kernel.org/r/Zcn-6e-0-nh2WcfU@drtxq0yyyyyyyyyyyyyby-3.rev.dnainternet.fi Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/industrialio-gts-helper.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrialio-gts-helper.c index 7653261d2dc2b..b51eb6cb766f3 100644 --- a/drivers/iio/industrialio-gts-helper.c +++ b/drivers/iio/industrialio-gts-helper.c @@ -34,24 +34,11 @@ static int iio_gts_get_gain(const u64 max, const u64 scale) { u64 full = max; - int tmp = 1; if (scale > full || !scale) return -EINVAL; - if (U64_MAX - full < scale) { - /* Risk of overflow */ - if (full - scale < scale) - return 1; - - full -= scale; - tmp++; - } - - while (full > scale * (u64)tmp) - tmp++; - - return tmp; + return div64_u64(full, scale); } /** -- 2.43.0