Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2526496lqp; Mon, 25 Mar 2024 01:10:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUnBsawlB7Y9RHSPe12V0GD5ulvwfrWKh5Y7Esz4qNZhb8j49aR7bE10XTriPG+WZaPUYG84wS2do7l3MZdnGg2DhIr86eLIfSDMZCuZg== X-Google-Smtp-Source: AGHT+IHSuBpLw31cddWWNFKph1VS8p0VJXVsaFX+YRHCbwwK/bPzT8hcFf8qxyfRiPGgjryqTIIG X-Received: by 2002:a05:6a00:2349:b0:6ea:9223:54e7 with SMTP id j9-20020a056a00234900b006ea922354e7mr6684859pfj.32.1711354223374; Mon, 25 Mar 2024 01:10:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711354223; cv=pass; d=google.com; s=arc-20160816; b=mVL2/hs+GJHl/SeQaplJmAnebQfqETi/wW6y20SmLCGriF55a2I7kCKj0ma+cq0b9+ Oo931SHc04fYXKbCyROHVxqG02XZkqic8Hhh2f/7j5GcsLXUWqj5L1vBdy6wRyHyEpM6 TjW2RXsbh2uAPhTDRCqwfi6K0Bhv+y93zYvkbpGQfqlCiRB/2ftipQd+pse+pKkmNDQR hFK/gKNwbA0rpARhVu090uBWJgcnQ2nGBRmtW3SGiIQvJpHhtoAaZJg++OnwB1Rdwewy w66XqWq/Ys0p9/Gr4qLB8BduFNTILfC/U0VoMZephMAwbH1Ar8nz5DIoOoUq/JJjDJpS x/Qg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=YASyJLRe1lE5mSWNpqP607Oo6paOuoo7prhRVDHWCuY=; fh=cunHmaVkcaWwqL/4bGMp9q/6j6ZRrAqC7AwAV7TeES8=; b=Tvi27qMSGYJ/XGALqFAws0vgj+7ZhInpURm735DfBxyZCuW+TyknNnzbvrSVvijxcs VEmRzyBVkhBAsaOTIq+r4XEhX9DDvvzIGpJ7km2igG+h7/bJjGFH5AJNqNQ8xKMonBrO 8I7zj2VFL0Tzt1tafOLU8G7V8eJuqkizTVAsmWV7EIuiTyFfYnyBCmSGlkK9jC+1EL89 Rw+ziwQhGPK/C/n8l24nMgznHkn8b10sjVFTUZQyCBskCQ7XpLrmoJWN4fglo1FAgQLG EZqO6t4ekRIUe98nP//p5Q4PcCAHsFRxZXtpOamvvmTXAjuXkZwOB1igmJgVMo9wQYfS +SUA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jET9BDOG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115916-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115916-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g17-20020aa79dd1000000b006e69b40d4adsi4649854pfq.100.2024.03.25.01.10.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 01:10:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-115916-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jET9BDOG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115916-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115916-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D77082950C4 for ; Mon, 25 Mar 2024 08:10:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD9C438A962; Mon, 25 Mar 2024 03:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jET9BDOG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EBC11487E5; Sun, 24 Mar 2024 23:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711322113; cv=none; b=KG40Gm2La6NnDWnsN/JKfrFSs9u7RsspnDX13ats+w3uhJdYkeQNiqOXlKnfKgflhXC1GHXuXpEnoP89y9joE3Z8jc/vsDhle0XTg0lwdI7r2orykB4iPJUnFuW5/K4odLCyOb1VMuwoKItYSAPgCBhOObcvgdfzIQbubu/0Ujk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711322113; c=relaxed/simple; bh=tIcxQzNmFWHotMJD6l4C8jJZ1FEs83u8EzsH84cKWSU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nhBUFFeY7Hw5wsq0ZZ5XtCp+ERCxzAXtcuNiRWhRk9T+p4lxFX4H/0PCgle200v40kAAHLCBJZz8/5c87IFx1yoqMDZ47Vs/MeDBMpWnM5rmyhrt2Zye6aaTsFLU1luyNFCUsilSKL4nXMkTBe4FuSxq88VHzivvRzBb0AUJChM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jET9BDOG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BC84C43390; Sun, 24 Mar 2024 23:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711322112; bh=tIcxQzNmFWHotMJD6l4C8jJZ1FEs83u8EzsH84cKWSU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jET9BDOGuqMrfOpa/zEqxGPj5/vnBHm+U4OKrk70RwOaiExc/T2t6Nr8fOZ3JlnhJ jGqrgZf8gOrLW0ac9lA0hrQ7JPfSEsndBhHXDPZ56euRhjKc7qWNOsFmhEBQ5YorUV QR3oa+ym0XzL7jgbQCTB5mzgL9kGiWzpW3NYtE8nETSXdANNbe1BTV+3s9hbB0Cw9l OfYkswP/Azz/9C3n9eE9jxuHVhhI8TK8kBvpQuK0VNOQLUlIFHZvSNtQW75fNe+mX8 EFWcxYmD2tnQ9O7j2UVA7ZatFi+9bqekxyHiW26IZilknZ+PnLgH+CmjyONwpoxtI1 lxQS4aaYDrShQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Christophe JAILLET , Ulf Hansson , Sasha Levin Subject: [PATCH 6.1 187/451] mmc: wmt-sdmmc: remove an incorrect release_mem_region() call in the .remove function Date: Sun, 24 Mar 2024 19:07:43 -0400 Message-ID: <20240324231207.1351418-188-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324231207.1351418-1-sashal@kernel.org> References: <20240324231207.1351418-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Christophe JAILLET [ Upstream commit ae5004a40a262d329039b99b62bd3fe7645b66ad ] This looks strange to call release_mem_region() in a remove function without any request_mem_region() in the probe or "struct resource" somewhere. So remove the corresponding code. Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650") Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/bb0bb1ed1e18de55e8c0547625bde271e64b8c31.1708983064.git.christophe.jaillet@wanadoo.fr Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/wmt-sdmmc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 9aa3027ca25e4..f2abebb2d8574 100644 --- a/drivers/mmc/host/wmt-sdmmc.c +++ b/drivers/mmc/host/wmt-sdmmc.c @@ -886,7 +886,6 @@ static int wmt_mci_remove(struct platform_device *pdev) { struct mmc_host *mmc; struct wmt_mci_priv *priv; - struct resource *res; u32 reg_tmp; mmc = platform_get_drvdata(pdev); @@ -914,9 +913,6 @@ static int wmt_mci_remove(struct platform_device *pdev) clk_disable_unprepare(priv->clk_sdmmc); clk_put(priv->clk_sdmmc); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, resource_size(res)); - mmc_free_host(mmc); dev_info(&pdev->dev, "WMT MCI device removed\n"); -- 2.43.0