Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2528152lqp; Mon, 25 Mar 2024 01:13:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV4p6L6UPwwaYOFPOYCJgoVL0l21lRWVtRkf2MlpIkjKYFSVZd8/vcLpbHXYnRvakqqh3fId1zXxBXWkRzNeujNXcod09M4kw3tRitIiQ== X-Google-Smtp-Source: AGHT+IEJwn8Ik245hyhcatm3WuNsdrjvJyrh+uSldK4ToMFEjVPvGwXgmxjNN73u/aPDyQmklwur X-Received: by 2002:a17:902:c94e:b0:1de:e6a5:e51d with SMTP id i14-20020a170902c94e00b001dee6a5e51dmr6397968pla.16.1711354439215; Mon, 25 Mar 2024 01:13:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711354439; cv=pass; d=google.com; s=arc-20160816; b=IbojbZRkqy4F4nbHYO8iv9EMitAo3Sui9sFs75VfYMxVrXOWnSwuXna3fWx9IzAcrp RJZlXSVYvWr0lharQY9zAnsfD+vjqEv88x+V4Iq5lPwDWuSgeqXu4kt0pb/6Hwt6Op5F 3Xpi5Gbhydv7nJCMdTaVm8fLP2zI3i0f+FVLd9MPer/6oKkDom1FzmEBdVgfJWxSTh/h 7/jY6N/suFZlE1gI4b2KiX+jWwHco6iG78hPyoeE3R3Sewb4K/9IEu7EG5cZAZ6aaI3Q 3dpsVrVOJF3VpSm7NBlbY5HnkZHt0DoaXZ7Rsxg+qZz5YUUWltgMJja1mwdAEm6C+mcB EgFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=t1LSqhP4Wr5JpAma2il8XsqCksW0YCUU5C2e4dCergM=; fh=j3VVVxKI7R58MooQaNg1l9nm3oQYgj2FRPC0FAu9kqc=; b=Cvq/bgpLxh8kUXROh27VhfOiolzIH7+/BUL3kvVeaFfRPyT1NXgLaDQPX7r79Uznwd nRZa6ciPYU90ruCElgXJONfDw2hYyP03J0mhz+RfDVh70N5iXzrx1QLHvJKbb6cx/DpK rXncMV5UPX3ZK7BwL+/L27TQvQvjPl1RqUJgJkQBfD8zzmV5K8JajDa/Dfwsfn1rPxg2 AwEK4BgQSiIQ1Qq6tDjLxS0O4E/qAF/1nUrywp4okxVFXY9/eQPWUN2fjvnXFcdGWabj Eu1/sasH+yUUJ8VB3n0BKsfzuIkYAx8qwGbrWQj7paE8u/6H9+d1NYnqGX0AVLx/Ruv+ spfQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mWaIO8JO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115459-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n17-20020a170902f61100b001e012417887si4859099plg.283.2024.03.25.01.13.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 01:13:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-115459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mWaIO8JO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115459-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id F4188B34FD6 for ; Mon, 25 Mar 2024 07:42:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 519FE21C19B; Mon, 25 Mar 2024 02:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mWaIO8JO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3C211DB06C; Sun, 24 Mar 2024 22:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320847; cv=none; b=Mv9lXporJVSVbqlSR/1yD+NmLUnwACDDINfefCriOLk3vx8AyNKqWwvuLXOD2amASWVNa2MovCrBrBZoyziVowKJEH19y73gDv00prPJXMWtMYqIfum65/H3B3cxBiHX0hKoLC9Dv3FbYZpwhLY8uRGeILEb8RRiyV1/eYnkiZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320847; c=relaxed/simple; bh=100Q3DQFY0vQZd0kuvkMZF3fR4O/64ANoavsC0h6OFM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mnr1lOT8PwJmsg9NvleGYcFgV4z5wU8kLCeMl7O91YZbCfHPw8+ZW03OQwaLbdC3ZDaqxPTqT7CFICGqiz2K1okMuFdsLHZVieF03Fuaez1T3FXNWst3jw6dSOzjF/bOaYMWiAlON1vJbnjUw2fBf5b2XHAwwmafOAgkFw1q0KY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mWaIO8JO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D1E4C433F1; Sun, 24 Mar 2024 22:54:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320845; bh=100Q3DQFY0vQZd0kuvkMZF3fR4O/64ANoavsC0h6OFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mWaIO8JObm2jzaWhwPy2Wrr3gtiBuklEekncNvqOq+wLEUTpEjJzN5MSVpPIRrT6I ClH8T6xzSlpJx/aqJlqyi1a95BlccdlphlE0zF26JRUfy1hXtPuG3wTv4XYfEsuusM Uva9hv3XP7BWWCmafkyDw5F10I8kvhy7F1rboDKMqG4zr6Xr/GOGMWMS29Z1jbggCx QnsJFQMqdn9CNMOLqPJPv7hkfzZ5GOHXgIi9Q6WqXC3mxOI5OmAnq294yU0QizQQRB X0I+ZxVJUHV1KPmCzUyEzy2UhvEeHXoso/XRvpUE+ylGaimIYzXBZgO0dXDstB+EAV XxKuq5UwmSvmw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Jihong , Namhyung Kim , Sasha Levin Subject: [PATCH 6.7 411/713] perf record: Fix possible incorrect free in record__switch_output() Date: Sun, 24 Mar 2024 18:42:17 -0400 Message-ID: <20240324224720.1345309-412-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Yang Jihong [ Upstream commit aff10a165201f6f60cff225083ce301ad3f5d8f1 ] perf_data__switch() may not assign a legal value to 'new_filename'. In this case, 'new_filename' uses the on-stack value, which may cause a incorrect free and unexpected result. Fixes: 03724b2e9c45 ("perf record: Allow to limit number of reported perf.data files") Signed-off-by: Yang Jihong Acked-by: Namhyung Kim Link: https://lore.kernel.org/r/20240119040304.3708522-2-yangjihong1@huawei.com Signed-off-by: Namhyung Kim Signed-off-by: Sasha Levin --- tools/perf/builtin-record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index dcf288a4fb9a9..fa13479ed73d6 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -1818,8 +1818,8 @@ static int record__switch_output(struct record *rec, bool at_exit) { struct perf_data *data = &rec->data; + char *new_filename = NULL; int fd, err; - char *new_filename; /* Same Size: "2015122520103046"*/ char timestamp[] = "InvalidTimestamp"; -- 2.43.0