Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2528562lqp; Mon, 25 Mar 2024 01:14:54 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV4m1ns6rNiYpj5iyVSennsYidxFE/LbVP1+MOlP693ihaQCtcPPfCL3gf0C7dkfO2I9tYQvdsHsMESrq9Ieq7Mcz+18hdp8KIgDc2gbQ== X-Google-Smtp-Source: AGHT+IEFee3JtDp+hycDM6thICvcKh9DJ/txl6Ui6txM2dJymdI2BPq4n7b/i3Wpk1m8FbXuc5yF X-Received: by 2002:a05:6808:bc3:b0:3c3:d0f5:198d with SMTP id o3-20020a0568080bc300b003c3d0f5198dmr1323131oik.40.1711354494377; Mon, 25 Mar 2024 01:14:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711354494; cv=pass; d=google.com; s=arc-20160816; b=c2PcqFUniSzM6AkGwSrNJlW4yQh+Sla77lmhAjb42hzS6zLDl2p7NzCBbRSuJ1VoMz j/TK2T8fu2VD66zdnlwFL5Lmd+WA40kkN3LLva1SRGIVbAisbcPpI6CsgG5xUN4YQKRu u5xz0oRCE1vZXZHMSaTUplh5mIHUTHgnGAW8pRllcUhPfZ8Nxr74/HMBJ2dlsTfD8R23 i7fCoPutRUwbFTpwKawcFKHDkvXllx+okEpnPzM4qR9eXtddsCVdAC2SaylD2LcHurXd uy7RLEiUweKCT2cScwq24vDWHlMjhXjKy8CM8A9UoPK8xouSyZXqSISI+Y9bmsWrv47H zFLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=PHTKLGzu5p+P2PzDjSqerRIvkD6PBGu+B+Qg2Q2V1Bw=; fh=KN2BaqQWDB6jIy6WiPyZrS3vumZG8uTi023BkZRKAoo=; b=MlKwMuDMK0jZYsDurMVdR/c9wNzSSUCob60wZXEQPDAqV/fBTcx4WT5My8ZbduN9ZJ MoMm2UQl+hSqmjmiulg4KPxUlR/pnLxROVhSXBcR29nFCp6y3ENhSvZqwTp0DjIOcxLG Ek3aoXS3hL7pGiaMWNXcNssV8+AmBpEaVtm8tV9a9+CTNSXq0gOafd6Zxzpx+tiqagXE vNHmRcwTK5gcwcH9hc5wcMqyPpClBwZ+bfsFLZzLhY58JKsDhypwX2bt4zUMaxcNWoZl wauMAnqL2rf9lam/mEmTGw8i+tenSlo7T8edzCOkCWZUM5gl0KdD9BCAf1V6JL5ysXh3 9RUA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZRuh9tCw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116017-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116017-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g1-20020aa79dc1000000b006e733588b4bsi4768711pfq.59.2024.03.25.01.14.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 01:14:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-116017-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZRuh9tCw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116017-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116017-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F1896296C54 for ; Mon, 25 Mar 2024 08:14:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F0B7317D23A; Mon, 25 Mar 2024 03:27:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZRuh9tCw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B82174979; Sun, 24 Mar 2024 23:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323357; cv=none; b=u7NAhxN7Fhc3GEf1sFfiT0LAvBjWw6Q90+KOI+Y+kmhHtcYlgN3vU9ky/S6ficJKdpFLTWgQ5RRccjIEl2GYuXy8IOmTDNC2OBXMtFUmrYoTtszXNGV9CHiNXOa5ilx7WqcOiVxEmXfMe/UbLtD0vcqbmHzaZfAzEgSTqirBckY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323357; c=relaxed/simple; bh=lk9a3sR+Gf80Nc1LTDgoNyiixBCKAWQX3ANl8n28usg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YGshLRtJrXtbz11oQLc5oekvTF6/D/b79l3ButC6HYILFhymjkEt/+/CoY/kl0swjI3ZvnTagy+c1+Ak9ttPW4+id7FKfY57S3XJMbaCsN6+KKZsBp2lTAC3aL39gElskgpdhe4t5MrxWgF+2tLB2XSOqaUjdGy26dajTN/Nz1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZRuh9tCw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98A78C43394; Sun, 24 Mar 2024 23:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323357; bh=lk9a3sR+Gf80Nc1LTDgoNyiixBCKAWQX3ANl8n28usg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZRuh9tCwhWRvpVA1jNAKN8jBggeF6Kp5Npy9D6GiRiOUpvW3mhmM4qu2Lbmd7P8WS mlvJeR+c6OVadYCmiRlZkdvWutROMzTYNPvt6sYdGRSnMhcvlQVdQzncnNjd2/Lqo3 gly6/UPRioLlOHpyynFy+DsjO8tymGgTuwYR95b3uudAvG3iy55Ijhyf6TzvoNwDTx msAoFYAm2AdOUxllr4KWYVk6IbaSuv9zlWX4EmWd0VFSbTxNlgF0ygScBGBCqS4xRF zRAP8mlitK/oEgV7kE4aNou7rSOIH5tVhHfNTcfY9I+OTgIlT3Q8b2DHVD8PmGrp1a YkyLYBVBk9Wxw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Martin Kaistra , Ping-Ke Shih , Kalle Valo , Sasha Levin Subject: [PATCH 5.15 057/317] wifi: rtl8xxxu: add cancel_work_sync() for c2hcmd_work Date: Sun, 24 Mar 2024 19:30:37 -0400 Message-ID: <20240324233458.1352854-58-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324233458.1352854-1-sashal@kernel.org> References: <20240324233458.1352854-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Martin Kaistra [ Upstream commit 1213acb478a7181cd73eeaf00db430f1e45b1361 ] The workqueue might still be running, when the driver is stopped. To avoid a use-after-free, call cancel_work_sync() in rtl8xxxu_stop(). Fixes: e542e66b7c2e ("rtl8xxxu: add bluetooth co-existence support for single antenna") Signed-off-by: Martin Kaistra Reviewed-by: Ping-Ke Shih Signed-off-by: Kalle Valo Link: https://msgid.link/20240111163628.320697-2-martin.kaistra@linutronix.de Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 30d9a195c6fb5..3536b9f8470f4 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -6484,6 +6484,7 @@ static void rtl8xxxu_stop(struct ieee80211_hw *hw) if (priv->usb_interrupts) rtl8xxxu_write32(priv, REG_USB_HIMR, 0); + cancel_work_sync(&priv->c2hcmd_work); cancel_delayed_work_sync(&priv->ra_watchdog); rtl8xxxu_free_rx_resources(priv); -- 2.43.0