Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2532519lqp; Mon, 25 Mar 2024 01:24:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWJLTBGMuRKAJO7PmuoMvcaQkLLKbhFxHPKNUxI0MXLb2p7xzlwfiQ3uoG2lGVfVuTEjD5UIdCnhMNV5KsnJIYhtI73+OCV2kj38qTu/g== X-Google-Smtp-Source: AGHT+IGQ5gNjOD7RbAOtltGWoXMEm+ImidIWJFxiDHR6Jqvl1KGMOv4dIzouRi6pnqq7fh9iO4Gc X-Received: by 2002:a17:903:2c5:b0:1e0:20b4:6bc8 with SMTP id s5-20020a17090302c500b001e020b46bc8mr7049446plk.15.1711355099609; Mon, 25 Mar 2024 01:24:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711355099; cv=pass; d=google.com; s=arc-20160816; b=UzmIrenM39OXnRquTZWWkLUp0YZ3HiP9ik7lYhN2MmuluK77xk5jRhetk52GKvK7WT Z8L65Q82STolqUMUNVeiKcbSdNG20cgeTepfEtSjRIHTOI/KqLLZNk2SWESbc6XZ1+tc QI0kJOmH6zC1de0NYribrbAsyCwXdyakLRFxK/pVxc/kXDFTn3lwKZwptYf7yvcEz2Ou bOBgomTK+XeqrkxCzUqUDyu6LRRb0W20rDByW6jYRB4ZzMWZN9rO7b7EdH63oxpgfe5B KeKhIK3K5NPPXvcfHKLxhm5GhC20ywT0okkVugyoVdWd0DJwIMAdVPjLX1WvykwCFbnT Ttpw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=he0Apm5wVkIddMVWrLou3eAwB69Y9p+xnRdD6v+Q7dQ=; fh=Vd+1oi3FnsHf8WW5niBnbCcBXrr0UIgWCjmhS+9lYrw=; b=c0K9io/5c8rCDW/6P6UXTuCleUP7ulAi8glxm8vIW7ij7u1JABrDK0hUBJvBN69FT5 WM6zZWIslM4JVwehtYFJW9OeIL4KT3jAVu9XvtvRZr6RRkm4o9rpUs4YWG8L+XnbiaZL RAgJiT75tKAIndJf6qP/uD4Lz5lmCYPZkukF4s71K9c78LsB9p36vyJvS0vTPLV9jFlc LEQ9S6DnJ7lnbkeqlY1SnDSHDFWzexLGNgA7WtsQ1dueQMQdDEOGXdQh8oWYijSiLr+S YrLJFcFVVme8lsrdRsDS0yQAkgSVxKBLeg1i9YCh/H0d6Xtc8aZgiDHZ1HtiZjm14NOu dITw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I4wSxT16; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116070-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116070-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s7-20020a17090302c700b001dcbca80689si4777277plk.343.2024.03.25.01.24.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 01:24:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-116070-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I4wSxT16; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116070-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116070-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4A29A297C94 for ; Mon, 25 Mar 2024 08:24:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F22AC2863EF; Mon, 25 Mar 2024 03:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I4wSxT16" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EA2F27A827; Sun, 24 Mar 2024 23:38:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323490; cv=none; b=YqjCxdW9/uumn9iG+xrJTP9P2frOdFlMORBUA1GfmJrJaIWM1JUoOYCWRShvQqtmqfN21fcL+YX1VO12VfqLUFK4DKDrZB634ANWy3r149bE7+d9B5vWwxj9qgxtUOJEWB84qBLz3QqzSY+vnApv3co4JxrrsZ+JNytRNs10r6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323490; c=relaxed/simple; bh=T9fqgdc0Zuf66eYIIK+NU8AboiJdLsdVvvdMTpz4FUY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l6knr57Q+2ldJYRe0sLAWuO8dZyEzjSg0f4J4r+7mYf3nErLJfdw9F+K14KWocnnvOCyRGIXw/eoDyanAPBsP+X3QNoShl/UC6xKVSJOfyLh5W3B1Zrsd1ubKkpuk6sSDCZtRSAUX7gOBdNtvn8eicxry1V0FrMzKBCtcshqKTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=I4wSxT16; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4938AC433A6; Sun, 24 Mar 2024 23:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323489; bh=T9fqgdc0Zuf66eYIIK+NU8AboiJdLsdVvvdMTpz4FUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I4wSxT16NbDAyR0dKTR5cO0R6eTVJYkHJ4uzlZQHS7i50kYBHVs+DSWMKNgpOzZlO SdgNTx+yUI2JzWJnrwOUj4PgeC2Sng8ObiDTt9shbXpvdukb16sTc3z3Hh/UxR652i R3XSZIH4guxbxvcJoWB4DT6r8Z9NGe0nqo6pzQAbG+xl4rEXQUsR9xLAw71lR1miXQ +kpSREh4ODnz6W9QMQWD1K4sHVLEDEiWrONvcFfqoelL3kqsh459aTnTfxOe2Y3FI5 B03hNM0HxyFnU/bi4eGb8Go+LmBjwbbFlH9wQuYr3Xo23dBPUDcd2kDknwl1qy80gM o/UQz2xaZRbTg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Quanyang Wang , Herbert Xu , Sasha Levin Subject: [PATCH 5.15 195/317] crypto: xilinx - call finalize with bh disabled Date: Sun, 24 Mar 2024 19:32:55 -0400 Message-ID: <20240324233458.1352854-196-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324233458.1352854-1-sashal@kernel.org> References: <20240324233458.1352854-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Quanyang Wang [ Upstream commit a853450bf4c752e664abab0b2fad395b7ad7701c ] When calling crypto_finalize_request, BH should be disabled to avoid triggering the following calltrace: ------------[ cut here ]------------ WARNING: CPU: 2 PID: 74 at crypto/crypto_engine.c:58 crypto_finalize_request+0xa0/0x118 Modules linked in: cryptodev(O) CPU: 2 PID: 74 Comm: firmware:zynqmp Tainted: G O 6.8.0-rc1-yocto-standard #323 Hardware name: ZynqMP ZCU102 Rev1.0 (DT) pstate: 40000005 (nZcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : crypto_finalize_request+0xa0/0x118 lr : crypto_finalize_request+0x104/0x118 sp : ffffffc085353ce0 x29: ffffffc085353ce0 x28: 0000000000000000 x27: ffffff8808ea8688 x26: ffffffc081715038 x25: 0000000000000000 x24: ffffff880100db00 x23: ffffff880100da80 x22: 0000000000000000 x21: 0000000000000000 x20: ffffff8805b14000 x19: ffffff880100da80 x18: 0000000000010450 x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 x14: 0000000000000003 x13: 0000000000000000 x12: ffffff880100dad0 x11: 0000000000000000 x10: ffffffc0832dcd08 x9 : ffffffc0812416d8 x8 : 00000000000001f4 x7 : ffffffc0830d2830 x6 : 0000000000000001 x5 : ffffffc082091000 x4 : ffffffc082091658 x3 : 0000000000000000 x2 : ffffffc7f9653000 x1 : 0000000000000000 x0 : ffffff8802d20000 Call trace: crypto_finalize_request+0xa0/0x118 crypto_finalize_aead_request+0x18/0x30 zynqmp_handle_aes_req+0xcc/0x388 crypto_pump_work+0x168/0x2d8 kthread_worker_fn+0xfc/0x3a0 kthread+0x118/0x138 ret_from_fork+0x10/0x20 irq event stamp: 40 hardirqs last enabled at (39): [] _raw_spin_unlock_irqrestore+0x70/0xb0 hardirqs last disabled at (40): [] el1_dbg+0x28/0x90 softirqs last enabled at (36): [] kernel_neon_begin+0x8c/0xf0 softirqs last disabled at (34): [] kernel_neon_begin+0x60/0xf0 ---[ end trace 0000000000000000 ]--- Fixes: 4d96f7d48131 ("crypto: xilinx - Add Xilinx AES driver") Signed-off-by: Quanyang Wang Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/xilinx/zynqmp-aes-gcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/xilinx/zynqmp-aes-gcm.c b/drivers/crypto/xilinx/zynqmp-aes-gcm.c index bf1f421e05f25..74bd3eb63734d 100644 --- a/drivers/crypto/xilinx/zynqmp-aes-gcm.c +++ b/drivers/crypto/xilinx/zynqmp-aes-gcm.c @@ -231,7 +231,10 @@ static int zynqmp_handle_aes_req(struct crypto_engine *engine, err = zynqmp_aes_aead_cipher(areq); } + local_bh_disable(); crypto_finalize_aead_request(engine, areq, err); + local_bh_enable(); + return 0; } -- 2.43.0