Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2539492lqp; Mon, 25 Mar 2024 01:44:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWOzjS8f1G6mBM5s9Na8/B+Cpl8m9WAJIKH6fJOuOtP45LCUOGKFXdMrJcqrgRWT6nKuAUpB5H3U6x7yp26Pvcx0Tpfw7O1BCZuezfQ2A== X-Google-Smtp-Source: AGHT+IEFaIOVb6sdsJqH/8USza06SmscnKNhaMcJqNgkqtaApfQzZYuZPW+VX7Tbjc/54Vhh2nKw X-Received: by 2002:a50:d602:0:b0:56b:d212:b032 with SMTP id x2-20020a50d602000000b0056bd212b032mr4439518edi.14.1711356246768; Mon, 25 Mar 2024 01:44:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711356246; cv=pass; d=google.com; s=arc-20160816; b=pdulFs6bkGujGuVXHyLWaGkXk0NdteanesJOslYkcNb9S5HVZWj4aZ1yfUdI38qfql Qb/TfVpxyvsefwN1BmBvCIXcHLl58CPjsnA3TbAU3VX9nfIQKJ5JJ/H3EJar0Fxt7lrE /UDGYX5i/JQwighTqhTy+iiU+gW2r6joWFc2w9Cp7AQ1KM2xUugavan+BFC8gqXre3lP bsKIAqrd4oce4g1R+NclSyTBmjOy33bxNTakGOILkFAZ0UHLmx77q+xR9BWb6EZ/Ffzz rTXibM00jAmj37ms3o6dwZRYghP64JE//awTLH638IoD/IxfS9nKx5cl725Vg08UVMvs BlOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=eUJV7OTBNspJrIJKs7at2dC8AqpzaHGAT9lryRgYtzk=; fh=nKgd+jbVosSTACOmmDT2sevb8e4t6vYwJGua3LmOmtg=; b=HAAs6SRArmAIV0hcjUKJ1pyxRaBllioINYsrqorFVS3erPrq+oAX/mETjY8/OCYq8O 6kk5dxMNG7czlqoKuiFVAkQv/a9/gQT7WHDZzTSGGwU1SUjHwAgaNyrDE6t20djeSwLa Y3O5WVUTqr4kc6DzpZPu7ahcBwIqChoDviqWpnDKllKaxICMbgXKby2QLMXf62zAhTqU h24SwbQjcjmxvCKXHk7jDOmBC3U+qY4uKYJoPLDtey/koYhvTq6h+RPiQUwPVXd0L6H4 ahPQlycG3m+AwBXMNumIgi64A4IfULYbMgPIjEyG4uMqsyUuFulaMKT66+JXVG9y+yOG pUew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nMqX1Vz+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116329-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d5-20020a50cd45000000b0056bb595c196si2411924edj.457.2024.03.25.01.44.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 01:44:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-116329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nMqX1Vz+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116329-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 73FF91F308A9 for ; Mon, 25 Mar 2024 08:44:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8834B29BAEA; Mon, 25 Mar 2024 03:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nMqX1Vz+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BFE313280B; Sun, 24 Mar 2024 23:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324310; cv=none; b=hi/D5U+gEKwg1Qspr24idqLuBXE2sUNsX+T84Jix01sahGYqAUWBORzM9a+O1IduJxyiEc6McXT+1oK+qsqH883Md9OIODy/W26u7xB7PeT8ngvDntHToJyMcS/5Yuvb0++2VuHslzmlZZ0g+3Kax0v86nkxtCwXsqw7qaRqG5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711324310; c=relaxed/simple; bh=E3ev4s0/MWK6GrCYFP2vej+WNCRhvaN5iAa8vNsJbHU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V6khlqh9iWJbzLZS1/I3XLqpeqiQzE208WCo4dA5UjwMf/QSDZnCUhcmO1RVpdKBUe5EeAF/xKduFZPAvzzybVhahRkkm0eD8LiXbxJCvhj8QFJ5UzVAhL/2sKnk5DVKszTVnol8b52sIaMP/sNOCAd5Kx4BKLpppf3NjeEBaIs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nMqX1Vz+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C39EC43399; Sun, 24 Mar 2024 23:51:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711324310; bh=E3ev4s0/MWK6GrCYFP2vej+WNCRhvaN5iAa8vNsJbHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nMqX1Vz+xQtUaYwh4PadyzErvDFF60iTgL18lEd28FWyR+04ABCeb6Qv/pu8QW2N2 6QIWisSyyrJBgVfDkvPlOkeY6cxO+nkRggbS8Tu+sGfVWnWdXLh8m8jC8HMpAhbQUf IMqsqwwNpxoho8KHo1xGD6/JRnvM/ltnxcRnHCiUK6JeoN4jNinDgT+QzrMWhKBwOd UY8mDNykoAjmRn0FaiQRE0zu74kFM0EmIfnPOuvjYgVEsWJPKLs0FPGbb2fqezadKY SrOxn8cCj/ECcA2HLuOi8CF+DFSZy/3j29lFjDjgyTZ91g2/hE9XU5WnyfpQEr/jk6 2g5dbMBw0uIoA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mauro Carvalho Chehab , Hans Verkuil , Sasha Levin Subject: [PATCH 4.19 082/148] media: dvbdev: remove double-unlock Date: Sun, 24 Mar 2024 19:49:06 -0400 Message-ID: <20240324235012.1356413-83-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324235012.1356413-1-sashal@kernel.org> References: <20240324235012.1356413-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Mauro Carvalho Chehab [ Upstream commit 122d0e8dd050cc5dc3fb9e9b5f2dee3c5276ce35 ] As warned by smatch: drivers/media/dvb-core/dvbdev.c: drivers/media/dvb-core/dvbdev.c:529 dvb_register_device() error: double unlock 'sem:&minor_rwsem' Reported-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Stable-dep-of: 8c64f4cdf4e6 ("media: edia: dvbdev: fix a use-after-free") Signed-off-by: Sasha Levin --- drivers/media/dvb-core/dvbdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c index b8335ede66264..1f80c4fa31c9b 100644 --- a/drivers/media/dvb-core/dvbdev.c +++ b/drivers/media/dvb-core/dvbdev.c @@ -536,7 +536,6 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, dvb_media_device_free(dvbdev); kfree(dvbdevfops); kfree(dvbdev); - up_write(&minor_rwsem); mutex_unlock(&dvbdev_register_lock); return ret; } -- 2.43.0