Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2570364lqp; Mon, 25 Mar 2024 03:02:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUvef1ZoNURgVa4l1oN9Zwp3ViA1zn5Dy7YfuVQ8OLe1wY66b0+Gffq9wdbm3wTAbh8vt2vRLXSYeW2dXoxf/MLG5VBNPq+PjxkaLWEYg== X-Google-Smtp-Source: AGHT+IEjf510DOWwx6HFafqhXP6a208w2xC2q0VZyd0pjE5oV0dJYQ9Oexd+Cjc1/dL9baW2GD0X X-Received: by 2002:a05:622a:346:b0:431:510f:f37b with SMTP id r6-20020a05622a034600b00431510ff37bmr4202080qtw.27.1711360947199; Mon, 25 Mar 2024 03:02:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711360947; cv=pass; d=google.com; s=arc-20160816; b=T4CraizPGPsNEKApOAppBanpy78Fgpy17zb3N7U++ATsWd1VxcPn4dC+38OJq0U0Ad OyV/i5fchvKUXxI6uC2PSrziGVKrkgl/71Um0uakhiUCVRk1xXJ9M77jODClnH7EHRtI 5n71/E+kRUAhfTzxOdtUmlSLCpEL8dHlG5NRT+dDmWTTaLv0WO/TS9u5A6gSWP6VJRxV ubbpgi/bOH+EFXkJC8JmObhC0OyK1jatuzzO86FNFpqPek/NBXjeioRN+SE1IMwiEF0P +G3Q0wBEJmtS9PYZsoDJATY8LbwEhu0xDnbU7Y7K+pdOkw8tobUaoV14zMwXCt80R/FU uDoA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Yvmbd8qPIiEGXQ5PGLVykTor4HE+r0/2jHMZoch2jtQ=; fh=BV5nIM+fRH+C6OnOVxOkDjjtuSYDDVgY4OJrj6N2OIw=; b=QEPkp6oldf089HsItRUmi3iR+krdimeHgACBrfucTjnYClIucENUeIgFdrYakeaawt gaqnTD4e8KbvXQ5364/63X1nwl+VIc+6kg4546p7IojLQ/V+DwkbXAXq27cIB8sBL/bF W8q9/4wKQe38Y7v6eVWefBZp6VrPcxoOI6M1BRmeS79Yt6UcjLCfo+13rTE8qJBikydC 2ljdiQj+i7A+oMxjyDi7w1uRXLa9fGNkI7A5kQPvnH7twgsOZ7pz7CW9gyiENFyru/mW bATjAPBhdeHydJ5h7ZSEYu5zzNMzMwyGGmvJUlAOOrB8LCGTHBe3BHXpibXAx582RqK4 Spqg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BY8zURmD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116077-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116077-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v6-20020a05622a130600b00431617f78bfsi366807qtk.774.2024.03.25.03.02.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 03:02:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-116077-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BY8zURmD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116077-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116077-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E691F1C30313 for ; Mon, 25 Mar 2024 10:02:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F420128CE55; Mon, 25 Mar 2024 03:29:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BY8zURmD" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C387227B110; Sun, 24 Mar 2024 23:38:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323505; cv=none; b=TaH1OFg/X8N1M0M5XexKqX71598mlIFpfjlNCj0E+g+Lo49obOA9IW/QnFddsbmSpmO/4N+rAYa6IdhiQ2C7k8LfdC9xkDRgv6PfyXL4wPcvozxTgsUkZPGjKiI20zyIizA78AkjXbtWbwS5NIWEEhspdTq7S/rqYdZCMVxv34s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323505; c=relaxed/simple; bh=1+J6QYKpPbWfELo6BtEJ8dydpL7F24zkrHNhJf6zRe4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tEYn+PBjlUoANPhgz4sf0Q3CuAQdwQzcYDVlPqOkZyDDdEtbDnIOUj7CddMa7mF1qEn93MLX9UcnwJvn3WknvrZrdGJ9clXNu7JEweAwSGwzWHKXBN8VHX1A0sFkrqoysSXPz2Nc447a26kqhX7CRLo47W9cX0xNdWiWU+azHoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BY8zURmD; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFD74C43390; Sun, 24 Mar 2024 23:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323504; bh=1+J6QYKpPbWfELo6BtEJ8dydpL7F24zkrHNhJf6zRe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BY8zURmDLrwG6z/8T2UqKYgiXoGLAhpEOyRYhfg4WF+x/VjdlpUOIsO9xyMyLul1j gZCDFFsr9LfdSXfXd9oRJPe5bdgvt7zkbU3ngrPj0aoVqZKCfn95Pp3XrY6T29pqcJ nIFrDCYx0W+Wo7ZRgDoA0TS6l79LhDjab/aMleeUAn0XXwVHP3IdD4tvelDXZEz+R7 oE09QUYJlNAX0afIZ/yZBdOUwnoV7TxeYMR/tV5M1KbmAdA2MRLKZjk4VfiKuK/Ws4 H7YN03zBvN97111saywJ/xRKfArN6ouzIb/MVNKgM09uRMluJU3QfesuYmQdmXHdxq tGqtmMYHHyMqw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lucas Stach , Philipp Zabel , Hans Verkuil , Sasha Levin Subject: [PATCH 5.15 210/317] media: imx: csc/scaler: fix v4l2_ctrl_handler memory leak Date: Sun, 24 Mar 2024 19:33:10 -0400 Message-ID: <20240324233458.1352854-211-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324233458.1352854-1-sashal@kernel.org> References: <20240324233458.1352854-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Lucas Stach [ Upstream commit 4797a3dd46f220e6d83daf54d70c5b33db6deb01 ] Free the memory allocated in v4l2_ctrl_handler_init on release. Fixes: a8ef0488cc59 ("media: imx: add csc/scaler mem2mem device") Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/staging/media/imx/imx-media-csc-scaler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/imx/imx-media-csc-scaler.c b/drivers/staging/media/imx/imx-media-csc-scaler.c index eb6da9b9d8ba8..c29a950639e46 100644 --- a/drivers/staging/media/imx/imx-media-csc-scaler.c +++ b/drivers/staging/media/imx/imx-media-csc-scaler.c @@ -803,6 +803,7 @@ static int ipu_csc_scaler_release(struct file *file) dev_dbg(priv->dev, "Releasing instance %p\n", ctx); + v4l2_ctrl_handler_free(&ctx->ctrl_hdlr); v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); v4l2_fh_del(&ctx->fh); v4l2_fh_exit(&ctx->fh); -- 2.43.0