Received-SPF: pass (google.com: domain of linux-kernel+bounces-116375-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Subject: Re: [PATCH] ubifs: xattr: remove unused anonymous enum
To: <pascal.eberhard@se.com>, Richard Weinberger <richard@nod.at>
CC: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20240324004134.161755-1-pascal.eberhard@verified.se.com>
From: Zhihao Cheng <chengzhihao1@huawei.com>
Message-ID: <7030eaa5-73b5-7aa3-3b7d-56a3519878b3@huawei.com>
Date: Mon, 25 Mar 2024 09:44:39 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240324004134.161755-1-pascal.eberhard@verified.se.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit

?? 2024/3/24 8:41, pascal.eberhard@verified.se.com д??:
> From: Pascal Eberhard <pascal.eberhard@se.com>
> 
> commit 2b88fc21cae9 ("ubifs: Switch to generic xattr handlers") removes
> usage of this anonymous enum. Delete the enum as well.
> 
> Signed-off-by: Pascal Eberhard <pascal.eberhard@se.com>
> ---
>   fs/ubifs/xattr.c | 13 -------------
>   1 file changed, 13 deletions(-)

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> 
> diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c
> index 0847db521984..f0969519ad05 100644
> --- a/fs/ubifs/xattr.c
> +++ b/fs/ubifs/xattr.c
> @@ -48,19 +48,6 @@
>   #include <linux/slab.h>
>   #include <linux/xattr.h>
>   
> -/*
> - * Extended attribute type constants.
> - *
> - * USER_XATTR: user extended attribute ("user.*")
> - * TRUSTED_XATTR: trusted extended attribute ("trusted.*)
> - * SECURITY_XATTR: security extended attribute ("security.*")
> - */
> -enum {
> -	USER_XATTR,
> -	TRUSTED_XATTR,
> -	SECURITY_XATTR,
> -};
> -
>   static const struct inode_operations empty_iops;
>   static const struct file_operations empty_fops;
>   
>