Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2577074lqp; Mon, 25 Mar 2024 03:16:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX/e9aCbjrhu8FDqc9MxA2LcVtAFPlDpSuK/aAOgoAkPifJGJQztASjqmC4o26IjhVkjzXl1AyK4Gk7lEdAgc37S5xsotwAOQ6ObINkYg== X-Google-Smtp-Source: AGHT+IEu1LH1O+gkrkC/t5XX7/OXzkK0iL2wdP0jCmYCU2zZ9GGlhy2YYTcXX/NHA36l6QFDX7Js X-Received: by 2002:a05:6a00:138a:b0:6e7:3217:efcc with SMTP id t10-20020a056a00138a00b006e73217efccmr9934159pfg.5.1711361804571; Mon, 25 Mar 2024 03:16:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711361804; cv=pass; d=google.com; s=arc-20160816; b=Y1C6zqxBbl4oUpCjwh3wS+x6HlC+4hZbZDWucHl0WlzLjIdVumyqVlcLF2w4hLvnY9 KUhVyCpRRGxbfJ9/BrYAGh3CcBYGIcNdFga2FfkxCQXodmwqUFCufhkhMETz5SvyqvF0 BM4ti+lLIgJdRQklUnQAyMD79371noPjFWZSOlQhkqeuCQCN0XGMRjHx2kd54vPkpH6d 44nlVmUagS7ZsZjx2nrUB5OMtMGaQQSYHi5G4mtYKgMF0ith+n3p6oCdEmqqTXykwrm0 p3SIpphAOx2TJshVq9EdL3CF03tB674qk1ORUEyZEzs5nizoRKTrm6oG6zPQCVeqeXQ+ JTqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=95Kd0YKXZuUOhWKagErY2xUKUKeiKVWVUmYv/HuzXsY=; fh=Y0ThenHruESlNj7UiAnHQoxJrEVKS7eQ2jgVrS9yPfQ=; b=tw7GPxTMhUHXmqT3JS51l9dWM0hbi3AQlyCvnCZl5awZr2/iC4R+8tOlmF1Sk2FCa4 x5234g+oyrcXtlx2wgJtoARzUnc5Yga9geLjfzglMbIE/BttTwZwb7VIRUDGlJ4SrQGc X3BPXrpmLNueXpuDLCZC/0vlHHuOW5lXy4Bx0mHXRv7ZB+FVZd9WK++Qo/kB8SGq5Iyi 3zqpNbzxr2Ap5zOpxULsIwsfQg9Dy8h/Fy2SZCctnpZOW5yO14WMk5cwTOvELAlU67O7 QQry32TcFNRA+g+Vaw63llVobvi7bIcApGlieOMnv+QU8sJpwALAkkr6d/efuaAo1NUF Q4oQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fMyUXeSh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116097-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116097-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t30-20020a056a00139e00b006e6b45debe9si5028094pfg.105.2024.03.25.03.16.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 03:16:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-116097-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fMyUXeSh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-116097-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116097-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 417F72A734A for ; Mon, 25 Mar 2024 10:06:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3F72F28D986; Mon, 25 Mar 2024 03:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fMyUXeSh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74EA227DE0F; Sun, 24 Mar 2024 23:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323574; cv=none; b=qMFF2lEFwsDAgEtje7JjiTndhsiphW3Cknsq4GHBq/gF2LHvYiGsu+SWMd+b4EZ5XLEoCaDBZZDnHdelhvQ0sgtOjThQBGUmRSoxhqioKh07jXkuxwH3cSqfPMTAXr1uoCUF23M9JxHwIMJXMhPd7BtYOHmzMwkHNL/ECsMfIm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711323574; c=relaxed/simple; bh=gZlmWmYHeEPssd+jm6Q0rdE6stob/+WnvKW/S/OzDzE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gPTI754ARl5FHKyNihHoG542X0B8i3kVE/Df8q7Pxua/OPHdu1Y35VgWvCg8DUSmwRHjkYONgPPrLwc+ZjgQRYXpwfqKn1H40Fb5FYFmjWi7oIaLnSpJKzNYXj/6Ecn5z2AKuVZZ/Txs+hsgirn+kajfKLcxdsK+bfsGaDcwk5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fMyUXeSh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A13ACC43390; Sun, 24 Mar 2024 23:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711323573; bh=gZlmWmYHeEPssd+jm6Q0rdE6stob/+WnvKW/S/OzDzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fMyUXeShIr48kE1lTlL40QU0yY5rLEP7UzPB/0SJwGlxbo5FXqjoODhaReaURIDtr GTIlhld8cAqdZd/Dwl8uqTSbjKAjFQmPw+eYfjGG5y8tbOJzsRQ2aBCQT9Q38ttNvs lzIkiLckP9ODTq8ycyIQ80zCei6F77AV6+e0RH1Zq7/MiFZOk9v+X1Hw9KzItWxpRC Ttkel4Gydmo4aRxrG5xf/XhC2BS0i/ER6kZcx3pgxmgZ3WXw977JfTzWK7ZyIuVduV 2KAAxzX1uFdzLQrOXUxMFRPsAsBiCR6JL5wV/SNqSc+2jUMDh5QrXIhs02Yq7SO0R/ u/9k/VGipTZBw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tudor Ambarus , Sam Protsenko , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 5.15 280/317] tty: serial: samsung: fix tx_empty() to return TIOCSER_TEMT Date: Sun, 24 Mar 2024 19:34:20 -0400 Message-ID: <20240324233458.1352854-281-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324233458.1352854-1-sashal@kernel.org> References: <20240324233458.1352854-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Tudor Ambarus [ Upstream commit 314c2b399288f0058a8c5b6683292cbde5f1531b ] The core expects for tx_empty() either TIOCSER_TEMT when the tx is empty or 0 otherwise. s3c24xx_serial_txempty_nofifo() might return 0x4, and at least uart_get_lsr_info() tries to clear exactly TIOCSER_TEMT (BIT(1)). Fix tx_empty() to return TIOCSER_TEMT. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Tudor Ambarus Reviewed-by: Sam Protsenko Link: https://lore.kernel.org/r/20240119104526.1221243-2-tudor.ambarus@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/samsung_tty.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 09b2b40b63c4d..7d3630ddebb39 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -991,11 +991,10 @@ static unsigned int s3c24xx_serial_tx_empty(struct uart_port *port) if ((ufstat & info->tx_fifomask) != 0 || (ufstat & info->tx_fifofull)) return 0; - - return 1; + return TIOCSER_TEMT; } - return s3c24xx_serial_txempty_nofifo(port); + return s3c24xx_serial_txempty_nofifo(port) ? TIOCSER_TEMT : 0; } /* no modem control lines */ -- 2.43.0