Received-SPF: pass (google.com: domain of linux-kernel+bounces-116357-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <dd464059-1127-4526-86ce-b35f71e71983@intel.com>
Date: Mon, 25 Mar 2024 13:25:03 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 036/130] KVM: TDX: x86: Add ioctl to get TDX
 systemwide parameters
To: "Yamahata, Isaku" <isaku.yamahata@intel.com>
CC: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>, Paolo Bonzini
	<pbonzini@redhat.com>, "Aktas, Erdem" <erdemaktas@google.com>, "Sean
 Christopherson" <seanjc@google.com>, Sagi Shahar <sagis@google.com>, "Chen,
 Bo2" <chen.bo@intel.com>, "Yuan, Hang" <hang.yuan@intel.com>, "Zhang, Tina"
	<tina.zhang@intel.com>, Sean Christopherson
	<sean.j.christopherson@intel.com>, "isaku.yamahata@linux.intel.com"
	<isaku.yamahata@linux.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <167f8f7e9b19154d30c7fe8f733f947592eb244c.1708933498.git.isaku.yamahata@intel.com>
 <838fe705-4ebe-43f1-9193-4696baa05aad@intel.com>
 <20240323002847.GB2357401@ls.amr.corp.intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240323002847.GB2357401@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDN0cjBBU3l6UkhEa2V5Sy9GMjg1ODFLMmJOM2tna0JEMzNFVC9SNWkzTlND?=
 =?utf-8?B?ZFMzK0labzc4M0RZRmEzZWU1SG9zT29iWkw5MUJub1YrY3JQZXBTaVNFZXRu?=
 =?utf-8?B?aUNZNXNmMi93SVBWQUs5cXBubU1iRHRPM0wxbXVWM3Y1YXZsTU5EdFdRRVRi?=
 =?utf-8?B?ak5MckczSVhoV05SSXVGb3A3RnJsbkJVWGZmRkVtdDN2SUcyVk9Bc29NdVQ0?=
 =?utf-8?B?M3FXZVZFRm1Qbm05d2xlWnRFQjRrbm14bCtaMFB1OXQyM0paQzhlMWVPL0ty?=
 =?utf-8?B?OXdpUmlWdm0zWEV2ZXhuRjZ1Um1oejNuZUlnZHlVWW5IUXdoUEVRWlVJUTNW?=
 =?utf-8?B?Q3RYY01zazk5K3BjY2xLOWlla1NuV2FZR0g4NjBFTHBYWDlENEQ5Qjg0ek5L?=
 =?utf-8?B?K3pZdG5jSFhKODI5aEdsZ0VNTUhtOFhLa0ZQQlppYXdJdnRJczllSFhhdldt?=
 =?utf-8?B?VHZyZ1RTTUpSZmx0VGRPMlpFUEpaTlpiQ3d1TW9CTzlXeUFOczVXanlWd25x?=
 =?utf-8?B?RnlURUp2cVBCN21uZ2FzVkw0WngrcHc0U3FtZks4S21SZjluUTYwL1FhRzFG?=
 =?utf-8?B?Zy9aQ01vS3dCZXBDbVRtUnc1MmdwMmthaS9HTXNER1dlMlQ0b0MwTnRHeTRP?=
 =?utf-8?B?WnZsRGlQY3lRWEp3SVA2SzYyWXdBQkNvN2MrQ0EyNHAvb1VIRXU0UHprY0la?=
 =?utf-8?B?aEFVZ1RiTzAzZ0kxNHh3MG9OdUxMQVdCalpyQUR6a2VMaWNORnpkenBxRUpo?=
 =?utf-8?B?WHFjT0NjTU9NdmpIUlVIMFRzMlAwY3Jxa0hIWXBsWVoyNHVRT0haUk9QcVZD?=
 =?utf-8?B?RWZQUTdFMWVsdGtCS0F2YmMrNHA0cEdRalZQVkRVZFpmRUN5QmNnL1lySTNH?=
 =?utf-8?B?bVR4VUFLbytmd3A1ZWtiSFRUL0JISmRyN2JKVUd2RnlZdnpWQitYdnRicE41?=
 =?utf-8?B?blQzU1lqRVZ4QWFZK2dhaWY1RUZSTitIVXRZTSthVEJ6MXBMbFRMdkdTREIy?=
 =?utf-8?B?YlRXc2dMcndRSXg0WFFpbVlqUTVlVDYrazNiMW1OdjZQYTNwVVhEY1A5S0NZ?=
 =?utf-8?B?K3Qyd1dJVWpaa2VIcnBQOXdjR2NudC9yclo4UWZUdExXMjlIN0x2QUZNUnRY?=
 =?utf-8?B?cFhLeGdoR2h4dXF5RE5oeHBhQTVCU1N5TWhISVFneFg4UzFBR1puY1d3L3Zu?=
 =?utf-8?B?MXJJd0NnWTl0RFNVTFhaOVVsaTk3a3lRN3NhSVBiZEMzajJveTVPbmRVRmhC?=
 =?utf-8?B?ZjkxZmNKZmhpK21CR1J2c1BjYlJkNTkrU3JqaFh0N0xleldDWXVPL2pKYmY4?=
 =?utf-8?B?UG1mV1czUTM0c2FxN3hYRlVZLzU3clUxU29kQVFmbW50bGR1UVVtdDhFNzNK?=
 =?utf-8?B?cy9YdGZPcnZ4TnA5cWk3Lyt5UUROaDRjMjhOeGV3cHBnemNVN2dQeEo5RUpp?=
 =?utf-8?B?dy94cnhuYjI1TGVlTjQ0ZUlSY3RVbWlSWFk3TnAydyt6c0plbWE1VXpjci9u?=
 =?utf-8?B?NDVjdHhMSmtjSXI5Z1Qxd0tmOE5neE5DcXNJNVJBbmZVQmx0anN2Yk1Jdng1?=
 =?utf-8?B?TSttdm1hdUdoTjlsZzdrM3FIeFBiOTUyVjQ4SWJIMmU5ODgvdDRtMkdRU3RK?=
 =?utf-8?B?VzJmYzlER0lxZ2dLUHZBRitDN3dUNkg2dWJ2cW1MR3Q1RmpXeUsxd2dwK3gz?=
 =?utf-8?B?dEREeExOdm93cEtUOW5YbFJRNTBLYVRiZUlPR2FBbXlnUVUwWEdMLzg5MVpD?=
 =?utf-8?B?cjd1V2tnamkyYy94bW5CV0NvbTRoQzNjd1NQcWV2ejZMeW41cWFFWlpDdFZ2?=
 =?utf-8?B?U3MzdlFrL0Rod2ErVS9TeStZZ0FNSFlvRm5jNys3NG1aUFhoY09PYlVCUWNv?=
 =?utf-8?B?UGdaek5lZlhuQTRXdGJPaFhSZmdBTXZQS09mQm1ZaEJUZFgralpHalNpVUdW?=
 =?utf-8?B?dHp3dm1iK0Y2MTZCYTlDQWl1NE9GNi9lTGdBNW14ZUEzUEZKQVJ4K0FQQmJT?=
 =?utf-8?B?TEwzamdON2FMYVl2b1hIL252ZWY2NUdxZ2hBaEI2d2FSY3JKb3NwaCsxckFN?=
 =?utf-8?B?V1hiSHMrSDR6NW13UTQ3a2tlN29IWU0ybldXT1dHT2pLZ2FuSnU5R3pKMnZk?=
 =?utf-8?Q?pf3kmivvCkBOUqgR7/jcSiU5j?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c73b071-5bfe-4713-5fc4-08dc4c620a19
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2024 00:25:14.1592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JHB8iGamAZ+i86a+g6V39Z/c8sS53a6d+6BVbH+bLi4HMoK6XDq0JDg7IvgydkL2TQpLmus9DB+Web1KYXjGHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8067
X-OriginatorOrg: intel.com


On 23/03/2024 1:28 pm, Yamahata, Isaku wrote:
>>> +	if (copy_to_user(user_caps->cpuid_configs, &tdx_info->cpuid_configs,
>>> +			 tdx_info->num_cpuid_config *
>>> +			 sizeof(tdx_info->cpuid_configs[0]))) {
>>> +		ret = -EFAULT;
>>> +	}
>> I think the '{ }' is needed here.
> Unnecessary? Will remove braces.

Right.  Sorry I didn't finish the 'isn't'.