Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2583007lqp; Mon, 25 Mar 2024 03:30:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUvvwhIiEusdcbL2ThVxVIy6/dwMZYrYUb6Y7fJ0Nl1yUJhGDLgyvM0kNHeXXqtdDY1GxceAHZZSaR18C5b9VScP9brlvI9aqRxNPzbnQ== X-Google-Smtp-Source: AGHT+IGpPoy4l5CSzAc0gvP6tN8Q1GMYtSnOVS8FhUVE+6VN5AJ7azJAUI8MuIG6173ANhDKuh4X X-Received: by 2002:a17:907:720a:b0:a47:5171:8d56 with SMTP id dr10-20020a170907720a00b00a4751718d56mr3002041ejc.13.1711362641920; Mon, 25 Mar 2024 03:30:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711362641; cv=pass; d=google.com; s=arc-20160816; b=nJ13eNtjC+/VV/GxANjXyESSgZOBfVplZP9EUShTq/G1+Ha5q5J1NFQO7hTwR5vpY/ mtA8EC7WgYgG51Xb6n1VzEuk1sCDfVF+QjLIux04znUFd9UxZHSC8RAOAAaHznG8mZbi JifW6tS5zBYL7Uv2vjWHDZGIQZfayQyc9PBhUNfAHJ4AbaeRpMshEdkKhPl+v0e3ZWE1 9NPXQs/7xMwFwKwktxG77qD/gTYgMe54JGG3ju8QOG8olM2aod8Go2//cDmxIc5eEIp4 VZfLV75qE528TJdnohSMDOGAB84SepRH5JOFH6ppd2zFFq705cc5nWmt1O1ITqAKiPdK 2f6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Tt+KCmLbxApoW207RDAvbDA3d2jxGUpGGfAqGexVlsw=; fh=xsI81Od66GsWG5stXc+hD9XZa00Wm8Rt44GRJ5MLtLI=; b=Q7u/uYUMg8PH2IAdjixzJdlfcW1ImfZNvWKIrtbhrEeu17BitXC/aszV8wRhOU/fx9 v0Ene9poURUokQnCfGB42eQjxTP3rcRucouS5F1/AkkZXpr1vRd1xqTp9fCtVLnUWIVz aVJIejcC9E+vTXOhg7uRzg5kmNo9ZPzM/depIAtnZNrX6Je3+Y/14nw6ge4csKCeJCv8 7cjMAEIe4ZAgPkyKwPzXNdaQ2pEN7eI5FXX+dIS/tcVrnW9h7NVEjDB0AXXArpEZpjbv 5BtaYPUhlsDlTZmZJpMehTdD2EXVgJg3sUuhIxnR3vm6xpA1l3uhLAFQ5ZGSlLyWGVIo 1kWA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cC4Kztk1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115300-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id b11-20020a17090636cb00b00a46be00671csi2338193ejc.11.2024.03.25.03.30.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 03:30:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-115300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cC4Kztk1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115300-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AB1BC1F3333E for ; Mon, 25 Mar 2024 10:30:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F2EC21D566F; Mon, 25 Mar 2024 02:32:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cC4Kztk1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 355767FBBD; Sun, 24 Mar 2024 22:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320491; cv=none; b=qG6qbhfXQxlweXJ85ygUIABqxmjxGdrL9WAlvZY4EUSTx+7Q6TmvVa06C3QRSDkk142JLlX/poxg22ci2pgnvHPh2VkZEFAHjTkOYYrt4Yywf4KiGiqwaMnAQKF17kbJSREDXMzr4XGQRC+aNKwQocgo7Nfa/vz/m7Z19/7gsak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320491; c=relaxed/simple; bh=O3gGOkuRyZFboL0fmOL3hrmSbPvbiXSEcZC/rrfIDxE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T1BVDlAoVO4jQLq9/kWMdbDoNvzxGgzXJ2jwCMpKacwnsUu9Oacr5QXl+etlsaLq9H9MKN6nRti76/1xYjCv1dHY4Gxv2+U5JBmwfWhTED7ewCMBsvnNyZdlGi44zlbXIMTeOdaPF1i84eTCVxrEDkIs6smMPRHN5n5YWwTu7B0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cC4Kztk1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E325C433C7; Sun, 24 Mar 2024 22:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320491; bh=O3gGOkuRyZFboL0fmOL3hrmSbPvbiXSEcZC/rrfIDxE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cC4Kztk1gliV/Kfy/ZmfSysFD5iox9TcOe21G1IbIqkBQJyOprbOFF2gEmx66hXwl ObWaraxrz5BWB/ItawEN0YMpAMYaZN9l6RPUkAqw/33f3iUCXBdjBUVs26/QyA4zdU u7vMQI5SgWuS91FOtZLpaMWz8tNKaqNq/D+76VEG71D9gnHwqNXD9zzxuzuww1n41Z 0Gg5pN0TWGSjB1r2aZFdcKpgOkGtqtXEwnz4wTFr2Tiy6/M6/G644ZTzn1XrK80sda 4efVHQkuvqz60aiD/td/oDRhM9q6ah0GojbKs5TQE7FN2mnJ2/9w7hwOyl4atztaYy EvuHwsWXeBYiQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Emmanuel Grumbach , Miri Korenblit , Johannes Berg , Sasha Levin Subject: [PATCH 6.7 050/713] wifi: iwlwifi: mvm: fix the TXF mapping for BZ devices Date: Sun, 24 Mar 2024 18:36:16 -0400 Message-ID: <20240324224720.1345309-51-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Emmanuel Grumbach [ Upstream commit d3433d1bb7bde449035f54b7000361ce151bad07 ] Those devices' fifos are numbered differently. Because of that, we were looking at the size of the VO fifo size to determine the size of the A-MSDU which led to a lower throughput. Note that for those devices the only user of the AC -> fifo mapping is the size limitation of A-MSDU. Signed-off-by: Emmanuel Grumbach Signed-off-by: Miri Korenblit Link: https://msgid.link/20240218194912.da336ca2fa0a.I73e44d5fc474ebb6f275b9008950e59c012f33b2@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- drivers/net/wireless/intel/iwlwifi/fw/api/txq.h | 12 +++++++++++- drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c | 11 +++++++++++ drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 8 ++++++-- 3 files changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/txq.h b/drivers/net/wireless/intel/iwlwifi/fw/api/txq.h index 9c69d36743846..e6c0f928a6bbf 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/api/txq.h +++ b/drivers/net/wireless/intel/iwlwifi/fw/api/txq.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ /* - * Copyright (C) 2005-2014, 2019-2021, 2023 Intel Corporation + * Copyright (C) 2005-2014, 2019-2021, 2023-2024 Intel Corporation * Copyright (C) 2013-2015 Intel Mobile Communications GmbH * Copyright (C) 2016-2017 Intel Deutschland GmbH */ @@ -66,6 +66,16 @@ enum iwl_gen2_tx_fifo { IWL_GEN2_TRIG_TX_FIFO_VO, }; +enum iwl_bz_tx_fifo { + IWL_BZ_EDCA_TX_FIFO_BK, + IWL_BZ_EDCA_TX_FIFO_BE, + IWL_BZ_EDCA_TX_FIFO_VI, + IWL_BZ_EDCA_TX_FIFO_VO, + IWL_BZ_TRIG_TX_FIFO_BK, + IWL_BZ_TRIG_TX_FIFO_BE, + IWL_BZ_TRIG_TX_FIFO_VI, + IWL_BZ_TRIG_TX_FIFO_VO, +}; /** * enum iwl_tx_queue_cfg_actions - TXQ config options * @TX_QUEUE_CFG_ENABLE_QUEUE: enable a queue diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c index c4f96125cf33a..25a5a31e63c2a 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c @@ -31,6 +31,17 @@ const u8 iwl_mvm_ac_to_gen2_tx_fifo[] = { IWL_GEN2_TRIG_TX_FIFO_BK, }; +const u8 iwl_mvm_ac_to_bz_tx_fifo[] = { + IWL_BZ_EDCA_TX_FIFO_VO, + IWL_BZ_EDCA_TX_FIFO_VI, + IWL_BZ_EDCA_TX_FIFO_BE, + IWL_BZ_EDCA_TX_FIFO_BK, + IWL_BZ_TRIG_TX_FIFO_VO, + IWL_BZ_TRIG_TX_FIFO_VI, + IWL_BZ_TRIG_TX_FIFO_BE, + IWL_BZ_TRIG_TX_FIFO_BK, +}; + struct iwl_mvm_mac_iface_iterator_data { struct iwl_mvm *mvm; struct ieee80211_vif *vif; diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h index f2af3e5714090..3be67f0ff74f7 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h @@ -1574,12 +1574,16 @@ static inline int iwl_mvm_max_active_links(struct iwl_mvm *mvm, extern const u8 iwl_mvm_ac_to_tx_fifo[]; extern const u8 iwl_mvm_ac_to_gen2_tx_fifo[]; +extern const u8 iwl_mvm_ac_to_bz_tx_fifo[]; static inline u8 iwl_mvm_mac_ac_to_tx_fifo(struct iwl_mvm *mvm, enum ieee80211_ac_numbers ac) { - return iwl_mvm_has_new_tx_api(mvm) ? - iwl_mvm_ac_to_gen2_tx_fifo[ac] : iwl_mvm_ac_to_tx_fifo[ac]; + if (mvm->trans->trans_cfg->device_family >= IWL_DEVICE_FAMILY_BZ) + return iwl_mvm_ac_to_bz_tx_fifo[ac]; + if (iwl_mvm_has_new_tx_api(mvm)) + return iwl_mvm_ac_to_gen2_tx_fifo[ac]; + return iwl_mvm_ac_to_tx_fifo[ac]; } struct iwl_rate_info { -- 2.43.0