Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2596200lqp; Mon, 25 Mar 2024 04:02:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVAxlI9/OkhxiaN+Y9m0ni77YPbdB4UtaXA6scDzhLBlIwk3CZX6zIkYTa7GsMoEGFQawlauNrjsgTjLYjXy5YgOSrXufpKzvIohKIdxA== X-Google-Smtp-Source: AGHT+IGECIIhrBdxNU9ZOEwgg9YzWbQjVqznBK2H8KPHsbUF2cX/6sBwkYxUJMpmKZEgE7JpIAgw X-Received: by 2002:a17:906:f592:b0:a4b:7394:e46e with SMTP id cm18-20020a170906f59200b00a4b7394e46emr767606ejd.50.1711364541473; Mon, 25 Mar 2024 04:02:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711364541; cv=pass; d=google.com; s=arc-20160816; b=giFU5Xoz7yrud6NUqG9q4tYiPzLYZ/BuEVM03tHWW2PuOWOwc7NHcvWkJ1ViIoK18E 9BRUnfZuNgw4Or6pWtjthfhXhT9xTfC6oM8cGkGiyZF5GHIs2lcj7tqmUMmGGNXDNBPV 0huYMhZf6CWkaiFxDGq4Vd+Xt4il93ja7jO/qH9vOUHIpcMK2vt3+i+wp0TsEov/NYMQ fJ8S418d1SchlPXPnqNBc0Y15Bv3Un9CkGOtrDJw3izFCPlCunbxD4EnUVpy8HXlm5fx mM4K5A1Yuil+BhPxTeMMemwW4Q7OA3oYH4Admx19Z4afiUp18KZe8NMNVv29nXkbaeOZ ukPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=mIofL4WnH3qUEewcIjBLDv3eNO2NuzaAmVDyvFB2LGA=; fh=BV5nIM+fRH+C6OnOVxOkDjjtuSYDDVgY4OJrj6N2OIw=; b=wNkdTU3jES1zSJE+SSc8kxQNvflfDNQqEqCJgYIdlpwnLoFNxnxkNF9XlCMVSBy7Kq Slo967KIVKqgI7c9zB+U6v4JBSF55ydMWsfT4nMLeuwHoDTPf12FMcTaWi05XnC8iYfK J2eY01OIz/OmVTtlKNSaU0NdaDq/cIf9oUXHbBcaer/PljFjsjZbh1uyW43Cb8DkKWxg HsU0cmd/sYOXmBIWe/CwYvrnXNWNJx+Z/Fd3b2UWjTUmThu5yi7vt+dZ0xJx6aCuNJBh qUs8bnMeu/U6jGcabNzwtkV55vTWWpQcawTY0zm60M0JtWMKjVh1Y4j2Y9GlbUxSn9+L 0fag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EPQpMLkz; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115475-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115475-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id f11-20020a170906048b00b00a46b8563a31si2288303eja.405.2024.03.25.04.02.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 04:02:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-115475-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EPQpMLkz; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115475-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115475-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 379C91F30E36 for ; Mon, 25 Mar 2024 11:02:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89652223BB2; Mon, 25 Mar 2024 02:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EPQpMLkz" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 214C21E9F8D; Sun, 24 Mar 2024 22:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320906; cv=none; b=n/V0DHc7ydY6mnSVoFXSuLCrn7Jvs/fCQ+b2soWfDnylipxwNYL6hqCL7bJnuTRVYc8rwMB2PoqFqvNPo27YjNs1yKU3eK/VneSb+JVFfqgDcp/c1Qzord/C+ImaovVefuWdrmEw40n/t+juN7ii/pWPCJUqhDBtVN4OWqoRipg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320906; c=relaxed/simple; bh=Gd32IM3+MPoIdKqaSx0pqzYfX7z6P6j7xfsNndqjB/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iM0a/WCtvp1pEJBMuCzrvVA8Chbi2h+JEcfp/9BTDF/mOmmU3fP64Qxm0z6Z7uYGbK4viJHuCtLjcdw7n/ZTuk92YBzjQTE+/uA077Lmhcfm/hLL4r/ifGT8oqjDBfsPK5bwS4BuUzpPiRoYCPgAouK1incV1YO3Ap3X6pnBiHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EPQpMLkz; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A29BC433C7; Sun, 24 Mar 2024 22:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320906; bh=Gd32IM3+MPoIdKqaSx0pqzYfX7z6P6j7xfsNndqjB/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EPQpMLkzCTuutXGG29xsupB0WDgjoaScYvQB/Fd7SMdPAKSwQjscs/Ch5nQWGJzb0 ZIk75clLm74i/K9ncZVDh/aF5RdhkSSrUcEOYkzcDYCZqxAAebzsOiECEvk3/4Kjiq xV24vlNFnze9Vs0dciKXzKgO1FstwW+M97mx98HsVoPOdlbE+MASw3xVk3j3rE/odU w+i7F6i9kMjkHMQAYBzUa289/DLwR4sePQfi/cha+rdBNEwAAAec9jyftsiEWyzaVc FD38rBDxh9/BIh2eLDboVBHX/fy4izxLPEAlHN8M7NzKvQGxWIIy8DrjXOKRUqMz30 XZ8N9hPolZO+Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lucas Stach , Philipp Zabel , Hans Verkuil , Sasha Levin Subject: [PATCH 6.7 469/713] media: imx: csc/scaler: fix v4l2_ctrl_handler memory leak Date: Sun, 24 Mar 2024 18:43:15 -0400 Message-ID: <20240324224720.1345309-470-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Lucas Stach [ Upstream commit 4797a3dd46f220e6d83daf54d70c5b33db6deb01 ] Free the memory allocated in v4l2_ctrl_handler_init on release. Fixes: a8ef0488cc59 ("media: imx: add csc/scaler mem2mem device") Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/staging/media/imx/imx-media-csc-scaler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/imx/imx-media-csc-scaler.c b/drivers/staging/media/imx/imx-media-csc-scaler.c index 1fd39a2fca98a..95cca281e8a37 100644 --- a/drivers/staging/media/imx/imx-media-csc-scaler.c +++ b/drivers/staging/media/imx/imx-media-csc-scaler.c @@ -803,6 +803,7 @@ static int ipu_csc_scaler_release(struct file *file) dev_dbg(priv->dev, "Releasing instance %p\n", ctx); + v4l2_ctrl_handler_free(&ctx->ctrl_hdlr); v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); v4l2_fh_del(&ctx->fh); v4l2_fh_exit(&ctx->fh); -- 2.43.0