Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2599723lqp; Mon, 25 Mar 2024 04:08:01 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVZ/yRjysGi42PiaIrw+SFnjIzTmdGXP4TKG1qbmHGFf7yr/ai1AakxqKM2dTvTtQDh3wN0NrGHMtpBeHHaYuaBCiA3mp+CTuxeM/7yhQ== X-Google-Smtp-Source: AGHT+IG44qfvkXunTndkzapd0yUVPj71ss21mu9UIyJxGkyiwK6Fb4ua74+5slWfVo8LocoxKWAg X-Received: by 2002:a17:907:6d0b:b0:a49:7078:582a with SMTP id sa11-20020a1709076d0b00b00a497078582amr2472690ejc.35.1711364881023; Mon, 25 Mar 2024 04:08:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711364881; cv=pass; d=google.com; s=arc-20160816; b=QaphM1mi3HDqHENZFsKOOH7VhKg2paBdz3bJdLVC2cwJlijQ2abRUHyIZnv5xjsXKp 0SmtzBjPaCS4ZyNm69yI2U4J3GS+q8xZ8YUelzkj+uViyiP1//PnXv/m4heik+6v5Q1h EXxNISwg6HXzmvJJY1z/rjzRLqn/AO0WIA5qqmC5QO+bWfgCXpPqb0jBBfzwLYpzfHsv cQx6NIFl2UC5z2zAdSiPmzd98wOnx2vJaBwPtg6VavFkGgQJV/hls+raFoRcvzRE6mer XxKzecrlzNWVEd6HLtkuYjXceeUmMaYH/uFXIAITLowNyDfgpb4twEBWTsDQWDz/kzDu Iaig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-id:precedence:user-agent :message-id:in-reply-to:references:from:subject:cc:to:date :dkim-signature; bh=mpHYqBGYlnixcvfc0J1Ave38pS8nETGdngwvpSQTuLI=; fh=NBGC2rVAyUTVGISZtb50OO3FcJzZuFeSyO1ZqFBeVB4=; b=RjKSpjXNE80ltCr2qnQIdv6y3pvI8D8rQ47m6ZnbShvot+/C+dDV3mDjGh5kYB8mPf xto/MWJi1pQXCfYNyO3QxsMp1OBsmJWfnA/drB24V2FRDCh1jFkU6XtItSH/rjUdFkBv 2xUaI7Cw459OyBeOGHCNyoDl9PRMq2ZoqyJI3RdxEhWAXGbsnccDxVyTzpLJmeup6q1F ZF4V9nOMgMoVdupXJjfd9F8jokZQXLwcroo2oKGyVPEQyFKh3RKvnx5FgD73hFC4uax4 prXIS4aJ2y6JONyxVXQ5MyduDHmH++7MNRB3WPVduArvj2gmJGLrTwQjE7lDBwlZFQvS gOpg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@mforney.org header.s=google header.b=IQE+vdCu; arc=pass (i=1 spf=pass spfdomain=mforney.org dkim=pass dkdomain=mforney.org); spf=pass (google.com: domain of linux-kernel+bounces-115268-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115268-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id k13-20020a170906578d00b00a4752d7a017si1297017ejq.754.2024.03.25.04.08.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 04:08:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-115268-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@mforney.org header.s=google header.b=IQE+vdCu; arc=pass (i=1 spf=pass spfdomain=mforney.org dkim=pass dkdomain=mforney.org); spf=pass (google.com: domain of linux-kernel+bounces-115268-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115268-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BFAD31F30633 for ; Mon, 25 Mar 2024 11:08:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DB151514C2; Mon, 25 Mar 2024 02:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mforney.org header.i=@mforney.org header.b="IQE+vdCu" Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 670012FE84D for ; Mon, 25 Mar 2024 01:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711328672; cv=none; b=J1ulLLAvDDVRa2pLioGa3C9CZBI2gKe72uOnFEvo14R/OHXRRzDJeTUYuRfA/Kmm/3Ck2Q7INl+4LZAoeuSeQnJFM5DJYJR9lB9TtP3+pGm0kQB0i2+ADgNnyy1cy3CYoaFNulYSviVsFYuOJV/Dui8QUjLRRlhw9ENEjxN7pK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711328672; c=relaxed/simple; bh=HLX58pQI8SXB83k8TSE9weXRimPojqSZLVQ1p1YQbgI=; h=Date:To:Cc:Subject:From:References:In-Reply-To:Message-Id; b=dXq50LSsyy8xtlzHo2XRGw3quDFQS7qus8aUquERUcrGks4sXRmb/kjvNsL0epdv/xaOxm3H/x5JAP9yTVVhKmxQ8b0lQhbUS72N/A8qLSYIH+8u49c9hF1yZVnZBRwAKmd/AVqGBsRP6L6L6vbPAeJLPmNHOBGqdgk8HflN9Gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mforney.org; spf=pass smtp.mailfrom=mforney.org; dkim=pass (2048-bit key) header.d=mforney.org header.i=@mforney.org header.b=IQE+vdCu; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mforney.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mforney.org Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1dddbe47ac1so30223815ad.1 for ; Sun, 24 Mar 2024 18:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mforney.org; s=google; t=1711328669; x=1711933469; darn=vger.kernel.org; h=user-agent:message-id:in-reply-to:references:from:subject:cc:to :date:from:to:cc:subject:date:message-id:reply-to; bh=mpHYqBGYlnixcvfc0J1Ave38pS8nETGdngwvpSQTuLI=; b=IQE+vdCuZCtEiCY60KpIUO9OQh9G++Wknz78+cyc7Ud2o2qUHznuxRpaLwpAGdJ4rd oPDPBZoJdNpoTvUheeUP8nTca9is8fwXXZM96QtWKcTHlwPaukC/wB49eWmtp4YihwBu BFgbcITIZ7zzyINgKYG+bwCKuR9xk0ZwJJzgPU8nugxfik2th0xX+4whX7SnZHPcZqxn 63i9agWvooVS+knqlPzdae5Rjs0OmX46FunjOX/z2aH66+ZFBVGgkVYkhTQZcQOm/0Ma J0ASj+MhyjhcFNjoDMOo75f1lw727O7Zwh1a7oAY5ekfmBzb2IuyIRS4ZHAIiQ6Sznkr En5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711328669; x=1711933469; h=user-agent:message-id:in-reply-to:references:from:subject:cc:to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mpHYqBGYlnixcvfc0J1Ave38pS8nETGdngwvpSQTuLI=; b=ZSDAjGTJPN5gcHdIQ8+8T0O/0wJRgyq4RHd0+Omk2urbWDMC91hKj7hCmMvz/EY36K AuKs2Ju9x+6grsrdRv2D1LqA+2JaqastqsqSDi78qapZKvdBmi8dnG5KbC4N49j5u70x Mi5eFtPm6qiGbexCU1wmeNE/Re+iWOig2ytjCR1GRNV8IJ309p9Ou5z9SofhZEF7u1/R G9aVcms0CdiH5HlmrCNitlyNiWS8FtNgslU9q6ULvhmKKyjkXxBQK0HMHitRxa9kJhXV 3czVCM5VZZRzDhiIuYWpuDCN+42BAEjGm/U/nZ6NLugSZUunCZ0IGKrBuNWYfxktgCfv lrEQ== X-Forwarded-Encrypted: i=1; AJvYcCWTmeuEFj9frUjtz9660FsnbNQnfUPlFuS0K+Av/u+yXOrxeDgkUcYNY4jaHX+MgJabHMifGCRe5nOYoae57X+vybwfD6S4YSdhnxUx X-Gm-Message-State: AOJu0YyjLFYmfvfVsKwGwxFssTQ2YFhYHdS8p09j+pIX9UPrV6sS/bqe dEMDQswg42rFXjPXib8X0KYqJZcfoxUTBwaIliP4xNF1OnlU8fkgyYLn3rGmtu0= X-Received: by 2002:a17:902:ea08:b0:1dd:dcd3:662c with SMTP id s8-20020a170902ea0800b001dddcd3662cmr8076630plg.4.1711328668680; Sun, 24 Mar 2024 18:04:28 -0700 (PDT) Received: from localhost ([2601:647:6400:20b0:cab2:9bff:fe88:d09c]) by smtp.gmail.com with ESMTPSA id g9-20020a170902740900b001dd3bee3cd6sm3618763pll.219.2024.03.24.18.04.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2024 18:04:28 -0700 (PDT) Date: Sun, 24 Mar 2024 17:22:50 -0700 To: Max Kellermann Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, brauner@kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled" From: Michael Forney References: <20240315142956.2420360-1-max.kellermann@ionos.com> In-Reply-To: <20240315142956.2420360-1-max.kellermann@ionos.com> Message-Id: <3MDOTS1CN0V39.3MG49L9WIC8VM@mforney.org> User-Agent: mblaze/1.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Max Kellermann wrote: > This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The > commit caused a regression because now the umask was applied to > symlinks and the fix is unnecessary because the umask/O_TMPFILE bug > has been fixed somewhere else already. Thanks, Max! I've verified that this fixes symlink modes for me, as well as the flatpak corruption error I was getting. > Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/ > Signed-off-by: Max Kellermann Tested-by: Michael Forney