Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2608431lqp; Mon, 25 Mar 2024 04:24:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVdWCF51OJ0Z3QsQM057HgqRBvDePCp9mGQNfFc+YZ/DmubmUh2KkkSf9XRO5ZQIhio1EUgrBal8vJLGRBm8G6lwuJWp6ounNFzzHt33g== X-Google-Smtp-Source: AGHT+IG1o6CWTiBUref+4lKK4WMOn6yWo3fyJ4ObuROuAu55YWAiWNzqtFEcX5TS/aMgRPR81dbH X-Received: by 2002:a17:906:c210:b0:a47:37af:3783 with SMTP id d16-20020a170906c21000b00a4737af3783mr4634623ejz.15.1711365883357; Mon, 25 Mar 2024 04:24:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711365883; cv=pass; d=google.com; s=arc-20160816; b=aKgZokiSkahfvywfGGgyLjjArP6eDLopP+1EcDJu57YM8UQDl9REb/rEUktvbVElyh 3re53U7yZX1U0W1oExPJhvxGORnO+ghriXa4/SAcANzW70jh6n1aXqaPNMu+JDUPctg2 ikZKKAk+z0MXAsoM7WvZ6bKTs7S0riILm5FQEwNOI6ndEprjzVRrr7IYx4rzNN8Vr+fy pmn2SrtBN9kUi52Rfksuk4j+ekKvsi2VqpTWo0SlgoxD07xwDLHJ/z4olpGgttCY3qfV Gktgf5wYk2EWV3A0JNHYxMd78Iak7VEiuXRCldcH8h2N+wT6rM89Jw3QPLW7w50ibBd+ 4jPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=FfoEAIRLDr6uAkJ5cY1F+ymEXdqriDQz9AT8FwpC9sE=; fh=5N0tdEnKFDf1V/Hu/MCrRNhk4u7Ioi5AWvmFcTfybm8=; b=WbTXt5w+1ZG3IncDEQw5SEhQRL4VEgi/2tCQmr7Usx188+mSOrs9csY+yiIJ1hhI9b WGs/JfqvCpvuZ8/WqNEZOwsBD0asdJC6bhfNG6mIAqLZIBJQQHRzQ8/efb5GshfztHdw /0/0Q4GCli1HeN43nGmyKLSaxyumUYmwiM/XQuVD+EXQAWyhVUhcVp6MU6MpD5u0tpg1 5u3al83FaD5tJDVK+Zcdgg9ABlSfr/4xKCltHvSrtTM8/riGt3kv/tipPtxlN58uE8lK t31LQ23aDHzxWhzRQHnYmIVrIQSdDTxMkXphM9i/HkCoH0Rw8PCAsDPivOavSIwUstjP cFEw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GY3G22KK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115272-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115272-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id rs13-20020a170907036d00b00a44ff52e4bdsi2358790ejb.1046.2024.03.25.04.24.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 04:24:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-115272-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GY3G22KK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-115272-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-115272-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 15BC31F363EA for ; Mon, 25 Mar 2024 11:24:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9239315B152; Mon, 25 Mar 2024 02:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GY3G22KK" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BAD77640E; Sun, 24 Mar 2024 22:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320469; cv=none; b=jdOgcIPxvk7ws3+zU3hFZWp9WtNNDIQI/QrfxsVhekpBkN3+tsCHfMufZYV3JiadA+jlb51ZTBRKPpAoh6WoAsk9dP4W/nprMYFkm4ZMXegquxzH3p16XQBVafdMEZ6TwX57OIdTvwzN65nl9nuN3aiA/PX9VUdQU/wRIIo5mJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320469; c=relaxed/simple; bh=KSF7boKFkFUKI5Y7wTzgbmgkVIR1+Hf5SXgY2kEF1mA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FS7AJmhuJnkp1cT141gjTB+o4Eg7sgkxZVM8ccGDSiQZU8oJ3ep6jsTMW/fMQ3llHHXmFma1ZMLRVB2JTYIePxBnm4Y4Yyhb1nZih8eyqO899r/RsJ5SqNWkA5I5Cp7VwKiZ8lNIOHm6lBAvLUAPCROjIH8E/fVLHB6M0blSMt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GY3G22KK; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D2CFC43390; Sun, 24 Mar 2024 22:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320469; bh=KSF7boKFkFUKI5Y7wTzgbmgkVIR1+Hf5SXgY2kEF1mA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GY3G22KKEVEaUjJmT/WpSgpoW10OsQ/muKK+H18AjOXLaYiyeEUJx1oNjW20j5x5U n2gpDeiiOf8OfBHEUn334Zkg+ZuXCSV61zioGxizzrYcM2FRU1vde3Nazi7lFLs7NG 0t4WFbDJr1PmSEhIHVX33hf4rbWZhxnIkAyDdoTPC78skFNTg2VxgVO2OY77/wjjk0 5w/ecF0+KysDmm9WyQhfWflrTSsQuS06rBhefsjcyt0zx8GWn5IvxoU7bgdA4UtDRk k/vwAmiU4C+olc+7wO7HYjkv7wUfA1nffZaEUCI6eNQi3+2h7xhGh5hsk1yfNg+5xC cAeuCAHTurEMw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yishai Hadas , Tamar Mashiah , Michael Guralnik , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.7 028/713] RDMA/mlx5: Relax DEVX access upon modify commands Date: Sun, 24 Mar 2024 18:35:54 -0400 Message-ID: <20240324224720.1345309-29-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324224720.1345309-1-sashal@kernel.org> References: <20240324224720.1345309-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Yishai Hadas [ Upstream commit be551ee1574280ef8afbf7c271212ac3e38933ef ] Relax DEVX access upon modify commands to be UVERBS_ACCESS_READ. The kernel doesn't need to protect what firmware protects, or what causes no damage to anyone but the user. As firmware needs to protect itself from parallel access to the same object, don't block parallel modify/query commands on the same object in the kernel side. This change will allow user space application to run parallel updates to different entries in the same bulk object. Tested-by: Tamar Mashiah Signed-off-by: Yishai Hadas Reviewed-by: Michael Guralnik Link: https://lore.kernel.org/r/7407d5ed35dc427c1097699e12b49c01e1073406.1706433934.git.leon@kernel.org Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx5/devx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c index 8ba53edf23119..6e19974ecf6e7 100644 --- a/drivers/infiniband/hw/mlx5/devx.c +++ b/drivers/infiniband/hw/mlx5/devx.c @@ -2949,7 +2949,7 @@ DECLARE_UVERBS_NAMED_METHOD( MLX5_IB_METHOD_DEVX_OBJ_MODIFY, UVERBS_ATTR_IDR(MLX5_IB_ATTR_DEVX_OBJ_MODIFY_HANDLE, UVERBS_IDR_ANY_OBJECT, - UVERBS_ACCESS_WRITE, + UVERBS_ACCESS_READ, UA_MANDATORY), UVERBS_ATTR_PTR_IN( MLX5_IB_ATTR_DEVX_OBJ_MODIFY_CMD_IN, -- 2.43.0