Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2677174lqp; Mon, 25 Mar 2024 06:26:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV0hHuHF14dy8nZ0sFVKYEpKyP29gpfv692ko0Nbv3LDJjnnsK4c/n/rYMhp1MAdlJ5dS0wpr1RR0l6d46lrboTfiOaIDSBXzZvq30Odg== X-Google-Smtp-Source: AGHT+IFXrJzCrUm9wU/5EMNTnX+CE0DR/bsDgcv3qz6r1KP2ECkUTq0y2PhdLQyaF/uaoX0fDldk X-Received: by 2002:a17:90a:ae0f:b0:29b:bcea:c17e with SMTP id t15-20020a17090aae0f00b0029bbceac17emr4627563pjq.1.1711373188104; Mon, 25 Mar 2024 06:26:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711373188; cv=pass; d=google.com; s=arc-20160816; b=r/3R5dTNMTk0kkpTkr2fyPGmkhvxb1rRCnmUdlh6KPCzZjVXp4TgNt2Pj4CcqD54B3 1mTpEnLRBmGvOD7QLOnfXuSrO6RaRCm2BKYAjhEevBtDI75hy+6vmrBcz6JApQp/IdIF QEbIGX2IbPzZiGrRvciYmyGCtWfqExOsbmCjVNO0z14c82rNtM0rAdsvqp3ZD5B6RjnX g9erZUZrShJFpmQpeBXJgJLROua5vYKwvmBbxH0o9oPsoAreEZQndCPp3k6sAWEnenbx 94HaMDbU0bd/24FplByoNrbyznhtdLWikhFx38RsX4GflRQ6i8Sjr2Ozui8Kbyq+x8S/ FvKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=kud17s49U6X7uxcMJkcWdn048tXtlxGBJDL1C9hF/qw=; fh=NRwlJ284ToFbSKBkOTsblqGNTTWdNBBA2dEQ7V5r8oc=; b=TxzviQIBeGx9IpRgMQ8nPMVtdlAObVHxVpujJ1tT6dIql/aIbK/HNNdPnw4yUA/VMN V3WA6bdJh874z8fBjeZwUtCTHnPi3ZaY0bLHbJFilx/muqXg/hDXNQRA+oXQt59QlE+k Rnuprj06+D4VHQdbPzBfgXYe/1R+S9hDF2nH7kVG7Y0MGb2qG9AOSEbFxO9G1ACEm1us TAZCPm2SBxR+sQvHv8MO4g9Pp/GoMAUhuUrXLOvbazJ43vkisVGq3H5w0v9y5bDLxUqa goLCAvXLjqMNWijRFcTc0ONBsFmwX/Ys3a4oEMIgZSodbnA3uhtj6Kcyc0+6NNJRd6L4 tNAA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gO9qjg06; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-116644-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116644-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s9-20020a17090aad8900b0029bbd5272basi7755378pjq.135.2024.03.25.06.26.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 06:26:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-116644-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gO9qjg06; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-116644-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-116644-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A61032C52C7 for ; Mon, 25 Mar 2024 13:26:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D64AE189A3C; Mon, 25 Mar 2024 09:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gO9qjg06" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E222E17D24E for ; Mon, 25 Mar 2024 09:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711358330; cv=none; b=P5NeZWUNY9i7DN/G11cyIJmjBxcBGDKrdN+91Hr8U+EgX+7pIQCHHDUZ23YPrBN9naTzdva8o/p7HixZ1+poemlgMqL42ief205VjzutW0AjIUaaUMOYCR44YGXTyja0CBLC9LVm3ug4s1B55rjg5UZmf7Sjx0Qy+zeNT3Q9mps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711358330; c=relaxed/simple; bh=qWQyoJs9pVjCqc2Pa3KfTf+rHmXe8/PnXNXrea71Hk8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UaP3LHf8GjrPA8OOG8iP/yTXCPKMf8odp9s4papq9am2SUu/IpwXPF8TxXxeMD+P85agh55cG7+7afs9RchNkF+G3eLTUkE++Iufta8XllGQlQluaGTUlxmuIdXUeQ5sitHLgftEZVIKhRnuQL26YiAvXt11ajRPPMnTX2HMFmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gO9qjg06; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711358328; x=1742894328; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qWQyoJs9pVjCqc2Pa3KfTf+rHmXe8/PnXNXrea71Hk8=; b=gO9qjg068vpIO5Kh4Q0oD/zjUqeqsQyIjK41YcJHHdLs4KgtfbcPQgrO NThRAHAkyZUQylR2tH7mBknzX54nfMUR2NpwLF9/fZ3AJwxg43BYX1npj EkIwCT93mpqk7OtAPzC7mw/YoFM+XsC1zmEfPLw+VejkjVgccA4dMw5Vl 95fP0+DmF5AO+ukzhG9HU2bNIbBPcfR6Vr69lYK8DtlT3D+6uO0TdyPk4 +sXKfUoAo6/kubun8mcADMES/s6P+Cy7ZGLop4UBUtXnaMBBned7UACsN 2HtbmVxLzW82oa5sciANl4dSsH6UWdPoZLFh8Q+q17KI0DT+v+gHiHFxs A==; X-IronPort-AV: E=McAfee;i="6600,9927,11023"; a="28826428" X-IronPort-AV: E=Sophos;i="6.07,152,1708416000"; d="scan'208";a="28826428" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2024 02:18:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11023"; a="914837371" X-IronPort-AV: E=Sophos;i="6.07,152,1708416000"; d="scan'208";a="914837371" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2024 02:18:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rogTa-0000000Fvcn-1hGy; Mon, 25 Mar 2024 11:18:42 +0200 Date: Mon, 25 Mar 2024 11:18:42 +0200 From: Andy Shevchenko To: Shahar Avidar Cc: gregkh@linuxfoundation.org, elder@linaro.org, robh@kernel.org, parthiban.veerasooran@microchip.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] staging: pi433: Fix includes & macros. Message-ID: References: <20240324093201.793485-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240324093201.793485-1-ikobh7@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sun, Mar 24, 2024 at 11:31:58AM +0200, Shahar Avidar wrote: > 1. Untangle include hierarchy. > 2. Update #minors the driver can accept. > 3. Make use of general macro instead of magic number. > Shahar Avidar (3): > staging: pi433: Use headers in appropriate files. > staging: pi433: Reduce N_PI433_MINORS to conform with N_SPI_MINORS. > staging: pi433: Make use of spi mode macro instead of magic number. For patches 1 and 3 Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko