Received-SPF: pass (google.com: domain of linux-kernel+bounces-116645-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 25 Mar 2024 11:20:16 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: Herve Codina <herve.codina@bootlin.com>, llvm@lists.linux.dev,
	oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: include/linux/framer/framer.h:184:16: warning: no previous
 prototype for function 'framer_get'
Message-ID: <ZgFB0C5KilzltDKz@smile.fi.intel.com>
References: <202403241110.hfJqeJRu-lkp@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202403241110.hfJqeJRu-lkp@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Sun, Mar 24, 2024 at 11:19:28AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   70293240c5ce675a67bfc48f419b093023b862b3
> commit: 54762918ca856028d33d1d56d017a4d7706c6196 net: wan: fsl_qmc_hdlc: Add framer support
> date:   13 days ago
> config: powerpc-randconfig-003-20240324 (https://download.01.org/0day-ci/archive/20240324/202403241110.hfJqeJRu-lkp@intel.com/config)
> compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 23de3862dce582ce91c1aa914467d982cb1a73b4)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240324/202403241110.hfJqeJRu-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202403241110.hfJqeJRu-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):

> 82c944d05b1a24 Herve Codina 2023-11-28  183  
> 82c944d05b1a24 Herve Codina 2023-11-28 @184  struct framer *framer_get(struct device *dev, const char *con_id)
> 82c944d05b1a24 Herve Codina 2023-11-28  185  {
> 82c944d05b1a24 Herve Codina 2023-11-28  186  	return ERR_PTR(-ENOSYS);
> 82c944d05b1a24 Herve Codina 2023-11-28  187  }
> 82c944d05b1a24 Herve Codina 2023-11-28  188  
> 82c944d05b1a24 Herve Codina 2023-11-28 @189  void framer_put(struct device *dev, struct framer *framer)
> 82c944d05b1a24 Herve Codina 2023-11-28  190  {
> 82c944d05b1a24 Herve Codina 2023-11-28  191  }
> 82c944d05b1a24 Herve Codina 2023-11-28  192  

Yeah, stubs in the headers should be static inline.

-- 
With Best Regards,
Andy Shevchenko